mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
55 lines
2.0 KiB
TypeScript
55 lines
2.0 KiB
TypeScript
/**
|
|
* GHSA-7x63-xvp5-w2jc — the kiro / amazon-q device-code action interpolates a
|
|
* caller-supplied `region` into the AWS OIDC endpoint URLs that requestDeviceCode()
|
|
* fetches. An attacker-shaped region (userinfo / fragment) re-points the outbound
|
|
* host (SSRF → cloud metadata). The route must reject a non-canonical region with
|
|
* a 400 before any outbound fetch.
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import type { NextRequest } from "next/server";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omni-oauth-region-ssrf-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const route = await import("../../src/app/api/oauth/[provider]/[action]/route.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
async function deviceCode(provider: string, region: string) {
|
|
const url =
|
|
`http://localhost/api/oauth/${provider}/device-code` +
|
|
`?startUrl=${encodeURIComponent("https://d-1234567890.awsapps.com/start")}` +
|
|
`®ion=${encodeURIComponent(region)}`;
|
|
return route.GET(new Request(url) as unknown as NextRequest, {
|
|
params: Promise.resolve({ provider, action: "device-code" }),
|
|
});
|
|
}
|
|
|
|
test("kiro device-code rejects a non-canonical region before any outbound fetch (GHSA-7x63)", async () => {
|
|
for (const bad of [
|
|
"evil.com",
|
|
"169.254.169.254",
|
|
"us-east-1@169.254.169.254",
|
|
"us-east-1#.amazonaws.com@evil.com",
|
|
"us-east-1/../..",
|
|
"US-EAST-1", // uppercase is not the canonical shape
|
|
]) {
|
|
const res = await deviceCode("kiro", bad);
|
|
assert.equal(res.status, 400, `region "${bad}" must be rejected with 400`);
|
|
}
|
|
});
|
|
|
|
test("amazon-q device-code also validates region", async () => {
|
|
const res = await deviceCode("amazon-q", "evil.com:1@169.254.169.254");
|
|
assert.equal(res.status, 400);
|
|
});
|