mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
178 lines
5.1 KiB
TypeScript
178 lines
5.1 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// #7339 — proves the synthetic omniroute_web_fetch tool call (emitted by
|
|
// webFetchInterception.ts, Phase 3-4 of #3384) is routed through the same
|
|
// generic dispatch path already proven for omniroute_web_search
|
|
// (handleToolCallExecution -> builtinSkills.web_fetch), including the
|
|
// error/abort-not-swallowed case (Hard Rule #6).
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-web-fetch-dispatch-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const coreDb = await import("../../src/lib/db/core.ts");
|
|
const { skillRegistry } = await import("../../src/lib/skills/registry.ts");
|
|
const { skillExecutor } = await import("../../src/lib/skills/executor.ts");
|
|
const { handleToolCallExecution } = await import("../../src/lib/skills/interception.ts");
|
|
const { builtinSkills } = await import("../../src/lib/skills/builtins.ts");
|
|
const { OMNIROUTE_WEB_FETCH_FALLBACK_TOOL_NAME } =
|
|
await import("../../open-sse/services/webFetchInterception.ts");
|
|
|
|
const originalWebFetchHandler = builtinSkills.web_fetch;
|
|
|
|
function resetRuntime() {
|
|
skillRegistry["registeredSkills"].clear();
|
|
skillRegistry["versionCache"].clear();
|
|
skillExecutor["handlers"].clear();
|
|
skillExecutor.setTimeout(50);
|
|
}
|
|
|
|
test.beforeEach(() => {
|
|
resetRuntime();
|
|
coreDb.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
});
|
|
|
|
test.after(() => {
|
|
builtinSkills.web_fetch = originalWebFetchHandler;
|
|
resetRuntime();
|
|
coreDb.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
const contextWithFetchBuiltin = {
|
|
apiKeyId: "key-a",
|
|
sessionId: "session-1",
|
|
requestId: "request-1",
|
|
builtinToolNames: [OMNIROUTE_WEB_FETCH_FALLBACK_TOOL_NAME],
|
|
provider: "openai",
|
|
model: "gpt-5",
|
|
};
|
|
|
|
test("handleToolCallExecution routes omniroute_web_fetch to the web_fetch builtin handler and returns the tool-result envelope", async () => {
|
|
let receivedInput: unknown;
|
|
let receivedContext: unknown;
|
|
builtinSkills.web_fetch = async (input, context) => {
|
|
receivedInput = input;
|
|
receivedContext = context;
|
|
return {
|
|
success: true,
|
|
provider: "firecrawl",
|
|
url: input.url,
|
|
content: "fetched content",
|
|
links: [],
|
|
metadata: null,
|
|
screenshot_url: null,
|
|
};
|
|
};
|
|
|
|
const result = await handleToolCallExecution(
|
|
{
|
|
choices: [
|
|
{
|
|
message: {
|
|
tool_calls: [
|
|
{
|
|
id: "call-fetch-1",
|
|
function: {
|
|
name: OMNIROUTE_WEB_FETCH_FALLBACK_TOOL_NAME,
|
|
arguments: '{"url":"https://example.com"}',
|
|
},
|
|
},
|
|
],
|
|
},
|
|
},
|
|
],
|
|
},
|
|
"gpt-5",
|
|
contextWithFetchBuiltin
|
|
);
|
|
|
|
assert.deepEqual(result.tool_results, [
|
|
{
|
|
tool_call_id: "call-fetch-1",
|
|
output: JSON.stringify({
|
|
success: true,
|
|
provider: "firecrawl",
|
|
url: "https://example.com",
|
|
content: "fetched content",
|
|
links: [],
|
|
metadata: null,
|
|
screenshot_url: null,
|
|
}),
|
|
},
|
|
]);
|
|
assert.deepEqual(receivedInput, { url: "https://example.com" });
|
|
assert.equal((receivedContext as { provider?: string }).provider, "openai");
|
|
assert.equal((receivedContext as { model?: string }).model, "gpt-5");
|
|
});
|
|
|
|
test("an unknown tool name is left untouched when builtinToolNames does not include it (#2815 no-alias-no-dispatch)", async () => {
|
|
const original = {
|
|
choices: [
|
|
{
|
|
message: {
|
|
tool_calls: [
|
|
{
|
|
id: "call-fetch-2",
|
|
function: {
|
|
name: OMNIROUTE_WEB_FETCH_FALLBACK_TOOL_NAME,
|
|
arguments: '{"url":"https://example.com"}',
|
|
},
|
|
},
|
|
],
|
|
},
|
|
},
|
|
],
|
|
};
|
|
|
|
const result = await handleToolCallExecution(original, "gpt-5", {
|
|
apiKeyId: "key-a",
|
|
sessionId: "session-1",
|
|
requestId: "request-1",
|
|
builtinToolNames: [],
|
|
});
|
|
|
|
assert.equal(result, original);
|
|
});
|
|
|
|
test("an error thrown mid-fetch (e.g. an aborted request) is surfaced, not silently dropped (Hard Rule #6)", async () => {
|
|
builtinSkills.web_fetch = async () => {
|
|
const abortError = new Error("The operation was aborted");
|
|
abortError.name = "AbortError";
|
|
throw abortError;
|
|
};
|
|
|
|
const result = await handleToolCallExecution(
|
|
{
|
|
choices: [
|
|
{
|
|
message: {
|
|
tool_calls: [
|
|
{
|
|
id: "call-fetch-abort",
|
|
function: {
|
|
name: OMNIROUTE_WEB_FETCH_FALLBACK_TOOL_NAME,
|
|
arguments: '{"url":"https://example.com"}',
|
|
},
|
|
},
|
|
],
|
|
},
|
|
},
|
|
],
|
|
},
|
|
"gpt-5",
|
|
contextWithFetchBuiltin
|
|
);
|
|
|
|
assert.deepEqual(result.tool_results, [
|
|
{
|
|
tool_call_id: "call-fetch-abort",
|
|
output: JSON.stringify({ error: "The operation was aborted" }),
|
|
},
|
|
]);
|
|
});
|