mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-07-31 20:32:20 +03:00
d7726ef80a
Eleven subsystems answered "am I running under a test runner?" with
`process.argv.some((arg) => arg.includes("test"))`. JavaScript agrees that
'latest'.includes('test') is true, so ANY argv carrying a `latest` segment — a release symlink
like /opt/omniroute/latest/server.js, an npm/npx cache path, a `--model=latest` flag — silently
put the process into test mode.
The worst consequence is src/lib/db/backup.ts: isSqliteAutoBackupDisabled() returns true, so
SQLite auto-backup simply never runs — no warning, no log. The same substring decides whether
migrationRunner runs its pending-migration check, whether cloud sync initialises, and whether
the local/token health checks, quota recovery, model-lockout settings and the WS live server
consider themselves live. All of them fail silent, which is the dangerous kind.
Replaces the eleven copies with one helper, src/shared/utils/testProcess.ts:
- env first (NODE_ENV=test, VITEST) — unchanged;
- argv: `test`/`tests` only as a WHOLE token delimited by a path separator, dot or dash, so
`--test`, `tests/unit/x.test.ts` and `src/x.test.ts` still match, while `latest`, `protest`,
`contest` and `attestation` no longer do;
- argv: runner binaries (vitest/jest/mocha/ava/tap), which have no delimiter before "test";
- execArgv as well as argv — `node --test x.js` puts `--test` in execArgv, and
modelLockoutSettings was the only copy that remembered to look there.
argv/env are parameters rather than globals so the negative cases are testable: under a test
runner the globals always say "test", which is precisely why this bug could never be caught.
tests/unit/test-process-detection.test.ts guards the regression (a `latest` path is not a test
run) alongside the positives that must keep working.
53 lines
2.9 KiB
TypeScript
53 lines
2.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { isAutomatedTestProcess } from "@/shared/utils/testProcess";
|
|
|
|
// Regression guard for the substring bug: eleven subsystems decided "am I under a test runner?" with
|
|
// `process.argv.some((a) => a.includes("test"))`. JavaScript agrees that 'latest'.includes('test') is
|
|
// true, so ANY argv carrying a `latest` path segment — a release symlink like /opt/app/latest/server.js,
|
|
// an npm cache path, a `--model=latest` flag — silently put the process into "test mode". For
|
|
// src/lib/db/backup.ts that means isSqliteAutoBackupDisabled() returns true: no SQLite auto-backup, no
|
|
// warning. Same class for migrationRunner, cloud sync, health checks and quota recovery.
|
|
//
|
|
// argv/env are parameters (not read off the global) precisely so this file can assert the negative
|
|
// cases — under the test runner the globals always say "test", which is what made the bug invisible.
|
|
|
|
const NO_ENV = {} as NodeJS.ProcessEnv;
|
|
|
|
test("a 'latest' path segment is NOT a test run (the bug that disabled backups)", () => {
|
|
assert.equal(isAutomatedTestProcess(["node", "/opt/omniroute/latest/server.js"], NO_ENV), false);
|
|
assert.equal(isAutomatedTestProcess(["node", "C:\\apps\\latest\\bin\\omniroute.mjs", "serve"], NO_ENV), false);
|
|
});
|
|
|
|
test("other words merely containing 'test' are not test runs either", () => {
|
|
for (const argv of [
|
|
["node", "/srv/protest/app.js"],
|
|
["node", "/home/u/contest-bot/index.js"],
|
|
["node", "server.js", "--model=latest"],
|
|
["node", "/opt/attestation/run.js"],
|
|
]) {
|
|
assert.equal(isAutomatedTestProcess(argv, NO_ENV), false, `argv should not read as a test run: ${argv.join(" ")}`);
|
|
}
|
|
});
|
|
|
|
test("the real runners are still detected", () => {
|
|
assert.equal(isAutomatedTestProcess(["node", "--test", "tests/unit/foo.test.ts"], NO_ENV), true, "node --test");
|
|
assert.equal(isAutomatedTestProcess(["node", "/repo/tests/unit/foo.test.ts"], NO_ENV), true, "a tests/ path");
|
|
assert.equal(isAutomatedTestProcess(["node", "/repo/src/foo.test.ts"], NO_ENV), true, "a *.test.ts file");
|
|
assert.equal(isAutomatedTestProcess(["node", "/repo/node_modules/.bin/vitest", "run"], NO_ENV), true, "vitest binary");
|
|
assert.equal(isAutomatedTestProcess(["node", "/repo/node_modules/.bin/jest"], NO_ENV), true, "jest binary");
|
|
});
|
|
|
|
test("env still wins, as before", () => {
|
|
assert.equal(isAutomatedTestProcess(["node", "server.js"], { NODE_ENV: "test" } as NodeJS.ProcessEnv), true);
|
|
assert.equal(isAutomatedTestProcess(["node", "server.js"], { VITEST: "1" } as NodeJS.ProcessEnv), true);
|
|
assert.equal(isAutomatedTestProcess(["node", "server.js"], { NODE_ENV: "production" } as NodeJS.ProcessEnv), false);
|
|
});
|
|
|
|
test("a production serve is never a test run", () => {
|
|
assert.equal(
|
|
isAutomatedTestProcess(["C:\\Program Files\\nodejs\\node.exe", "bin/omniroute.mjs", "serve"], { NODE_ENV: "production" } as NodeJS.ProcessEnv),
|
|
false
|
|
);
|
|
});
|