Files
OmniRoute/src/app/api/oauth/codex/import/route.ts
Diego Rodrigues de Sa e Souza ab01d74306 fix(codex): validate refresh_token on import before persisting (#7522) (#7525)
POST /api/oauth/codex/import accepted a payload with an already-invalidated
refresh_token and persisted it as an 'active' connection that could never
work — the failure surfaced confusingly only on first real use, long after
the import looked successful.

Validate each record's refresh_token against OpenAI's OAuth endpoint before
persisting, reusing refreshCodexToken() (free exchange, no quota). On an
unrecoverable refresh error the record is rejected with a clear re-auth
message; a valid token imports as before, with any rotated tokens applied.
Bulk import still processes each record independently — one dead token no
longer blocks the valid ones.

Reproduced live 2026-07-16: a 2026-07-10 auth.json imported clean but its
refresh_token returned 401 refresh_token_invalidated. TDD: 3 tests RED against
the old route, 5/5 GREEN with the fix.

Closes #7522
2026-07-17 02:39:11 -03:00

173 lines
5.7 KiB
TypeScript

import { NextResponse } from "next/server";
import { z } from "zod";
import { normalizeCodexImportRecord, flattenCodexImportPayload } from "@/lib/oauth/services/codexImport";
import { createProviderConnection } from "@/models";
import { isAuthRequired, isAuthenticated } from "@/shared/utils/apiAuth";
import { sanitizeErrorMessage } from "@omniroute/open-sse/utils/error.ts";
import { refreshCodexToken, isUnrecoverableRefreshError } from "@omniroute/open-sse/services/tokenRefresh.ts";
/**
* Message returned when the imported record's refresh_token is already dead
* (rotated/consumed/expired) — see #7522. Persisting a connection whose
* refresh_token can never succeed leaves an `active` connection that fails
* confusingly on first real use, long after the import looked successful.
*/
const EXPIRED_SESSION_MESSAGE =
"This Codex session has expired — run `codex login` again and re-import. " +
"(Esta sessão do Codex expirou — rode `codex login` novamente e reimporte.)";
/**
* Validate a normalized Codex import record's refresh_token against OpenAI's
* OAuth token endpoint before it is persisted as a connection. Reuses
* `refreshCodexToken()` (the same rotating-refresh-token exchange used by the
* runtime token-refresh path) instead of re-implementing the POST — the
* exchange call itself is free (no model/quota usage).
*
* Returns `null` when the token is valid (or the check was inconclusive, e.g.
* a transient network error) — the import proceeds normally in that case,
* optionally with rotated tokens already applied to `payload`. Returns an
* error string when the refresh_token is confirmed dead and the import
* should be rejected.
*/
async function validateCodexRefreshToken(
payload: { accessToken: string; refreshToken: string },
): Promise<string | null> {
let refreshResult: unknown;
try {
refreshResult = await refreshCodexToken(payload.refreshToken, undefined, null);
} catch {
// Network/transport failure: inconclusive, do not block the import.
return null;
}
if (isUnrecoverableRefreshError(refreshResult)) {
return EXPIRED_SESSION_MESSAGE;
}
if (
refreshResult &&
typeof refreshResult === "object" &&
typeof (refreshResult as { accessToken?: unknown }).accessToken === "string"
) {
const refreshed = refreshResult as { accessToken: string; refreshToken?: string };
payload.accessToken = refreshed.accessToken;
if (typeof refreshed.refreshToken === "string" && refreshed.refreshToken) {
payload.refreshToken = refreshed.refreshToken;
}
}
// `refreshResult === null` (transient error already logged inside
// refreshCodexToken) is inconclusive — fall through and import the
// originally-supplied tokens rather than blocking on a network hiccup.
return null;
}
/**
* POST /api/oauth/codex/import
*
* Bulk-import Codex (OpenAI) accounts from JSON payloads produced by the Codex
* CLI or common token-export tools. Each item may be a flat export
* (`access_token`, `refresh_token`, …) or the CLI's nested `auth.json` shape.
*
* Body: `{ accounts: object | object[] }`
*
* Returns a per-record summary so partial successes are surfaced to the UI.
*
* Ported from decolua/9router#1257 (beaaan).
*/
const bodySchema = z.object({
accounts: z.union([z.record(z.unknown()), z.array(z.unknown())], {
errorMap: () => ({ message: "accounts must be an object or an array of objects" }),
}),
});
async function requireAuth(request: Request): Promise<NextResponse | null> {
if (!(await isAuthRequired(request))) return null;
if (await isAuthenticated(request)) return null;
return NextResponse.json({ error: "Unauthorized" }, { status: 401 });
}
export async function POST(request: Request) {
const authResponse = await requireAuth(request);
if (authResponse) return authResponse;
let rawBody: unknown;
try {
rawBody = await request.json();
} catch {
return NextResponse.json(
{ error: "Invalid or empty JSON body" },
{ status: 400 },
);
}
const parsed = bodySchema.safeParse(rawBody);
if (!parsed.success) {
return NextResponse.json(
{ error: parsed.error.errors[0]?.message ?? "Invalid request body" },
{ status: 400 },
);
}
const flat = flattenCodexImportPayload(parsed.data.accounts);
if (!flat.ok) {
return NextResponse.json({ error: flat.error }, { status: 400 });
}
if (flat.records.length === 0) {
return NextResponse.json(
{ error: "No accounts found in payload" },
{ status: 400 },
);
}
const results: Array<
| { index: number; ok: true; connectionId: string; email: string }
| { index: number; ok: false; error: string }
> = [];
let imported = 0;
let failed = 0;
for (let i = 0; i < flat.records.length; i++) {
const norm = normalizeCodexImportRecord(flat.records[i]);
if (!norm.ok) {
failed += 1;
results.push({ index: i, ok: false, error: norm.error });
continue;
}
const refreshError = await validateCodexRefreshToken(norm.payload);
if (refreshError) {
failed += 1;
results.push({ index: i, ok: false, error: refreshError });
continue;
}
try {
const conn = await createProviderConnection(norm.payload as Record<string, unknown>);
imported += 1;
results.push({
index: i,
ok: true,
connectionId: String(conn.id),
email: String(conn.email ?? norm.payload.email),
});
} catch (error) {
failed += 1;
results.push({
index: i,
ok: false,
error: sanitizeErrorMessage(error instanceof Error ? error.message : String(error)),
});
}
}
return NextResponse.json({
success: failed === 0,
imported,
failed,
total: flat.records.length,
results,
});
}