mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-19 21:32:20 +03:00
c5707e65de
Merged as part of the 39-PR owner batch of 2026-09-11, validated as a unit. Boarded into one consolidated worktree cut from `release/v3.8.51` with the other 38 — zero conflicts between them. - ESLint over every changed file: no errors (the only finding was one suppression entry the batch emptied, pruned on #13243) - `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, within baseline); `check:changelog-integrity` OK - complexity 2821 / baseline 3218 and cognitive-complexity 1272 / baseline 1437 — both under baseline - 256 assertions green: 246 under node:test and 10 under vitest, which is where `tests/unit/**/*.test.tsx` actually runs - `check-file-size`: `chatCore.ts` rebaselined 6144 → 6146 for #13278 and #13276, annotated and landed on #13243 ⚠️ base-red inherited: #12732 — the provider count (356 in the docs vs the 358 the modules define) and `open-sse/utils/stream.ts` at 3115 > frozen 3098 both reproduce on the pure tip with zero contribution from this batch.
87 lines
3.3 KiB
TypeScript
87 lines
3.3 KiB
TypeScript
// Regression test for issue #12129: an internal context-handoff summary request (built in
|
|
// Chat Completions shape -- `messages`, no `input`) is dispatched through the SAME
|
|
// handleSingleModel closure that carries the ORIGINAL client request's endpoint.
|
|
// When that original endpoint matched `/responses` and the resolved handoff-model
|
|
// provider is an openai-compatible-* connection configured with apiType "responses",
|
|
// the pipeline used to decide the body was already native-Responses-shaped and skip
|
|
// chat->responses translation entirely (`_nativeOpenAICompatibleResponsesPassthrough`),
|
|
// so the upstream received `messages` on `/v1/responses` and rejected it with zero input.
|
|
//
|
|
// Fix: `shouldUseNativeOpenAICompatibleResponsesPassthrough` now requires the body to
|
|
// actually look Responses-shaped (`input` present, `messages` absent) before allowing
|
|
// the passthrough fast path, so an internally-synthesized chat-shaped body is routed
|
|
// through the normal chat->responses translation layer instead.
|
|
import assert from "node:assert/strict";
|
|
import { test } from "node:test";
|
|
|
|
import { resolveChatCoreRequestFormat } from "../../open-sse/handlers/chatCore/requestFormat.ts";
|
|
import { shouldUseNativeOpenAICompatibleResponsesPassthrough } from "../../open-sse/handlers/chatCore/passthroughHelpers.ts";
|
|
|
|
test("internal chat-shaped handoff body is no longer treated as native Responses passthrough", () => {
|
|
const clientRawRequest = {
|
|
endpoint: "/v1/responses",
|
|
headers: new Headers(),
|
|
};
|
|
|
|
const summaryBody = {
|
|
model: "some-handoff-model",
|
|
messages: [{ role: "user", content: "Summarize this conversation." }],
|
|
stream: false,
|
|
max_tokens: 800,
|
|
temperature: 0.1,
|
|
_omnirouteSkipContextRelay: true,
|
|
_omnirouteInternalRequest: "context-handoff",
|
|
};
|
|
|
|
const { sourceFormat, endpointPath } = resolveChatCoreRequestFormat({
|
|
clientRawRequest,
|
|
body: summaryBody,
|
|
provider: "openai-compatible-responses-cliproxy",
|
|
userAgent: null,
|
|
});
|
|
|
|
assert.equal(sourceFormat, "openai-responses");
|
|
assert.equal(endpointPath, "/v1/responses");
|
|
|
|
const providerSpecificData = { apiType: "responses" };
|
|
|
|
const nativePassthrough = shouldUseNativeOpenAICompatibleResponsesPassthrough({
|
|
provider: "openai-compatible-responses-cliproxy",
|
|
sourceFormat,
|
|
endpointPath,
|
|
providerSpecificData,
|
|
body: summaryBody,
|
|
});
|
|
|
|
assert.equal(
|
|
nativePassthrough,
|
|
false,
|
|
"fixed: chat-shaped internal body must not take the native-Responses passthrough shortcut"
|
|
);
|
|
|
|
assert.equal((summaryBody as Record<string, unknown>).input, undefined);
|
|
assert.ok(Array.isArray(summaryBody.messages) && summaryBody.messages.length > 0);
|
|
});
|
|
|
|
test("genuine Responses-shaped body still takes the native passthrough fast path", () => {
|
|
const genuineResponsesBody = {
|
|
model: "gpt-5.6-sol",
|
|
input: [{ role: "user", content: [{ type: "input_text", text: "Hello" }] }],
|
|
stream: false,
|
|
};
|
|
|
|
const nativePassthrough = shouldUseNativeOpenAICompatibleResponsesPassthrough({
|
|
provider: "openai-compatible-responses-cliproxy",
|
|
sourceFormat: "openai-responses",
|
|
endpointPath: "/v1/responses",
|
|
providerSpecificData: { apiType: "responses" },
|
|
body: genuineResponsesBody,
|
|
});
|
|
|
|
assert.equal(
|
|
nativePassthrough,
|
|
true,
|
|
"a genuine Responses-shaped client body must keep the zero-translation fast path"
|
|
);
|
|
});
|