mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-07-31 12:22:14 +03:00
4b2e9b780a
`bun add -g omniroute` (and any runtime that does not reliably run the better-sqlite3 postinstall script) leaves the *.node binary undownloaded. The `bindings()` loader then throws "Could not locate the bindings file" BEFORE any DLOPEN happens, which the previous detector missed — the user saw a generic 500 page instead of the friendly "Run npm rebuild better-sqlite3" guide. Extended isNativeSqliteLoadError() to recognise: - "Could not locate the bindings file" (bindings module preflight) - "Cannot find module 'better-sqlite3'" (package not even installed) - code === "MODULE_NOT_FOUND" (Node loader fallback) isNativeSqliteLoadError is now exported so tests can pin the contract; the detector covers both the "wrong NODE_MODULE_VERSION" and "binary never shipped" failure modes operators have hit in practice.
55 lines
2.4 KiB
TypeScript
55 lines
2.4 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
import { isNativeSqliteLoadError } from "../../src/lib/db/core";
|
|
|
|
test("isNativeSqliteLoadError detects Module did not self-register", () => {
|
|
const err = new Error("Module did not self-register: better_sqlite3.node");
|
|
assert.equal(isNativeSqliteLoadError(err), true);
|
|
});
|
|
|
|
test("isNativeSqliteLoadError detects NODE_MODULE_VERSION mismatch", () => {
|
|
const err = new Error(
|
|
"The module was compiled against a different Node.js version using NODE_MODULE_VERSION 115."
|
|
);
|
|
assert.equal(isNativeSqliteLoadError(err), true);
|
|
});
|
|
|
|
test("isNativeSqliteLoadError detects ERR_DLOPEN_FAILED in message", () => {
|
|
const err = new Error("ERR_DLOPEN_FAILED while loading better_sqlite3.node");
|
|
assert.equal(isNativeSqliteLoadError(err), true);
|
|
});
|
|
|
|
test("isNativeSqliteLoadError detects ERR_DLOPEN_FAILED via error.code", () => {
|
|
const err = Object.assign(new Error("dlopen failed"), { code: "ERR_DLOPEN_FAILED" });
|
|
assert.equal(isNativeSqliteLoadError(err), true);
|
|
});
|
|
|
|
// #2358 — bun and similar runtimes skip postinstall, so the *.node binary
|
|
// is never downloaded. `bindings()` produces this exact message before any
|
|
// DLOPEN even happens, and we need to surface the friendly rebuild guide.
|
|
test("isNativeSqliteLoadError detects 'Could not locate the bindings file' (bun #2358)", () => {
|
|
const err = new Error(
|
|
"Could not locate the bindings file. Tried: → /Users/x/.../better-sqlite3/build/better_sqlite3.node"
|
|
);
|
|
assert.equal(isNativeSqliteLoadError(err), true);
|
|
});
|
|
|
|
test("isNativeSqliteLoadError detects 'Cannot find module better-sqlite3'", () => {
|
|
const err = new Error("Cannot find module 'better-sqlite3'");
|
|
assert.equal(isNativeSqliteLoadError(err), true);
|
|
});
|
|
|
|
test("isNativeSqliteLoadError detects MODULE_NOT_FOUND via error.code", () => {
|
|
const err = Object.assign(new Error("not found"), { code: "MODULE_NOT_FOUND" });
|
|
assert.equal(isNativeSqliteLoadError(err), true);
|
|
});
|
|
|
|
test("isNativeSqliteLoadError returns false for unrelated errors", () => {
|
|
assert.equal(isNativeSqliteLoadError(new Error("SQLITE_BUSY: database is locked")), false);
|
|
assert.equal(isNativeSqliteLoadError(new Error("ENOENT: no such file")), false);
|
|
assert.equal(isNativeSqliteLoadError(null), false);
|
|
assert.equal(isNativeSqliteLoadError(undefined), false);
|
|
assert.equal(isNativeSqliteLoadError("some string"), false);
|
|
});
|