mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-18 21:02:50 +03:00
Pollinations and Perplexity-web can answer a genuine failure (expired session, exhausted free-tier credits) with HTTP 200 and a structurally normal completion whose assistant text is just the provider's own error prose. classifyProviderError() only inspects the body for 400/401/402/403/429, and detectMalformedNonStream() only checked structural emptiness, so the error text reached the client as a real answer and combo/auto-fallback never triggered. Adds classifyFakeSuccessBody() in errorClassifier.ts — allowlisted to pollinations/perplexity-web, reusing the existing CREDITS_EXHAUSTED_SIGNALS/ACCOUNT_DEACTIVATED_SIGNALS phrase lists, gated on short content with a dominant signal match — and wires it into detectMalformedNonStream() so the existing malformed-200 / combo-failover path picks it up with no other handler changes. Regression test: tests/unit/diagnostics-fake-success-13461.test.ts
413 lines
18 KiB
TypeScript
413 lines
18 KiB
TypeScript
/**
|
|
* Diagnostics for malformed HTTP-200 upstream responses.
|
|
*
|
|
* Surfaces HTTP-200-but-empty upstream responses (empty SSE stream, empty
|
|
* translated body) as structured, sanitized errors rather than silent
|
|
* `output:[]` / `choices:[]` successes.
|
|
*
|
|
* Hard Rule #12: every string that reaches an HTTP/SSE response body MUST
|
|
* route through sanitizeErrorMessage(). All helpers below enforce this.
|
|
*/
|
|
|
|
import { sanitizeErrorMessage } from "./error.ts";
|
|
import { classifyFakeSuccessBody } from "../services/errorClassifier.ts";
|
|
|
|
// ── Types ────────────────────────────────────────────────────────────────────
|
|
|
|
export type MalformedReason =
|
|
| "empty"
|
|
| "stall"
|
|
| "abort"
|
|
| "client_closed"
|
|
| "no_terminal"
|
|
| "parse_fail"
|
|
| "empty_choices"
|
|
| "empty_stream"
|
|
// #13461: a 2xx body whose assistant text is the provider's own error
|
|
// prose disguised as a successful completion (allowlisted providers only
|
|
// — see classifyFakeSuccessBody in open-sse/services/errorClassifier.ts).
|
|
| "content_is_upstream_error"
|
|
| string;
|
|
|
|
export interface ReportMalformed200Opts {
|
|
mode: string;
|
|
provider?: string | null;
|
|
model?: string | null;
|
|
connectionId?: string | null;
|
|
reason?: MalformedReason;
|
|
recvBytes?: number;
|
|
recvLines?: number;
|
|
emitted?: number;
|
|
events?: Record<string, number>;
|
|
ttftMs?: number;
|
|
elapsedMs?: number;
|
|
}
|
|
|
|
// ── Internal helpers ─────────────────────────────────────────────────────────
|
|
|
|
// Human-readable reason text surfaced to the client and logs.
|
|
// These strings end up in error.message — they are passed through
|
|
// sanitizeErrorMessage before being embedded in any response body.
|
|
const REASON_MESSAGES: Record<string, string> = {
|
|
empty: "no content produced",
|
|
stall: "stream stalled (no data within the stall window)",
|
|
abort: "stream aborted",
|
|
client_closed: "client closed the connection",
|
|
no_terminal: "stream closed without a terminal event",
|
|
parse_fail: "failed to parse upstream stream",
|
|
empty_choices: "response had no usable choices/output",
|
|
empty_stream: "upstream stream carried no content",
|
|
content_is_upstream_error: "upstream reported a failure disguised as a successful response",
|
|
};
|
|
|
|
function describeReason(reason?: MalformedReason): string {
|
|
if (!reason) return "empty response";
|
|
return REASON_MESSAGES[reason] ?? reason;
|
|
}
|
|
|
|
// ── Exports ──────────────────────────────────────────────────────────────────
|
|
|
|
/**
|
|
* Log one structured [MALFORMED-200] line to stdout.
|
|
* Noop-safe (any field is optional). Used by streaming + non-streaming
|
|
* handlers to emit a single, grep-correlatable diagnostic entry.
|
|
*/
|
|
export function reportMalformed200(opts: ReportMalformed200Opts): void {
|
|
const {
|
|
mode,
|
|
provider,
|
|
model,
|
|
connectionId,
|
|
reason,
|
|
recvBytes,
|
|
recvLines,
|
|
emitted,
|
|
events,
|
|
ttftMs,
|
|
elapsedMs,
|
|
} = opts;
|
|
const evtStr =
|
|
events && typeof events === "object"
|
|
? `[${Object.entries(events)
|
|
.map(([k, v]) => `${k}=${v}`)
|
|
.join(",")}]`
|
|
: "[]";
|
|
console.log(
|
|
`[MALFORMED-200] mode=${mode || "?"} provider=${provider || "?"} model=${model || "?"} ` +
|
|
`conn=${connectionId || "-"} reason=${reason || "empty"} recvBytes=${recvBytes ?? -1} ` +
|
|
`recvLines=${recvLines ?? -1} emitted=${emitted ?? -1} events=${evtStr} ` +
|
|
`ttft=${ttftMs ?? -1}ms dur=${elapsedMs ?? -1}ms`
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Synthesize an OpenAI chat.completion.chunk SSE line for an empty stream.
|
|
* Caller enqueues this before the terminal `data: [DONE]`.
|
|
*
|
|
* All user-visible strings are sanitized through sanitizeErrorMessage
|
|
* (Hard Rule #12) to prevent stack-trace exposure.
|
|
*/
|
|
export function synthOpenAIErrorChunk(opts: {
|
|
provider?: string | null;
|
|
model?: string | null;
|
|
reason?: MalformedReason;
|
|
}): string {
|
|
const { provider, model, reason } = opts;
|
|
const reasonText = sanitizeErrorMessage(describeReason(reason));
|
|
const providerPart = sanitizeErrorMessage(provider ?? "?");
|
|
const safeMessage = sanitizeErrorMessage(
|
|
`[${providerPart}] returned an empty response (${reasonText}). ` +
|
|
"Likely quota exhaustion, an overloaded upstream, or a proxy/gateway intercepting the stream."
|
|
);
|
|
const body = {
|
|
id: `chatcmpl-empty-${Date.now()}`,
|
|
object: "chat.completion.chunk",
|
|
created: Math.floor(Date.now() / 1000),
|
|
model: sanitizeErrorMessage(model ?? "unknown"),
|
|
choices: [{ index: 0, delta: {}, finish_reason: "stop" }],
|
|
error: {
|
|
message: safeMessage,
|
|
type: "upstream_empty_response",
|
|
code: "upstream_empty_response",
|
|
},
|
|
};
|
|
return `data: ${JSON.stringify(body)}\n\n`;
|
|
}
|
|
|
|
/**
|
|
* Synthesize a response.failed SSE event for an empty/aborted Responses API
|
|
* passthrough stream.
|
|
*
|
|
* Message is sanitized through sanitizeErrorMessage (Hard Rule #12).
|
|
*/
|
|
export function synthResponsesFailure(reason?: MalformedReason): string {
|
|
const safeMessage = sanitizeErrorMessage(
|
|
`stream closed before response.completed (${describeReason(reason)})`
|
|
);
|
|
const event = {
|
|
type: "response.failed",
|
|
response: {
|
|
id: null,
|
|
status: "failed",
|
|
error: {
|
|
type: "stream_error",
|
|
code: "stream_disconnected",
|
|
message: safeMessage,
|
|
},
|
|
},
|
|
};
|
|
return `event: response.failed\ndata: ${JSON.stringify(event)}\n\n`;
|
|
}
|
|
|
|
/**
|
|
* Decide whether a *translated* non-streaming body is malformed for the client.
|
|
*
|
|
* Returns a reason string ("empty_choices" | "no_terminal") when the body is
|
|
* malformed, or null when it carries usable output.
|
|
*
|
|
* This runs *after* response translation so it catches cases the raw-body
|
|
* checks above miss (e.g. a provider returning a valid non-empty raw body that
|
|
* translates into an OpenAI `choices:[]` with no content).
|
|
*
|
|
* Design notes:
|
|
* - Reasoning-only responses (content="" + reasoning_content) are intentionally
|
|
* allowed — they are valid completions, not errors.
|
|
* - Tool-call responses (content=null + tool_calls=[…]) are also valid.
|
|
* - Responses API function_call / other structural items count as output even
|
|
* when they carry no user-visible text.
|
|
* - Claude Messages shape (type:"message" + content[]) is checked directly,
|
|
* since a Claude client receives the body in that shape (no
|
|
* `choices`/`object:"response"`).
|
|
* - #13461: for the narrow provider allowlist in classifyFakeSuccessBody
|
|
* (open-sse/services/errorClassifier.ts), a short Chat Completions
|
|
* assistant message that is dominated by a known credits-exhausted /
|
|
* account-deactivated phrase is treated as malformed too ("fake success")
|
|
* even though it carries non-empty content — see that function's doc
|
|
* comment for the false-positive guards. `provider` is optional and comes
|
|
* from the single call site in chatCore.ts; every other caller/shape is
|
|
* unaffected.
|
|
*/
|
|
export function detectMalformedNonStream(
|
|
resp: unknown,
|
|
provider?: string | null
|
|
): MalformedReason | null {
|
|
if (!resp || typeof resp !== "object") return "empty_choices";
|
|
|
|
const body = resp as Record<string, unknown>;
|
|
|
|
// ── Responses API shape ──
|
|
if (body.object === "response") {
|
|
const output = body.output;
|
|
const hasOutput =
|
|
Array.isArray(output) &&
|
|
output.some((item) => {
|
|
if (!item || typeof item !== "object") return false;
|
|
const it = item as Record<string, unknown>;
|
|
if (it.type === "message") {
|
|
return (
|
|
Array.isArray(it.content) &&
|
|
(it.content as unknown[]).some((c) => {
|
|
const part = c as Record<string, unknown>;
|
|
return typeof part?.text === "string" && (part.text as string).length > 0;
|
|
})
|
|
);
|
|
}
|
|
// function_call / other structural items count
|
|
return Boolean(it.type);
|
|
});
|
|
if (!hasOutput) return "empty_choices";
|
|
const status = typeof body.status === "string" ? body.status : "";
|
|
if (status && !["completed", "done"].includes(status)) return "no_terminal";
|
|
return null;
|
|
}
|
|
|
|
// ── Claude / Anthropic Messages shape ──
|
|
// A `/v1/messages` request to a Claude provider keeps the response in Claude shape
|
|
// (no translation when client and provider formats both = Claude), so it reaches here
|
|
// as `{ type:"message", content:[…] }` — which has neither `object:"response"` nor
|
|
// `choices`. Without this branch every non-streaming Claude response (incl. plain text)
|
|
// falls through to `empty_choices` → a false 502 (#5108, regression from #4942).
|
|
if (body.type === "message" && Array.isArray(body.content)) {
|
|
const content = body.content as unknown[];
|
|
const hasOutput = content.some((block) => {
|
|
// A malformed/partial provider response could carry a null (or non-object)
|
|
// entry in `content`; guard before type-asserting so the detector never
|
|
// throws on `null.type` (that would crash the whole non-stream classifier).
|
|
if (block === null || typeof block !== "object") return false;
|
|
const b = block as Record<string, unknown>;
|
|
// Text block with visible text. `convertOpenAINonStreamingToClaude` emits
|
|
// "(empty response)" as a placeholder when the upstream produced no content,
|
|
// so treat that sentinel as empty — a genuinely empty completion still trips
|
|
// the guard (parity with the OpenAI `content:""` path).
|
|
if (
|
|
b.type === "text" &&
|
|
typeof b.text === "string" &&
|
|
(b.text as string).length > 0 &&
|
|
b.text !== "(empty response)"
|
|
) {
|
|
return true;
|
|
}
|
|
// Extended-thinking block: valid structural output whenever the model
|
|
// entered the thinking phase, even with no visible thinking text and no
|
|
// `signature`. #9971: the Claude Code OAuth upstream can truncate long
|
|
// large-input+large-output generations around the ~3-min turn boundary,
|
|
// leaving a content-less thinking-only body whose final text (and, when
|
|
// cut mid-think, its signature) never arrived. The block's very presence
|
|
// is proof the turn produced output upstream, so it is a valid
|
|
// in-progress completion, NOT a genuinely empty terminal response.
|
|
// (Previously only a non-empty `thinking` text OR `signature` counted —
|
|
// #5108 — which misclassified these content-less bodies as empty_choices
|
|
// → 502.)
|
|
if (b.type === "thinking") return true;
|
|
// Redacted thinking and tool_use are valid structural output.
|
|
if (b.type === "redacted_thinking") return true;
|
|
if (b.type === "tool_use" && typeof b.id === "string" && (b.id as string).length > 0) {
|
|
return true;
|
|
}
|
|
return false;
|
|
});
|
|
if (hasOutput) return null;
|
|
|
|
// No per-block output. Two distinct situations remain:
|
|
// 1) A block IS present but invalid (e.g. text:"", a lone "(empty response)"
|
|
// sentinel, or only null entries) — the model genuinely produced no
|
|
// usable output. That is a MALFORMED-200 empty_choices regardless of
|
|
// stop_reason (parity with the OpenAI content:"" path) — UNLESS the
|
|
// terminal stop_reason is one of the legitimate truncated-completion
|
|
// exemptions below (#12968).
|
|
// 2) `content: []` — no block at all. #9971: a truncated / non-terminal
|
|
// body (no stop_reason) must not become empty_choices. A terminal
|
|
// stop_reason with no output usually is empty_choices — except the
|
|
// same legitimate empty stops that `isEmptyContentResponse` already
|
|
// accepts (`max_tokens`, `tool_use`). Claude Code's `/model` probe
|
|
// sends `max_tokens: 1`; Opus can burn that budget on thinking and
|
|
// return content:[] + stop_reason max_tokens. Treating that as
|
|
// empty_choices turns a valid 200 into MALFORMED-200 → 502 even
|
|
// though errorClassifier would have let it through.
|
|
const stopReason = typeof body.stop_reason === "string" ? body.stop_reason : "";
|
|
// #12968: the #9971 exemption above only fired when `content` was a
|
|
// completely empty array. A tiny `max_tokens` probe against an
|
|
// Anthropic-compatible shim can instead return content:[{type:"text",
|
|
// text:""}] — one block, just with no visible text — which is the exact
|
|
// same legitimate truncated-completion shape, so the exemption must apply
|
|
// whenever there is no visible output, not only when content is [].
|
|
if (stopReason === "max_tokens" || stopReason === "tool_use") return null;
|
|
// content:[] with no stop_reason at all is non-terminal, not empty (#9971).
|
|
if (content.length === 0 && stopReason.length === 0) return null;
|
|
return "empty_choices";
|
|
}
|
|
|
|
// ── Chat Completions shape ──
|
|
const choices = body.choices;
|
|
if (!Array.isArray(choices) || choices.length === 0) return "empty_choices";
|
|
|
|
const anyHasOutput = choices.some((choice) => {
|
|
const c = choice as Record<string, unknown>;
|
|
const msg = c?.message as Record<string, unknown> | undefined;
|
|
if (typeof msg?.content === "string" && (msg.content as string).length > 0) return true;
|
|
// #5559: some OpenAI-compatible upstreams (e.g. Cline via OAuth) return
|
|
// `message.content` as an array of Anthropic-style content blocks rather than
|
|
// a plain string. An array with at least one non-empty text block is real
|
|
// output — without this it was falsely flagged as empty_choices → 502 + cooldown.
|
|
if (
|
|
Array.isArray(msg?.content) &&
|
|
(msg.content as unknown[]).some((block) => {
|
|
const b = block as Record<string, unknown> | null;
|
|
return (
|
|
!!b &&
|
|
typeof b === "object" &&
|
|
b.type === "text" &&
|
|
typeof b.text === "string" &&
|
|
(b.text as string).length > 0
|
|
);
|
|
})
|
|
)
|
|
return true;
|
|
if (Array.isArray(msg?.tool_calls) && (msg.tool_calls as unknown[]).length > 0) return true;
|
|
// Reasoning-only completions are real output: a reasoning model that
|
|
// exhausts max_tokens on chain-of-thought returns `content: null` with the
|
|
// analysis in a reasoning field. Some OpenAI-compatible upstreams (e.g.
|
|
// opencode/mimo-v2.5-free via the OpenCode gateway) name it `reasoning`
|
|
// rather than `reasoning_content` — missing either variant falsely flagged
|
|
// these as empty_choices → 502 (#6623).
|
|
if (typeof msg?.reasoning_content === "string" && (msg.reasoning_content as string).length > 0)
|
|
return true;
|
|
if (typeof msg?.reasoning === "string" && (msg.reasoning as string).length > 0) return true;
|
|
return false;
|
|
});
|
|
|
|
if (!anyHasOutput) return "empty_choices";
|
|
|
|
// #13461: only for the narrow provider allowlist — see classifyFakeSuccessBody's
|
|
// doc comment for the false-positive guards (short content + dominant signal).
|
|
if (provider && classifyFakeSuccessBody(extractChatCompletionText(choices), provider)) {
|
|
return "content_is_upstream_error";
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
// Joins every non-empty text-bearing field across all choices of a Chat
|
|
// Completions body into one string, for the #13461 fake-success check above.
|
|
// Mirrors the shapes `anyHasOutput` already recognizes as "real" content
|
|
// (plain string, Anthropic-style content-block array) — reasoning/tool_calls
|
|
// are intentionally excluded, since a disguised upstream error always
|
|
// surfaces as visible assistant text, never as a reasoning trace.
|
|
function extractChatCompletionText(choices: unknown[]): string {
|
|
const parts: string[] = [];
|
|
for (const choice of choices) {
|
|
const c = choice as Record<string, unknown>;
|
|
const msg = c?.message as Record<string, unknown> | undefined;
|
|
if (typeof msg?.content === "string") {
|
|
parts.push(msg.content as string);
|
|
} else if (Array.isArray(msg?.content)) {
|
|
for (const block of msg.content as unknown[]) {
|
|
const b = block as Record<string, unknown> | null;
|
|
if (b && typeof b === "object" && b.type === "text" && typeof b.text === "string") {
|
|
parts.push(b.text as string);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return parts.join(" ");
|
|
}
|
|
|
|
export function describeMalformedNonStream(
|
|
resp: unknown,
|
|
reason: MalformedReason
|
|
): { message: string; code: string; type: string } {
|
|
const body = resp && typeof resp === "object" ? (resp as Record<string, unknown>) : null;
|
|
if (body?.object === "response" && body.status === "failed") {
|
|
const err =
|
|
body.error && typeof body.error === "object" ? (body.error as Record<string, unknown>) : null;
|
|
const rawMessage =
|
|
typeof err?.message === "string" && err.message.trim().length > 0 ? err.message.trim() : null;
|
|
return {
|
|
// Trim only here; buildErrorBody (chatCore) does the single sanitization pass.
|
|
message: rawMessage
|
|
? `upstream reported a failed response: ${rawMessage}`
|
|
: "upstream reported a failed response without usable output",
|
|
code: "upstream_response_failed",
|
|
type: "upstream_response_error",
|
|
};
|
|
}
|
|
if (reason === "content_is_upstream_error") {
|
|
return {
|
|
message: "upstream reported a failure disguised as a successful response",
|
|
code: "upstream_fake_success",
|
|
type: "upstream_response_error",
|
|
};
|
|
}
|
|
return {
|
|
message:
|
|
reason === "no_terminal"
|
|
? "upstream response did not reach a terminal state"
|
|
: "upstream returned an empty response without usable output",
|
|
code: "upstream_empty_response",
|
|
type: "upstream_response_error",
|
|
};
|
|
}
|
|
|
|
// ── Test-only export ─────────────────────────────────────────────────────────
|
|
export const __test = { describeReason };
|