Files
OmniRoute/tests/unit/chatcore-executor-client-headers.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

53 lines
2.3 KiB
TypeScript

// tests/unit/chatcore-executor-client-headers.test.ts
// Characterization of buildExecutorClientHeaders — the executor client-header normalizer extracted
// from handleChatCore (chatCore god-file decomposition, #3501). Locks: Headers and plain-object
// normalization, non-string value skipping, User-Agent backfill (both casings, only when absent),
// and the null-when-empty return.
import { test } from "node:test";
import assert from "node:assert/strict";
import { buildExecutorClientHeaders } from "../../open-sse/handlers/chatCore/executorClientHeaders.ts";
test("returns null for empty / nullish inputs", () => {
assert.equal(buildExecutorClientHeaders(null), null);
assert.equal(buildExecutorClientHeaders(undefined), null);
assert.equal(buildExecutorClientHeaders({}), null);
});
test("normalizes a Headers instance", () => {
const h = new Headers({ "X-Test": "1", "content-type": "application/json" });
const out = buildExecutorClientHeaders(h);
assert.equal(out?.["content-type"], "application/json");
assert.equal(out?.["x-test"], "1");
});
test("normalizes a plain object and skips non-string values", () => {
const out = buildExecutorClientHeaders({ a: "1", b: 2, c: null } as Record<string, unknown>);
assert.deepEqual(out, { a: "1" });
});
test("backfills the User-Agent in both casings when absent", () => {
const out = buildExecutorClientHeaders({ a: "1" }, " MyAgent/1.0 ");
assert.equal(out?.["user-agent"], "MyAgent/1.0");
assert.equal(out?.["User-Agent"], "MyAgent/1.0");
});
test("does not overwrite an existing user-agent header", () => {
const out = buildExecutorClientHeaders({ "user-agent": "Existing/9" }, "MyAgent/1.0");
assert.equal(out?.["user-agent"], "Existing/9");
assert.equal(out?.["User-Agent"], undefined);
});
test("a trimmed-empty user agent does not create headers on its own", () => {
assert.equal(buildExecutorClientHeaders({}, " "), null);
});
test("internal hard-lease control headers never reach an executor", () => {
const out = buildExecutorClientHeaders({
"X-OmniRoute-Lease-Owner": `vlo_${"A".repeat(43)}`,
"x-omniroute-lease-generation": "7",
"x-session-id": "routing-session-remains-independent",
});
assert.deepEqual(out, { "x-session-id": "routing-session-remains-independent" });
});