Files
OmniRoute/tests/unit/combo-empty-models.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

60 lines
2.2 KiB
TypeScript

import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import assert from "node:assert/strict";
import test from "node:test";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-combo-empty-models-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const { createComboSchema, updateComboSchema } =
await import("../../src/shared/validation/schemas/combo.ts");
const { getCopilotTool } = await import("../../src/lib/copilot/tools.ts");
const combosDb = await import("../../src/lib/db/combos.ts");
const core = await import("../../src/lib/db/core.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
});
test("an update cannot remove every model from a combo", () => {
assert.equal(updateComboSchema.safeParse({ models: [] }).success, false);
assert.equal(updateComboSchema.safeParse({ models: ["openai/gpt-4o-mini"] }).success, true);
assert.equal(updateComboSchema.safeParse({ name: "renamed" }).success, true);
});
test("creating a combo without a model is refused at the boundary", () => {
assert.equal(createComboSchema.safeParse({ name: "drafted", models: [] }).success, false);
assert.equal(createComboSchema.safeParse({ name: "drafted" }).success, false);
});
test("the copilot createCombo tool stores targets where the router looks for them", async () => {
const tool = getCopilotTool("createCombo");
assert.ok(tool);
await tool.handler({
name: "copilot-stored",
strategy: "priority",
targets: JSON.stringify([{ provider: "openai", model: "gpt-4o-mini", weight: 100 }]),
});
const stored = (await combosDb.getComboByName("copilot-stored")) as { models?: unknown[] } | null;
assert.ok(stored, "the combo should exist");
assert.equal(stored.models?.length, 1);
});
test("the copilot combo list counts the targets the router will use", async () => {
const list = getCopilotTool("listCombos");
assert.ok(list);
await combosDb.createCombo({
name: "dashboard-made",
strategy: "priority",
models: ["openai/gpt-4o-mini", "openai/gpt-4o"],
});
const output = await list.handler({});
assert.match(output, /\*\*dashboard-made\*\* — strategy: `priority` — 2 target\(s\)/);
});