Files
OmniRoute/tests/unit/db-settings-split.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

92 lines
2.7 KiB
TypeScript

/**
* Characterization test: settings.ts god-file decomposition.
* Verifies that:
* 1. toRecord in shared.ts has correct behavior (DB-free, pure function).
* 2. The host settings.ts still re-exports the full public API surface.
*/
import { describe, it } from "node:test";
import assert from "node:assert/strict";
// ── 1. shared.ts — toRecord ──────────────────────────────────────────────────
import { toRecord } from "../../src/lib/db/settings/shared.ts";
describe("toRecord", () => {
it("returns the object as-is when given a plain object", () => {
const obj = { a: 1, b: "two" };
assert.deepStrictEqual(toRecord(obj), obj);
});
it("returns {} for null", () => {
assert.deepStrictEqual(toRecord(null), {});
});
it("returns {} for undefined", () => {
assert.deepStrictEqual(toRecord(undefined), {});
});
it("returns {} for a string", () => {
assert.deepStrictEqual(toRecord("hello"), {});
});
it("returns {} for a number", () => {
assert.deepStrictEqual(toRecord(42), {});
});
it("returns {} for an array (arrays are objects but toRecord returns the array cast)", () => {
// toRecord casts arrays as JsonRecord — they ARE objects, so the cast succeeds.
const arr = [1, 2, 3];
assert.strictEqual(toRecord(arr), arr);
});
});
// ── 2. settings.ts — public API surface ─────────────────────────────────────
const settingsModule = await import("../../src/lib/db/settings.ts");
describe("settings.ts public API surface", () => {
const expectedFunctions = [
// Settings core
"getSettings",
"updateSettings",
"isCloudEnabled",
// Proxy helpers (exported)
"bumpProxyConfigGeneration",
// Proxy config
"getProxyConfig",
"getProxyForLevel",
"setProxyForLevel",
"deleteProxyForLevel",
"resolveProxyForConnection",
"setProxyConfig",
// Pricing (re-exported from ./settings/pricing)
"getPricing",
"getPricingWithSources",
"getPricingForModel",
"updatePricing",
"resetPricing",
"resetAllPricing",
// LKGP (re-exported from ./settings/lkgp)
"getLKGP",
"setLKGP",
"clearAllLKGP",
"clearLKGP",
// Cache metrics (re-exported from ./settings/cacheMetrics)
"getCacheMetrics",
"updateCacheMetrics",
"getCacheTrend",
"resetCacheMetrics",
] as const;
for (const name of expectedFunctions) {
it(`exports "${name}" as a function`, () => {
assert.strictEqual(
typeof (settingsModule as Record<string, unknown>)[name],
"function",
`Expected "${name}" to be exported as a function`
);
});
}
});