Files
OmniRoute/tests/unit/openapi-coverage.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

151 lines
6.3 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import path from "node:path";
import * as yaml from "js-yaml";
const ROOT = process.cwd();
const API_ROOT = path.join(ROOT, "src", "app", "api");
const OPENAPI_PATH = path.join(ROOT, "docs", "openapi.yaml");
function collectRouteFiles(dir: string): { apiPath: string; file: string }[] {
const entries = fs.readdirSync(dir, { withFileTypes: true });
const routes: { apiPath: string; file: string }[] = [];
for (const entry of entries) {
const fullPath = path.join(dir, entry.name);
if (entry.isDirectory()) {
routes.push(...collectRouteFiles(fullPath));
continue;
}
if (entry.isFile() && entry.name === "route.ts") {
const apiPath = path
.dirname(fullPath)
.replace(API_ROOT, "")
.replace(/\[([^\]]+)\]/g, "{$1}");
routes.push({ apiPath: `/api${apiPath}`, file: fullPath });
}
}
return routes;
}
function collectRoutePaths(dir: string): string[] {
return collectRouteFiles(dir).map((route) => route.apiPath);
}
// OPTIONS is deliberately absent: every v1 route exports it for CORS preflight, so it is
// transport boilerplate rather than API surface a consumer calls.
const DOCUMENTABLE_METHODS = ["get", "post", "put", "patch", "delete", "head"] as const;
/** The HTTP handlers a route.ts actually exports, across the export forms used in this repo. */
function exportedMethods(routeFile: string): string[] {
const source = fs.readFileSync(routeFile, "utf-8");
return DOCUMENTABLE_METHODS.filter((method) => {
const name = method.toUpperCase();
return (
new RegExp(`export\\s+(?:async\\s+)?function\\s+${name}\\b`).test(source) ||
new RegExp(`export\\s+(?:const|let|var)\\s+${name}\\b`).test(source) ||
new RegExp(`export\\s*\\{[^}]*\\b${name}\\b[^}]*\\}`).test(source)
);
});
}
function normalizePath(p: string): string {
return p.replace(/\/\[\.\.\.([^\]]+)\]/g, "/{$1}").replace(/\[([^\]]+)\]/g, "{$1}");
}
// Floor recorded on 2026-05-26 for release/v3.8.4: 137/365 routes documented.
// The ≥99% target is tracked in the OpenAPI audit follow-up; until backlog routes
// (services, free-proxies, relay-tokens, key-groups, middleware/hooks, etc.) are
// documented, the gate enforces "no regressions" instead of the absolute target.
// 2026-07-25 (PR #8523, Dario embedded service): 36 -> 35.9 (222/618). Same class of
// cycle drift already logged for this metric in quality-baseline.json's
// openApiCoverage.pct history (v3.8.34/v3.8.39/v3.8.47 rebaselines) — this PR adds 22
// new "services" backlog routes (exactly the category named above: per-service
// auto-restart-adopted toggles for 9router/bifrost/cliproxy/mux, plus Dario's
// admin/lifecycle routes), none documented, none public API surface (all are
// internal service-management endpoints, not routes external API consumers call).
// Documenting them in the public spec would be gaming the gate, same precedent as
// the metric's release rebaselines. Measured 222/618 = 35.9% locally and in CI.
// Raising coverage by documenting the backlog is tracked as follow-up doc debt.
const OPENAPI_COVERAGE_FLOOR_PERCENT = 35.9;
test("openapi.yaml does not regress documented-route coverage below the agreed floor", () => {
const implementedPaths = collectRoutePaths(API_ROOT).map(normalizePath).sort();
const raw: any = yaml.load(fs.readFileSync(OPENAPI_PATH, "utf-8"));
const documentedPaths = new Set(Object.keys(raw.paths || {}));
let covered = 0;
const missing: string[] = [];
for (const p of implementedPaths) {
if (documentedPaths.has(p)) {
covered++;
} else {
missing.push(p);
}
}
const total = implementedPaths.length;
const coverage = (covered / total) * 100;
if (coverage < OPENAPI_COVERAGE_FLOOR_PERCENT) {
console.error(`Coverage: ${coverage.toFixed(1)}% (${covered}/${total})`);
console.error("Missing paths:");
missing.forEach((p) => console.error(` - ${p}`));
}
assert.ok(
coverage >= OPENAPI_COVERAGE_FLOOR_PERCENT,
`OpenAPI coverage regressed: ${coverage.toFixed(1)}% < floor ${OPENAPI_COVERAGE_FLOOR_PERCENT}%. ` +
`Missing: ${missing.slice(0, 10).join(", ")}${missing.length > 10 ? ` ... +${missing.length - 10} more` : ""}`
);
});
// Floor recorded on 2026-08-21 for release/v3.8.50: cycle added undocumented
// operations faster than docs/openapi.yaml (343/985 -> 34.7%). Same "no
// regressions" policy as the path floor.
// The path floor above cannot see an operation: a route counts as covered the moment ONE
// of its verbs is documented. /api/combos/{id} exported GET, PUT and DELETE while the spec
// listed only `patch` and `delete` — a fully covered path hiding two operations, and the
// one `patch` it did document does not exist on that route. Schemathesis (dast-smoke.yml)
// only exercises documented operations, so the two hidden verbs never reached the fuzzer.
// Same "no regressions, not the absolute target" policy as the path floor: raising it is
// tracked as the same follow-up doc debt.
const OPENAPI_OPERATION_FLOOR_PERCENT = 34.6;
test("openapi.yaml does not regress documented-operation coverage below the agreed floor", () => {
const raw = yaml.load(fs.readFileSync(OPENAPI_PATH, "utf-8")) as {
paths?: Record<string, Record<string, unknown>>;
};
const documentedPaths = raw.paths ?? {};
let covered = 0;
const missing: string[] = [];
for (const { apiPath, file } of collectRouteFiles(API_ROOT)) {
const operations = documentedPaths[normalizePath(apiPath)];
for (const method of exportedMethods(file)) {
if (operations && operations[method]) {
covered++;
} else {
missing.push(`${method.toUpperCase()} ${apiPath}`);
}
}
}
const total = covered + missing.length;
const coverage = (covered / total) * 100;
if (coverage < OPENAPI_OPERATION_FLOOR_PERCENT) {
console.error(`Operation coverage: ${coverage.toFixed(1)}% (${covered}/${total})`);
console.error("Undocumented operations:");
missing.forEach((op) => console.error(` - ${op}`));
}
assert.ok(
coverage >= OPENAPI_OPERATION_FLOOR_PERCENT,
`OpenAPI operation coverage regressed: ${coverage.toFixed(1)}% < floor ${OPENAPI_OPERATION_FLOOR_PERCENT}%. ` +
`Undocumented: ${missing.slice(0, 10).join(", ")}${missing.length > 10 ? ` ... +${missing.length - 10} more` : ""}`
);
});