mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-26 09:02:11 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
45 lines
2.1 KiB
TypeScript
45 lines
2.1 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import test from "node:test";
|
|
|
|
import {
|
|
OpencodeExecutor,
|
|
resolveOpencodeTargetFormat,
|
|
} from "../../open-sse/executors/opencode.ts";
|
|
|
|
// oc/muse-spark-1.2-contributor-free returns HTTP 400 with an empty assistant
|
|
// message right after `targetFormat:"openai-responses"` was added to its registry
|
|
// entry (#10874). Root cause: `PROVIDER_MODELS` is keyed by the provider's public
|
|
// ALIAS ("oc"), not its raw registry id ("opencode") — resolving the target format
|
|
// with the raw id missed the registry entry entirely, so `buildUrl()` kept picking
|
|
// `/chat/completions` while chatCore's own (correctly aliased) request translation
|
|
// had already switched the request BODY to the Responses API shape (`input:[...]`).
|
|
// Upstream received a Responses-shaped body at the Chat Completions endpoint and
|
|
// returned a degenerate empty response.
|
|
|
|
test("resolveOpencodeTargetFormat resolves the registry entry via the provider alias, not the raw id", () => {
|
|
assert.equal(
|
|
resolveOpencodeTargetFormat("opencode", "muse-spark-1.2-contributor-free"),
|
|
"openai-responses"
|
|
);
|
|
assert.equal(resolveOpencodeTargetFormat("opencode", "muse-spark-1.2"), "openai-responses");
|
|
});
|
|
|
|
test("resolveOpencodeTargetFormat falls back to 'openai' for a model with no registry targetFormat", () => {
|
|
assert.equal(resolveOpencodeTargetFormat("opencode", "hy3-free"), "openai");
|
|
});
|
|
|
|
test("resolveOpencodeTargetFormat falls back to 'openai' for an unknown provider (no alias, no direct match)", () => {
|
|
assert.equal(resolveOpencodeTargetFormat("not-a-real-provider", "muse-spark-1.2"), "openai");
|
|
});
|
|
|
|
test("OpencodeExecutor.buildUrl uses /responses once _requestFormat is resolved through the alias (live-bug repro)", () => {
|
|
const executor = new OpencodeExecutor("opencode");
|
|
// Mirrors the first line of execute() — see #11045.
|
|
(executor as unknown as { _requestFormat: string })._requestFormat = resolveOpencodeTargetFormat(
|
|
"opencode",
|
|
"muse-spark-1.2-contributor-free"
|
|
);
|
|
const url = executor.buildUrl("muse-spark-1.2-contributor-free", true);
|
|
assert.ok(url.endsWith("/responses"), `expected URL to end with /responses, got: ${url}`);
|
|
});
|