Files
OmniRoute/tests/unit/radar-sync-request.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

70 lines
2.3 KiB
TypeScript

import assert from "node:assert/strict";
import test from "node:test";
import {
RADAR_SYNC_BODY_LIMIT_BYTES,
validateRadarSyncBody,
} from "../../src/app/api/radar/syncRequest.ts";
function request(body?: string): Request {
return new Request("http://localhost:20128/api/radar/sync-all", {
method: "POST",
...(body === undefined ? {} : { body }),
});
}
test("Radar sync body accepts only absent/empty or exactly an empty JSON object", async () => {
for (const body of [undefined, "", " ", "{}"] as const) {
assert.equal(await validateRadarSyncBody(request(body)), "valid", `expected valid: ${body}`);
}
for (const body of ['{"unexpected":true}', "null", "[]", '"value"', "{malformed"] as const) {
assert.equal(
await validateRadarSyncBody(request(body)),
"invalid",
`expected invalid: ${body}`
);
}
});
test("Radar sync body stops a chunked stream at the fixed byte limit", async () => {
let pulls = 0;
const chunk = new TextEncoder().encode(" ".repeat(512));
const body = new ReadableStream<Uint8Array>({
pull(controller) {
pulls += 1;
controller.enqueue(chunk);
if (pulls >= 12) controller.close();
},
});
const streamed = new Request("http://localhost:20128/api/radar/sync-all", {
method: "POST",
body,
duplex: "half",
} as RequestInit & { duplex: "half" });
assert.equal(await validateRadarSyncBody(streamed), "too_large");
assert.equal(RADAR_SYNC_BODY_LIMIT_BYTES, 1024);
assert.ok(pulls < 12, "the validator must cancel before buffering the entire stream");
});
test("Radar sync body turns transport and UTF-8 failures into a closed sanitized state", async () => {
const failedStream = new ReadableStream<Uint8Array>({
start(controller) {
controller.error(new Error("transport-secret"));
},
});
const failedRequest = new Request("http://localhost:20128/api/radar/sync-all", {
method: "POST",
body: failedStream,
duplex: "half",
} as RequestInit & { duplex: "half" });
const invalidUtf8 = new Request("http://localhost:20128/api/radar/sync-all", {
method: "POST",
body: new Uint8Array([0xff]),
});
assert.equal(await validateRadarSyncBody(failedRequest), "read_error");
assert.equal(await validateRadarSyncBody(invalidUtf8), "read_error");
});