Files
OmniRoute/tests/unit/visionBridgeDefaults.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

108 lines
3.9 KiB
TypeScript

/**
* Tests for Vision Bridge default constants.
*/
import test from "node:test";
import assert from "node:assert/strict";
import {
VISION_BRIDGE_DEFAULTS,
VISION_BRIDGE_SETTINGS_KEYS,
getVisionBridgeConfig,
isVisionBridgeForcedModel,
type VisionBridgeSettings,
} from "@/shared/constants/visionBridgeDefaults";
test("VISION_BRIDGE_DEFAULTS exports correct values", () => {
assert.strictEqual(VISION_BRIDGE_DEFAULTS.enabled, true);
assert.strictEqual(VISION_BRIDGE_DEFAULTS.model, "openai/gpt-4o-mini");
assert.strictEqual(
VISION_BRIDGE_DEFAULTS.prompt,
"Describe this image concisely in 2-3 sentences. Focus on the most relevant visual details."
);
assert.strictEqual(VISION_BRIDGE_DEFAULTS.timeoutMs, 30000);
assert.strictEqual(VISION_BRIDGE_DEFAULTS.maxImagesPerRequest, 10);
});
test("VISION_BRIDGE_SETTINGS_KEYS exports all expected keys", () => {
assert.deepStrictEqual(VISION_BRIDGE_SETTINGS_KEYS, [
"visionBridgeEnabled",
"visionBridgeModel",
"visionBridgePrompt",
"visionBridgeTimeout",
"visionBridgeMaxImages",
"visionBridgeRerouteTextOnly",
]);
});
test("isVisionBridgeForcedModel does not blanket-force GPT-family models", () => {
assert.strictEqual(isVisionBridgeForcedModel("gpt-5.5"), false);
assert.strictEqual(isVisionBridgeForcedModel("codex/gpt-5.5"), false);
assert.strictEqual(isVisionBridgeForcedModel("openai/gpt-4o-mini"), false);
});
test("isVisionBridgeForcedModel forces tokenrouter deepseek models (text-only backend, #3946)", () => {
// These route through a Fireworks text-only backend that overstates vision
// support at the provider level, so they must be force-bridged or raw image
// data leaks to a backend that cannot process it.
assert.strictEqual(isVisionBridgeForcedModel("tokenrouter/deepseek-v4-pro"), true);
assert.strictEqual(isVisionBridgeForcedModel("tokenrouter/deepseek-v4-flash"), true);
});
test("getVisionBridgeConfig returns defaults when no settings provided", () => {
const config = getVisionBridgeConfig({});
assert.strictEqual(config.enabled, true);
assert.strictEqual(config.model, "openai/gpt-4o-mini");
assert.strictEqual(config.prompt, VISION_BRIDGE_DEFAULTS.prompt);
assert.strictEqual(config.timeoutMs, 30000);
assert.strictEqual(config.maxImages, 10);
});
test("getVisionBridgeConfig applies custom settings", () => {
const customSettings: VisionBridgeSettings = {
visionBridgeEnabled: false,
visionBridgeModel: "anthropic/claude-3-haiku",
visionBridgePrompt: "What is in this image?",
visionBridgeTimeout: 60000,
visionBridgeMaxImages: 5,
};
const config = getVisionBridgeConfig(customSettings);
assert.strictEqual(config.enabled, false);
assert.strictEqual(config.model, "anthropic/claude-3-haiku");
assert.strictEqual(config.prompt, "What is in this image?");
assert.strictEqual(config.timeoutMs, 60000);
assert.strictEqual(config.maxImages, 5);
});
test("getVisionBridgeConfig merges partial settings with defaults", () => {
const partialSettings: VisionBridgeSettings = {
visionBridgeModel: "openai/gpt-4o",
};
const config = getVisionBridgeConfig(partialSettings);
// Custom value
assert.strictEqual(config.model, "openai/gpt-4o");
// Default values for the rest
assert.strictEqual(config.enabled, true);
assert.strictEqual(config.prompt, VISION_BRIDGE_DEFAULTS.prompt);
assert.strictEqual(config.timeoutMs, 30000);
assert.strictEqual(config.maxImages, 10);
});
test("getVisionBridgeConfig handles undefined settings", () => {
const config = getVisionBridgeConfig(undefined);
assert.strictEqual(config.enabled, true);
assert.strictEqual(config.model, "openai/gpt-4o-mini");
});
test("getVisionBridgeConfig handles null settings", () => {
const config = getVisionBridgeConfig(null as unknown as VisionBridgeSettings);
assert.strictEqual(config.enabled, true);
assert.strictEqual(config.model, "openai/gpt-4o-mini");
});