mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-18 21:22:28 +03:00
* fix(cli): derive machine-id token under plain Node and honor salt rotation
`getCliToken()` destructured `machineIdSync` off `await import("node-machine-id")`.
That module is CommonJS, so under plain Node its exports land on `.default` and the
destructured binding is `undefined`. Calling it threw, the bare catch blanked the
token, and every management request went out with no `x-omniroute-cli-token` header
— silently unauthenticated, 401 on every `omniroute combo` / `usage budget` call.
Resolve the binding the same way `src/lib/machineToken.ts` already does, and read
`OMNIROUTE_CLI_SALT` so the rotation documented in docs/security/CLI_TOKEN.md
actually reaches CLI processes (the salt was hardcoded). The catch now logs instead
of failing mute, per the error-handling convention in CONTRIBUTING.md.
The existing test asserted `token === "" || token.length === 32`, so the blanked
token passed. Tightening it in-process is not enough either: the suite runs under
`tsx/esm`, which resolves CJS named exports and hides the bug. The regression test
therefore spawns plain `node` — the loader the CLI actually runs under.
Both new tests fail on the previous code and pass on this one.
* chore(changelog): use the real PR number for the fragment
153 lines
6.1 KiB
TypeScript
153 lines
6.1 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import crypto from "node:crypto";
|
|
import { execFileSync } from "node:child_process";
|
|
import { join } from "node:path";
|
|
import { fileURLToPath, pathToFileURL } from "node:url";
|
|
|
|
test("cliToken.mjs pode ser importado sem erro", async () => {
|
|
const mod = await import("../../bin/cli/utils/cliToken.mjs");
|
|
assert.equal(typeof mod.getCliToken, "function");
|
|
assert.equal(typeof mod.CLI_TOKEN_HEADER, "string");
|
|
assert.equal(mod.CLI_TOKEN_HEADER, "x-omniroute-cli-token");
|
|
});
|
|
|
|
test("getCliToken deriva token de 32 chars sob o node puro que a CLI usa", async () => {
|
|
const mod = await import("node-machine-id");
|
|
const machineIdSync = mod.machineIdSync ?? mod.default?.machineIdSync;
|
|
// Sem machine-id nesta plataforma não há token a derivar — nada a afirmar.
|
|
if (typeof machineIdSync !== "function") return;
|
|
|
|
// Precisa rodar em `node` puro, sem o loader tsx/esm: o tsx resolve os named
|
|
// exports de um CJS e mascara o bug de interop. `omniroute` roda sob node puro,
|
|
// onde `const { machineIdSync } = await import(...)` dava undefined, o catch
|
|
// zerava o token e TODA requisição de management saía sem autenticação.
|
|
const repoRoot = fileURLToPath(new URL("../..", import.meta.url));
|
|
const entry = pathToFileURL(join(repoRoot, "bin/cli/utils/cliToken.mjs")).href;
|
|
const out = execFileSync(
|
|
process.execPath,
|
|
[
|
|
"-e",
|
|
`import(${JSON.stringify(entry)}).then(m => m.getCliToken()).then(t => console.log(t.length))`,
|
|
],
|
|
{ cwd: repoRoot, encoding: "utf8" }
|
|
);
|
|
|
|
assert.equal(out.trim(), "32", `expected a derived 32-char token, got length ${out.trim()}`);
|
|
});
|
|
|
|
test("getCliToken retorna mesmo valor em chamadas repetidas (cache)", async () => {
|
|
const { getCliToken } = await import("../../bin/cli/utils/cliToken.mjs");
|
|
const t1 = await getCliToken();
|
|
const t2 = await getCliToken();
|
|
assert.equal(t1, t2);
|
|
});
|
|
|
|
test("getCliToken respeita rotação de OMNIROUTE_CLI_SALT", async () => {
|
|
const mod = await import("node-machine-id");
|
|
const machineIdSync = mod.machineIdSync ?? mod.default?.machineIdSync;
|
|
if (typeof machineIdSync !== "function") return;
|
|
|
|
const { getCliToken } = await import("../../bin/cli/utils/cliToken.mjs");
|
|
const original = process.env.OMNIROUTE_CLI_SALT;
|
|
try {
|
|
delete process.env.OMNIROUTE_CLI_SALT;
|
|
const withDefaultSalt = await getCliToken();
|
|
process.env.OMNIROUTE_CLI_SALT = "rotated-salt-for-test";
|
|
const withRotatedSalt = await getCliToken();
|
|
// docs/security/CLI_TOKEN.md promete que a rotação alcança os processos CLI;
|
|
// o SALT hardcoded ignorava a env var e devolvia sempre o mesmo token.
|
|
assert.notEqual(withRotatedSalt, withDefaultSalt);
|
|
assert.equal(withRotatedSalt.length, 32);
|
|
} finally {
|
|
if (original === undefined) delete process.env.OMNIROUTE_CLI_SALT;
|
|
else process.env.OMNIROUTE_CLI_SALT = original;
|
|
}
|
|
});
|
|
|
|
test("getCliToken produz apenas hex lowercase se não-vazio", async () => {
|
|
const { getCliToken } = await import("../../bin/cli/utils/cliToken.mjs");
|
|
const token = await getCliToken();
|
|
if (token.length > 0) {
|
|
assert.match(token, /^[0-9a-f]{32}$/);
|
|
}
|
|
});
|
|
|
|
test("OMNIROUTE_CLI_TOKEN env sobrescreve token gerado em apiFetch", async () => {
|
|
const orig = process.env.OMNIROUTE_CLI_TOKEN;
|
|
process.env.OMNIROUTE_CLI_TOKEN = "test-override-token-12345";
|
|
try {
|
|
// Re-import api.mjs não funciona por cache ESM — validamos apenas que env é lido.
|
|
assert.equal(process.env.OMNIROUTE_CLI_TOKEN, "test-override-token-12345");
|
|
} finally {
|
|
if (orig === undefined) delete process.env.OMNIROUTE_CLI_TOKEN;
|
|
else process.env.OMNIROUTE_CLI_TOKEN = orig;
|
|
}
|
|
});
|
|
|
|
// --- testes server-side: isLoopback ---
|
|
|
|
test("isLoopback aceita 127.0.0.1", async () => {
|
|
const { isLoopback } = await import("../../src/lib/middleware/cliTokenAuth");
|
|
assert.ok(isLoopback("127.0.0.1"));
|
|
});
|
|
|
|
test("isLoopback aceita ::1", async () => {
|
|
const { isLoopback } = await import("../../src/lib/middleware/cliTokenAuth");
|
|
assert.ok(isLoopback("::1"));
|
|
});
|
|
|
|
test("isLoopback aceita ::ffff:127.0.0.1 (IPv4-mapped)", async () => {
|
|
const { isLoopback } = await import("../../src/lib/middleware/cliTokenAuth");
|
|
assert.ok(isLoopback("::ffff:127.0.0.1"));
|
|
});
|
|
|
|
test("isLoopback rejeita IP público", async () => {
|
|
const { isLoopback } = await import("../../src/lib/middleware/cliTokenAuth");
|
|
assert.ok(!isLoopback("192.168.1.100"));
|
|
assert.ok(!isLoopback("10.0.0.1"));
|
|
assert.ok(!isLoopback("8.8.8.8"));
|
|
});
|
|
|
|
test("token derivado de machine-id diferente produz hash diferente", () => {
|
|
const SALT = "omniroute-cli-auth-v1";
|
|
const hash = (mid: string) =>
|
|
crypto
|
|
.createHash("sha256")
|
|
.update(mid + SALT)
|
|
.digest("hex")
|
|
.substring(0, 32);
|
|
const t1 = hash("machine-id-host-A");
|
|
const t2 = hash("machine-id-host-B");
|
|
assert.notEqual(t1, t2);
|
|
assert.match(t1, /^[0-9a-f]{32}$/);
|
|
assert.match(t2, /^[0-9a-f]{32}$/);
|
|
});
|
|
|
|
test("OMNIROUTE_DISABLE_CLI_TOKEN desabilita auth (estrutura verificada)", async () => {
|
|
const { readFileSync } = await import("node:fs");
|
|
const { join, dirname } = await import("node:path");
|
|
const { fileURLToPath } = await import("node:url");
|
|
const dir = dirname(fileURLToPath(import.meta.url));
|
|
const src = readFileSync(join(dir, "../../src/lib/middleware/cliTokenAuth.ts"), "utf8");
|
|
assert.ok(src.includes("OMNIROUTE_DISABLE_CLI_TOKEN"));
|
|
});
|
|
|
|
test("cliTokenAuth must NOT derive loopback from the spoofable Host header", async () => {
|
|
const { readFileSync } = await import("node:fs");
|
|
const { join, dirname } = await import("node:path");
|
|
const { fileURLToPath } = await import("node:url");
|
|
const dir = dirname(fileURLToPath(import.meta.url));
|
|
const src = readFileSync(join(dir, "../../src/lib/middleware/cliTokenAuth.ts"), "utf8");
|
|
// Regression guard: a remote caller with a stolen CLI token could send
|
|
// Host: 127.0.0.1 if locality came from new URL(request.url).hostname.
|
|
assert.ok(
|
|
!/isLoopback\(\s*new URL\(request\.url\)\.hostname/.test(src),
|
|
"must not call isLoopback(new URL(request.url).hostname)"
|
|
);
|
|
assert.ok(
|
|
src.includes("AUTHZ_HEADER_PEER_LOCALITY"),
|
|
"must trust the middleware-stamped locality verdict instead"
|
|
);
|
|
});
|