mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-17 20:52:15 +03:00
14afdcb923
* fix(routing): fallback to default model alias seeds when unmapped in database * fix(routing): rename seed-fallback resolver; hermetic 401 regression test Maintainer review (PR #10124): 1. Rename resolveModelAlias -> resolveModelAliasWithSeedFallback (and resolveModelAliasOnBody -> resolveModelAliasWithSeedFallbackOnBody) to avoid the export collision with the sync resolveModelAlias in open-sse/services/modelDeprecation.ts and src/shared/constants/modelSpecs.ts. 2. Regression test now reproduces the 401: alias unmapped in the (empty, DATA_DIR-isolated) modelAliases namespace but present in the static seed resolves to the seed target instead of passing through unmapped. 3. Test isolates DATA_DIR (temp dir + resetDbInstance) instead of reading the operator's live DB. * fix(models): add outputTokenLimit to CustomModelEntry Fixes the open-sse typecheck gate regression: catalog.ts reads model.outputTokenLimit (for max_output_tokens in custom model metadata) but CustomModelEntry only declared inputTokenLimit — TS2551. The field exists in the runtime model data and is already consumed; the interface just never declared it.
67 lines
3.1 KiB
TypeScript
67 lines
3.1 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { resolveModelAliasWithSeedFallback } from "../../src/lib/modelAliasResolver";
|
|
|
|
// Hermetic test: isolate DATA_DIR so the alias lookup reads an EMPTY
|
|
// modelAliases namespace (fresh install state) instead of the operator's live
|
|
// DB. This is the exact scenario the 401 fix targets — aliases unmapped in
|
|
// the DB must fall back to the static seed.
|
|
async function withEmptyAliasDb(fn: () => Promise<void>) {
|
|
const prevDataDir = process.env.DATA_DIR;
|
|
const prevKey = process.env.STORAGE_ENCRYPTION_KEY;
|
|
const dataDir = fs.mkdtempSync(path.join(os.tmpdir(), "alias-seed-fallback-"));
|
|
process.env.DATA_DIR = dataDir;
|
|
delete process.env.STORAGE_ENCRYPTION_KEY;
|
|
|
|
try {
|
|
// Reset the module-level DB singleton so it binds to the temp dir.
|
|
const { resetDbInstance } = await import("../../src/lib/db/core");
|
|
resetDbInstance?.();
|
|
await fn();
|
|
} finally {
|
|
fs.rmSync(dataDir, { recursive: true, force: true });
|
|
const { resetDbInstance } = await import("../../src/lib/db/core");
|
|
resetDbInstance?.();
|
|
if (prevDataDir === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = prevDataDir;
|
|
if (prevKey === undefined) delete process.env.STORAGE_ENCRYPTION_KEY;
|
|
else process.env.STORAGE_ENCRYPTION_KEY = prevKey;
|
|
}
|
|
}
|
|
|
|
test("resolveModelAliasWithSeedFallback: falls back to DEFAULT_MODEL_ALIAS_SEED for unmapped models", async () => {
|
|
await withEmptyAliasDb(async () => {
|
|
const opus = await resolveModelAliasWithSeedFallback("claude-opus-4-6-thinking");
|
|
assert.equal(opus, "agy/claude-opus-4-6-thinking");
|
|
|
|
const flash = await resolveModelAliasWithSeedFallback("gemini-3.6-flash-low");
|
|
assert.equal(flash, "agy/gemini-3.6-flash-low");
|
|
|
|
const unknown = await resolveModelAliasWithSeedFallback("unknown-custom-model-999");
|
|
assert.equal(unknown, "unknown-custom-model-999");
|
|
});
|
|
});
|
|
|
|
// Regression for the 401 the PR fixes: a client sends a model alias that is
|
|
// NOT in the database alias table (empty modelAliases namespace = fresh
|
|
// install / wiped aliases) but IS in the static seed. Before the fix the
|
|
// alias resolved to itself → upstream rejects with 401 "no such model"; after
|
|
// the fix it maps to the seed target (agy/...), which routes to a real model.
|
|
test("resolveModelAliasWithSeedFallback: unmapped-but-seeded alias resolves (401 regression)", async () => {
|
|
await withEmptyAliasDb(async () => {
|
|
const resolved = await resolveModelAliasWithSeedFallback("claude-opus-4-6-thinking");
|
|
assert.equal(resolved, "agy/claude-opus-4-6-thinking");
|
|
});
|
|
});
|
|
|
|
// The exported name must not collide with the sync resolveModelAlias in
|
|
// modelDeprecation.ts / modelSpecs.ts (maintainer review note on PR #10124).
|
|
test("resolveModelAliasWithSeedFallback: export name is distinct from the sync resolveModelAlias", async () => {
|
|
const mod = await import("../../src/lib/modelAliasResolver");
|
|
assert.equal(typeof mod.resolveModelAliasWithSeedFallback, "function");
|
|
assert.equal(mod.resolveModelAlias, undefined, "must not export the colliding sync name");
|
|
});
|