mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-19 05:32:19 +03:00
Alert 806 (js/insecure-randomness, open-sse/executors/tinycms.ts): the TinyCMS nonce is signed into x-secure-signature and reused as x-secure-nonce / x-session-id, so the Math.random() fallback made a signed request predictable and replayable. Use randomUUID() from node:crypto unconditionally. Alert 811 (js/double-escaping, chatgpt-web adapters/environment.ts): decodeXmlText() decoded & before " / ', so the bare & it produced was re-consumed and the text was unescaped twice (&quot; collapsed to "). These values become the trusted Codex sandbox cwd / workspace_roots, so the double-unescape silently rewrote the workspace boundary. Decode & last. Alerts 813/814 (js/incomplete-url-substring-sanitization, test files): replace the includes() URL checks with exact comparisons (new URL(url).hostname === ... and an explicit === over the recorded URL array). Both assertions get strictly tighter. Regression guards: tests/unit/tinycms-secure-nonce-randomness.test.ts and tests/unit/chatgpt-web-environment-double-unescape.test.ts, both failing before the fix and passing after. Co-authored-by: backryun <bakryun0718@proton.me>
86 lines
3.1 KiB
TypeScript
86 lines
3.1 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
const mod = await import("../../open-sse/executors/zai-web.ts");
|
|
|
|
const STALE_URL = "https://chat.z.ai/api/chat/completions";
|
|
const TEST_TOKEN = "e30.eyJpZCI6InVzZXItMTIzIn0.sig";
|
|
|
|
/**
|
|
* #8014 guard: the executor must target the versioned v2 completions endpoint,
|
|
* never the stale unversioned `/api/chat/completions` path, which 404s
|
|
* model-independently as of 2026-07.
|
|
*
|
|
* Setup notes for this flow (the executor now creates a remote chat first and
|
|
* signs the completion request):
|
|
* - a `captcha_verify_param` is required to take the direct HTTP path; without
|
|
* one the executor routes through the browser transport and never calls
|
|
* fetch at all, so the probe would capture nothing.
|
|
* - the completion URL carries the signature payload as a query string, so the
|
|
* assertion matches on pathname rather than the whole URL.
|
|
*/
|
|
test("#8014: ZaiWebExecutor must POST to the current chat.z.ai v2 chat-completions endpoint, not the stale unversioned path", async () => {
|
|
const originalFetch = globalThis.fetch;
|
|
const requested: string[] = [];
|
|
|
|
globalThis.fetch = (async (url: string) => {
|
|
const target = String(url);
|
|
requested.push(target);
|
|
|
|
if (target === STALE_URL) {
|
|
return new Response(JSON.stringify({ detail: "Not Found" }), { status: 404 });
|
|
}
|
|
if (target.startsWith("https://chat.z.ai/api/v1/chats/new")) {
|
|
return new Response(JSON.stringify({ id: "chat-1" }), {
|
|
headers: { "Content-Type": "application/json" },
|
|
});
|
|
}
|
|
return new Response("data: [DONE]\n\n", {
|
|
headers: { "Content-Type": "text/event-stream" },
|
|
});
|
|
}) as typeof fetch;
|
|
|
|
try {
|
|
const executor = new mod.ZaiWebExecutor();
|
|
const result = await executor.execute({
|
|
model: "glm-4.6",
|
|
body: { messages: [{ role: "user", content: "hello" }] },
|
|
stream: false,
|
|
credentials: {
|
|
apiKey: JSON.stringify({ token: TEST_TOKEN, captcha_verify_param: "captcha-proof" }),
|
|
},
|
|
signal: null,
|
|
});
|
|
|
|
assert.ok(requested.length > 0, "the direct path must actually reach fetch");
|
|
|
|
assert.ok(
|
|
// Exact-URL match (not a substring test): `requested` holds whole URLs.
|
|
!requested.some((url) => url === STALE_URL),
|
|
`zai-web executor POSTed to the stale endpoint — matches #8014's model-independent 404 "Not Found"`
|
|
);
|
|
|
|
// The executor also probes the homepage for the frontend version and calls
|
|
// /api/v1/chats/new first, so pick the completions request by its path.
|
|
const completions = requested.filter((u) => new URL(u).pathname.endsWith("/chat/completions"));
|
|
assert.equal(
|
|
completions.length,
|
|
1,
|
|
`expected exactly one completions request, got ${requested}`
|
|
);
|
|
assert.equal(
|
|
new URL(completions[0]).pathname,
|
|
"/api/v2/chat/completions",
|
|
`completions must target the v2 path, got ${completions[0]}`
|
|
);
|
|
|
|
assert.notEqual(
|
|
result.response.status,
|
|
404,
|
|
"chat call must not 404 when the endpoint path is correct"
|
|
);
|
|
} finally {
|
|
globalThis.fetch = originalFetch;
|
|
}
|
|
});
|