mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
170 lines
6.2 KiB
TypeScript
170 lines
6.2 KiB
TypeScript
/**
|
|
* Integration tests: AgentBridge bypass patterns flow
|
|
*
|
|
* Covers:
|
|
* - POST /api/tools/agent-bridge/bypass → stores user patterns
|
|
* - GET /api/tools/agent-bridge/bypass → shows default + user patterns
|
|
* - DELETE /api/tools/agent-bridge/bypass?pattern=X → removes a pattern
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-ab-bypass-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const { seedDefaultBypassPatterns } = await import("../../src/lib/db/agentBridgeBypass.ts");
|
|
const bypassRoute = await import("../../src/app/api/tools/agent-bridge/bypass/route.ts");
|
|
|
|
const DEFAULT_PATTERNS = [".bank.", ".gov.", "okta.com", "auth0.com"];
|
|
|
|
function resetDb() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(() => {
|
|
resetDb();
|
|
seedDefaultBypassPatterns(DEFAULT_PATTERNS);
|
|
});
|
|
|
|
test.after(() => {
|
|
try {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {
|
|
/* noop */
|
|
}
|
|
});
|
|
|
|
// ── POST patterns ──────────────────────────────────────────────────────────
|
|
|
|
test("POST /bypass: stores user patterns", async () => {
|
|
const res = await bypassRoute.POST(
|
|
new Request("http://localhost/api/tools/agent-bridge/bypass", {
|
|
method: "POST",
|
|
headers: { "content-type": "application/json" },
|
|
body: JSON.stringify({ patterns: ["*.mycompany.com", "internal.corp"] }),
|
|
})
|
|
);
|
|
assert.equal(res.status, 200);
|
|
const body = (await res.json()) as {
|
|
ok: boolean;
|
|
patterns: Array<{ pattern: string; source: string }>;
|
|
};
|
|
assert.equal(body.ok, true);
|
|
assert.ok(Array.isArray(body.patterns));
|
|
const userPatterns = body.patterns.filter((p) => p.source === "user");
|
|
assert.equal(userPatterns.length, 2);
|
|
});
|
|
|
|
test("POST /bypass: invalid body returns 400", async () => {
|
|
const res = await bypassRoute.POST(
|
|
new Request("http://localhost/", {
|
|
method: "POST",
|
|
headers: { "content-type": "application/json" },
|
|
body: JSON.stringify({ patterns: "not-an-array" }),
|
|
})
|
|
);
|
|
assert.equal(res.status, 400);
|
|
const body = (await res.json()) as Record<string, unknown>;
|
|
const errMsg = (body.error as Record<string, unknown>)?.message as string;
|
|
assert.ok(!errMsg.includes("at /"), "stack trace leaked in 400 error");
|
|
});
|
|
|
|
// ── GET patterns ───────────────────────────────────────────────────────────
|
|
|
|
test("GET /bypass: shows default + user patterns", async () => {
|
|
// Add user patterns first
|
|
await bypassRoute.POST(
|
|
new Request("http://localhost/", {
|
|
method: "POST",
|
|
headers: { "content-type": "application/json" },
|
|
body: JSON.stringify({ patterns: ["*.mycompany.com"] }),
|
|
})
|
|
);
|
|
|
|
const res = await bypassRoute.GET();
|
|
assert.equal(res.status, 200);
|
|
const body = (await res.json()) as { patterns: Array<{ pattern: string; source: string }> };
|
|
assert.ok(Array.isArray(body.patterns));
|
|
|
|
const sources = new Set(body.patterns.map((p) => p.source));
|
|
assert.ok(sources.has("default"), "No default patterns in response");
|
|
assert.ok(sources.has("user"), "No user patterns in response");
|
|
|
|
const defaultPatterns = body.patterns.filter((p) => p.source === "default");
|
|
assert.ok(defaultPatterns.length >= DEFAULT_PATTERNS.length);
|
|
});
|
|
|
|
test("GET /bypass: error response does not leak stack trace", async () => {
|
|
const res = await bypassRoute.GET();
|
|
const text = await res.text();
|
|
assert.ok(!text.includes("at /"), "stack trace leaked in GET /bypass response");
|
|
});
|
|
|
|
// ── DELETE pattern ─────────────────────────────────────────────────────────
|
|
|
|
test("DELETE /bypass?pattern=X: removes a user pattern", async () => {
|
|
// Add two patterns
|
|
await bypassRoute.POST(
|
|
new Request("http://localhost/", {
|
|
method: "POST",
|
|
headers: { "content-type": "application/json" },
|
|
body: JSON.stringify({ patterns: ["*.mycompany.com", "internal.corp"] }),
|
|
})
|
|
);
|
|
|
|
// Delete one
|
|
const deleteRes = await bypassRoute.DELETE(
|
|
new Request("http://localhost/api/tools/agent-bridge/bypass?pattern=internal.corp", {
|
|
method: "DELETE",
|
|
})
|
|
);
|
|
assert.equal(deleteRes.status, 200);
|
|
const deleteBody = (await deleteRes.json()) as {
|
|
ok: boolean;
|
|
patterns: Array<{ pattern: string; source: string }>;
|
|
};
|
|
assert.equal(deleteBody.ok, true);
|
|
|
|
// Verify it's gone
|
|
const remaining = deleteBody.patterns.filter(
|
|
(p) => p.source === "user" && p.pattern === "internal.corp"
|
|
);
|
|
assert.equal(remaining.length, 0, "Deleted pattern still present");
|
|
|
|
// Other pattern still present
|
|
const kept = deleteBody.patterns.filter(
|
|
(p) => p.source === "user" && p.pattern === "*.mycompany.com"
|
|
);
|
|
assert.equal(kept.length, 1, "Remaining user pattern is missing");
|
|
});
|
|
|
|
test("DELETE /bypass: missing pattern param returns 400", async () => {
|
|
const res = await bypassRoute.DELETE(
|
|
new Request("http://localhost/api/tools/agent-bridge/bypass", {
|
|
method: "DELETE",
|
|
})
|
|
);
|
|
assert.equal(res.status, 400);
|
|
const body = (await res.json()) as Record<string, unknown>;
|
|
const errMsg = (body.error as Record<string, unknown>)?.message as string;
|
|
assert.ok(!errMsg.includes("at /"), "stack trace leaked in DELETE 400");
|
|
});
|
|
|
|
test("DELETE /bypass?pattern=X: no-op when pattern not in user list", async () => {
|
|
const res = await bypassRoute.DELETE(
|
|
new Request("http://localhost/api/tools/agent-bridge/bypass?pattern=not-in-list.com", {
|
|
method: "DELETE",
|
|
})
|
|
);
|
|
assert.equal(res.status, 200);
|
|
const body = (await res.json()) as { ok: boolean };
|
|
assert.equal(body.ok, true);
|
|
});
|