Files
OmniRoute/tests/integration/traffic-inspector-internal-ingest.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

144 lines
4.7 KiB
TypeScript

/**
* Integration tests: Traffic Inspector internal ingest endpoint
*
* Tests:
* - POST without token → 403
* - POST with wrong token → 403
* - POST with valid token + valid body → 200 + buffer push
* - POST with valid token + invalid body → 400 (no stack trace)
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { randomUUID } from "node:crypto";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-ti-ingest-"));
process.env.DATA_DIR = TEST_DATA_DIR;
// Set a known token BEFORE importing the route so the module picks it up
const VALID_TOKEN = "test-ingest-token-abc123xyz789-longer-than-16";
process.env.INSPECTOR_INTERNAL_INGEST_TOKEN = VALID_TOKEN;
const { globalTrafficBuffer } = await import("../../src/mitm/inspector/buffer.ts");
const ingestRoute =
await import("../../src/app/api/tools/traffic-inspector/internal/ingest/route.ts");
function makeIngestRequest(token: string | null, body: unknown): Request {
const headers: Record<string, string> = {
"content-type": "application/json",
};
if (token !== null) {
headers["authorization"] = `Bearer ${token}`;
}
return new Request("http://localhost/api/tools/traffic-inspector/internal/ingest", {
method: "POST",
headers,
body: JSON.stringify(body),
});
}
function minimalEntry(overrides: Record<string, unknown> = {}): Record<string, unknown> {
return {
id: randomUUID(),
timestamp: new Date().toISOString(),
method: "POST",
host: "api.openai.com",
path: "/v1/chat/completions",
source: "agent-bridge",
requestHeaders: {},
requestSize: 0,
responseHeaders: {},
responseSize: 0,
status: 200,
...overrides,
};
}
test.beforeEach(() => {
globalTrafficBuffer.clear();
});
test.after(() => {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("ingest: POST without Authorization header → 403", async () => {
const req = makeIngestRequest(null, minimalEntry());
const res = await ingestRoute.POST(req);
assert.equal(res.status, 403);
const body = (await res.json()) as { error: { message: string } };
assert.ok(!body.error.message.includes("at /"), "must not leak stack trace");
});
test("ingest: POST with wrong token → 403", async () => {
const req = makeIngestRequest("wrong-token", minimalEntry());
const res = await ingestRoute.POST(req);
assert.equal(res.status, 403);
});
test("ingest: POST with empty string token → 403", async () => {
const req = makeIngestRequest("", minimalEntry());
const res = await ingestRoute.POST(req);
assert.equal(res.status, 403);
});
test("ingest: POST with valid token + valid body → 200 + buffer push", async () => {
const id = randomUUID();
const req = makeIngestRequest(VALID_TOKEN, minimalEntry({ id }));
const res = await ingestRoute.POST(req);
assert.equal(res.status, 200);
const body = (await res.json()) as { ok: boolean; id: string };
assert.equal(body.ok, true);
assert.equal(body.id, id);
// Verify the entry was added to the buffer
const entry = globalTrafficBuffer.get(id);
assert.ok(entry, "entry should be in the buffer");
assert.equal(entry?.host, "api.openai.com");
});
test("ingest: valid token + missing required field → 400", async () => {
const req = makeIngestRequest(VALID_TOKEN, {
// missing 'host', 'path', 'source', etc.
id: randomUUID(),
timestamp: new Date().toISOString(),
method: "GET",
});
const res = await ingestRoute.POST(req);
assert.equal(res.status, 400);
const body = (await res.json()) as { error: { message: string } };
assert.ok(!body.error.message.includes("at /"), "must not leak stack trace");
});
test("ingest: valid token + invalid JSON → 400", async () => {
const headers: Record<string, string> = {
"content-type": "application/json",
authorization: `Bearer ${VALID_TOKEN}`,
};
const req = new Request("http://localhost/api/tools/traffic-inspector/internal/ingest", {
method: "POST",
headers,
body: "not valid json",
});
const res = await ingestRoute.POST(req);
assert.equal(res.status, 400);
});
test("ingest: getIngestTokenForBootstrap returns a non-empty token", () => {
const token = ingestRoute.getIngestTokenForBootstrap();
assert.ok(typeof token === "string" && token.length >= 16, "token should be ≥16 chars");
});
test("ingest: multiple pushes accumulate in buffer", async () => {
const ids = [randomUUID(), randomUUID(), randomUUID()];
for (const id of ids) {
const req = makeIngestRequest(VALID_TOKEN, minimalEntry({ id }));
const res = await ingestRoute.POST(req);
assert.equal(res.status, 200);
}
assert.equal(globalTrafficBuffer.size(), 3);
});