mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-19 13:23:50 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
113 lines
4.2 KiB
TypeScript
113 lines
4.2 KiB
TypeScript
/**
|
|
* Integration tests: Traffic Inspector LOCAL_ONLY enforcement
|
|
*
|
|
* Verifies that `isLocalOnlyPath` returns true for all traffic-inspector prefixes
|
|
* and that a simulated non-loopback request to the management policy returns 403.
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-ti-local-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const { isLocalOnlyPath, isLoopbackHost } = await import("../../src/server/authz/routeGuard.ts");
|
|
|
|
test.after(() => {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
// ── isLocalOnlyPath assertions ──────────────────────────────────────────────
|
|
|
|
test("isLocalOnlyPath: traffic-inspector prefix is LOCAL_ONLY", () => {
|
|
assert.equal(
|
|
isLocalOnlyPath("/api/tools/traffic-inspector/"),
|
|
true,
|
|
"root prefix should be LOCAL_ONLY"
|
|
);
|
|
});
|
|
|
|
test("isLocalOnlyPath: ws sub-path is LOCAL_ONLY", () => {
|
|
assert.equal(isLocalOnlyPath("/api/tools/traffic-inspector/ws"), true);
|
|
});
|
|
|
|
test("isLocalOnlyPath: requests sub-path is LOCAL_ONLY", () => {
|
|
assert.equal(isLocalOnlyPath("/api/tools/traffic-inspector/requests"), true);
|
|
});
|
|
|
|
test("isLocalOnlyPath: capture-modes sub-path is LOCAL_ONLY", () => {
|
|
assert.equal(isLocalOnlyPath("/api/tools/traffic-inspector/capture-modes/http-proxy"), true);
|
|
});
|
|
|
|
test("isLocalOnlyPath: sessions sub-path is LOCAL_ONLY", () => {
|
|
assert.equal(isLocalOnlyPath("/api/tools/traffic-inspector/sessions"), true);
|
|
});
|
|
|
|
test("isLocalOnlyPath: internal/ingest is LOCAL_ONLY", () => {
|
|
assert.equal(isLocalOnlyPath("/api/tools/traffic-inspector/internal/ingest"), true);
|
|
});
|
|
|
|
test("isLocalOnlyPath: export.har is LOCAL_ONLY", () => {
|
|
assert.equal(isLocalOnlyPath("/api/tools/traffic-inspector/export.har"), true);
|
|
});
|
|
|
|
test("isLocalOnlyPath: hosts sub-path is LOCAL_ONLY", () => {
|
|
assert.equal(isLocalOnlyPath("/api/tools/traffic-inspector/hosts"), true);
|
|
});
|
|
|
|
// ── isLoopbackHost assertions ───────────────────────────────────────────────
|
|
|
|
test("isLoopbackHost: localhost returns true", () => {
|
|
assert.equal(isLoopbackHost("localhost"), true);
|
|
});
|
|
|
|
test("isLoopbackHost: 127.0.0.1 returns true", () => {
|
|
assert.equal(isLoopbackHost("127.0.0.1"), true);
|
|
});
|
|
|
|
test("isLoopbackHost: example.com returns false", () => {
|
|
assert.equal(isLoopbackHost("example.com"), false);
|
|
});
|
|
|
|
test("isLoopbackHost: external IP returns false", () => {
|
|
assert.equal(isLoopbackHost("192.168.1.100"), false);
|
|
});
|
|
|
|
test("isLoopbackHost: ::1 IPv6 returns true", () => {
|
|
assert.equal(isLoopbackHost("[::1]"), true);
|
|
});
|
|
|
|
// ── Management policy simulation ────────────────────────────────────────────
|
|
|
|
test("management policy: non-loopback request to LOCAL_ONLY path would be blocked", () => {
|
|
// Simulate the guard check that happens in management.ts
|
|
const path2 = "/api/tools/traffic-inspector/requests";
|
|
const hostHeader = "example.com"; // non-loopback
|
|
|
|
const isLocalOnly = isLocalOnlyPath(path2);
|
|
const isLoopback = isLoopbackHost(hostHeader);
|
|
|
|
// The policy blocks when: isLocalOnly && !isLoopback
|
|
assert.equal(isLocalOnly, true, "path should be LOCAL_ONLY");
|
|
assert.equal(isLoopback, false, "example.com should not be loopback");
|
|
// Therefore this request would be blocked (403 LOCAL_ONLY)
|
|
const wouldBeBlocked = isLocalOnly && !isLoopback;
|
|
assert.equal(wouldBeBlocked, true, "non-loopback request to LOCAL_ONLY path should be blocked");
|
|
});
|
|
|
|
test("management policy: loopback request to LOCAL_ONLY path passes IP check", () => {
|
|
const path2 = "/api/tools/traffic-inspector/ws";
|
|
const hostHeader = "localhost";
|
|
|
|
const isLocalOnly = isLocalOnlyPath(path2);
|
|
const isLoopback = isLoopbackHost(hostHeader);
|
|
|
|
assert.equal(isLocalOnly, true);
|
|
assert.equal(isLoopback, true);
|
|
const passesIpCheck = !(isLocalOnly && !isLoopback);
|
|
assert.equal(passesIpCheck, true, "loopback to LOCAL_ONLY path passes IP gate");
|
|
});
|