Files
OmniRoute/tests/integration/traffic-inspector-requests.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

184 lines
6.5 KiB
TypeScript

/**
* Integration tests: Traffic Inspector requests endpoints
*
* Tests GET /requests (with filters), DELETE /requests, GET /requests/[id],
* and PUT /requests/[id]/annotation.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { randomUUID } from "node:crypto";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-ti-reqs-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const { globalTrafficBuffer } = await import("../../src/mitm/inspector/buffer.ts");
const requestsRoute = await import("../../src/app/api/tools/traffic-inspector/requests/route.ts");
const requestDetailRoute =
await import("../../src/app/api/tools/traffic-inspector/requests/[id]/route.ts");
const annotationRoute =
await import("../../src/app/api/tools/traffic-inspector/requests/[id]/annotation/route.ts");
function makeEntry(
overrides: Partial<{
id: string;
host: string;
detectedKind: "llm" | "app" | "unknown";
status: number | "in-flight" | "error";
source: "agent-bridge" | "custom-host" | "http-proxy" | "system-proxy";
}> = {}
) {
return {
id: randomUUID(),
source: "agent-bridge" as const,
timestamp: new Date().toISOString(),
method: "POST",
host: "api.openai.com",
path: "/v1/chat/completions",
requestHeaders: {},
requestBody: null,
requestSize: 0,
responseHeaders: {},
responseBody: null,
responseSize: 0,
status: 200 as const,
detectedKind: "llm" as const,
...overrides,
};
}
test.beforeEach(() => {
globalTrafficBuffer.clear();
});
test.after(() => {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("GET /requests: returns empty list when buffer is empty", async () => {
const req = new Request("http://localhost/api/tools/traffic-inspector/requests");
const res = await requestsRoute.GET(req);
assert.equal(res.status, 200);
const body = (await res.json()) as { requests: unknown[]; total: number };
assert.deepEqual(body.requests, []);
assert.equal(body.total, 0);
});
test("GET /requests: returns all entries without filter", async () => {
globalTrafficBuffer.push(makeEntry({ id: randomUUID(), host: "a.com" }));
globalTrafficBuffer.push(makeEntry({ id: randomUUID(), host: "b.com" }));
const req = new Request("http://localhost/api/tools/traffic-inspector/requests");
const res = await requestsRoute.GET(req);
assert.equal(res.status, 200);
const body = (await res.json()) as { requests: unknown[]; total: number };
assert.equal(body.total, 2);
});
test("GET /requests: filters by profile=llm", async () => {
globalTrafficBuffer.push(makeEntry({ id: randomUUID(), detectedKind: "llm" }));
globalTrafficBuffer.push(makeEntry({ id: randomUUID(), detectedKind: "app" }));
const req = new Request("http://localhost/api/tools/traffic-inspector/requests?profile=llm");
const res = await requestsRoute.GET(req);
assert.equal(res.status, 200);
const body = (await res.json()) as { requests: unknown[]; total: number };
assert.equal(body.total, 1);
});
test("GET /requests: filters by host", async () => {
globalTrafficBuffer.push(makeEntry({ id: randomUUID(), host: "target.com" }));
globalTrafficBuffer.push(makeEntry({ id: randomUUID(), host: "other.com" }));
const req = new Request("http://localhost/api/tools/traffic-inspector/requests?host=target.com");
const res = await requestsRoute.GET(req);
assert.equal(res.status, 200);
const body = (await res.json()) as { requests: Array<{ host: string }>; total: number };
assert.equal(body.total, 1);
assert.equal(body.requests[0]?.host, "target.com");
});
test("GET /requests: rejects invalid profile param with 400", async () => {
const req = new Request("http://localhost/api/tools/traffic-inspector/requests?profile=invalid");
const res = await requestsRoute.GET(req);
assert.equal(res.status, 400);
const body = (await res.json()) as { error: { message: string } };
assert.ok(!body.error.message.includes("at /"), "must not leak stack trace");
});
test("DELETE /requests: clears the buffer", async () => {
globalTrafficBuffer.push(makeEntry());
const res = await requestsRoute.DELETE();
assert.equal(res.status, 204);
assert.equal(globalTrafficBuffer.size(), 0);
});
test("GET /requests/[id]: returns entry by id", async () => {
const entry = makeEntry();
globalTrafficBuffer.push(entry);
const req = new Request(`http://localhost/api/tools/traffic-inspector/requests/${entry.id}`);
const res = await requestDetailRoute.GET(req, {
params: Promise.resolve({ id: entry.id }),
});
assert.equal(res.status, 200);
const body = (await res.json()) as { id: string };
assert.equal(body.id, entry.id);
});
test("GET /requests/[id]: returns 404 for unknown id", async () => {
const req = new Request(`http://localhost/api/tools/traffic-inspector/requests/${randomUUID()}`);
const res = await requestDetailRoute.GET(req, {
params: Promise.resolve({ id: randomUUID() }),
});
assert.equal(res.status, 404);
const body = (await res.json()) as { error: { message: string } };
assert.ok(!body.error.message.includes("at /"), "must not leak stack trace");
});
test("PUT /requests/[id]/annotation: attaches annotation", async () => {
const entry = makeEntry();
globalTrafficBuffer.push(entry);
const req = new Request(
`http://localhost/api/tools/traffic-inspector/requests/${entry.id}/annotation`,
{
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify({ annotation: "my note" }),
}
);
const res = await annotationRoute.PUT(req, {
params: Promise.resolve({ id: entry.id }),
});
assert.equal(res.status, 200);
const body = (await res.json()) as { annotation: string };
assert.equal(body.annotation, "my note");
// Confirm buffer was updated
const updated = globalTrafficBuffer.get(entry.id);
assert.equal(updated?.annotation, "my note");
});
test("PUT /requests/[id]/annotation: rejects annotation > 10000 chars", async () => {
const entry = makeEntry();
globalTrafficBuffer.push(entry);
const req = new Request(
`http://localhost/api/tools/traffic-inspector/requests/${entry.id}/annotation`,
{
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify({ annotation: "x".repeat(10_001) }),
}
);
const res = await annotationRoute.PUT(req, {
params: Promise.resolve({ id: entry.id }),
});
assert.equal(res.status, 400);
});