Files
OmniRoute/tests/integration/traffic-inspector-ws.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

147 lines
4.5 KiB
TypeScript

/**
* Integration tests: Traffic Inspector WebSocket endpoint
*
* Tests WS upgrade, initial snapshot delivery, and live buffer events.
* We do not spin up a full HTTP server — we test the buffer subscribe
* mechanism directly since the WS handler is a thin wrapper around it.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { randomUUID } from "node:crypto";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-ti-ws-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.INSPECTOR_BUFFER_SIZE = "100";
const { TrafficBuffer } = await import("../../src/mitm/inspector/buffer.ts");
const wsRoute = await import("../../src/app/api/tools/traffic-inspector/ws/route.ts");
function makeRequest(upgrade = "websocket", clientKey = "dGhlIHNhbXBsZSBub25jZQ=="): Request {
return new Request("http://localhost/api/tools/traffic-inspector/ws", {
headers: {
upgrade,
"sec-websocket-key": clientKey,
connection: "Upgrade",
},
});
}
test.after(() => {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("ws/route: rejects non-WebSocket GET with 426", async () => {
const req = new Request("http://localhost/api/tools/traffic-inspector/ws");
const res = await wsRoute.GET(req);
assert.equal(res.status, 426);
const body = (await res.json()) as { error: { message: string } };
assert.ok(body.error.message.includes("Upgrade"), "should mention upgrade");
});
test("ws/route: rejects missing Sec-WebSocket-Key with 400", async () => {
const req = new Request("http://localhost/api/tools/traffic-inspector/ws", {
headers: { upgrade: "websocket", connection: "Upgrade" },
});
const res = await wsRoute.GET(req);
assert.equal(res.status, 400);
});
test("ws/route: rejects when no raw socket available with 500", async () => {
const req = makeRequest();
// No `.socket` property injected — Next.js standalone would attach it
const res = await wsRoute.GET(req);
assert.equal(res.status, 500);
const body = (await res.json()) as { error: { message: string } };
assert.ok(!body.error.message.includes("at /"), "must not leak stack trace");
});
test("TrafficBuffer: subscribe receives snapshot immediately", () => {
const buf = new TrafficBuffer(10, 1024 * 1024);
const entry = {
id: randomUUID(),
source: "agent-bridge" as const,
timestamp: new Date().toISOString(),
method: "POST",
host: "api.openai.com",
path: "/v1/chat/completions",
requestHeaders: {},
requestBody: null,
requestSize: 0,
responseHeaders: {},
responseBody: null,
responseSize: 0,
status: 200 as const,
};
buf.push(entry);
const events: unknown[] = [];
const unsub = buf.subscribe((ev) => events.push(ev));
assert.equal(events.length, 1, "should receive snapshot immediately");
const snapshot = events[0] as { type: string; data: unknown[] };
assert.equal(snapshot.type, "snapshot");
assert.ok(Array.isArray(snapshot.data));
assert.equal(snapshot.data.length, 1);
unsub();
});
test("TrafficBuffer: push broadcasts new event to subscribers", () => {
const buf = new TrafficBuffer(10, 1024 * 1024);
const events: unknown[] = [];
const unsub = buf.subscribe((ev) => events.push(ev));
// snapshot is at index 0
buf.push({
id: randomUUID(),
source: "http-proxy" as const,
timestamp: new Date().toISOString(),
method: "GET",
host: "example.com",
path: "/",
requestHeaders: {},
requestBody: null,
requestSize: 0,
responseHeaders: {},
responseBody: null,
responseSize: 0,
status: 200 as const,
});
assert.equal(events.length, 2, "should have snapshot + new event");
const newEv = events[1] as { type: string; data: { host: string } };
assert.equal(newEv.type, "new");
assert.equal(newEv.data.host, "example.com");
unsub();
});
test("TrafficBuffer: unsubscribe stops receiving events", () => {
const buf = new TrafficBuffer(10, 1024 * 1024);
const events: unknown[] = [];
const unsub = buf.subscribe((ev) => events.push(ev));
unsub();
buf.push({
id: randomUUID(),
source: "system-proxy" as const,
timestamp: new Date().toISOString(),
method: "POST",
host: "test.com",
path: "/api",
requestHeaders: {},
requestBody: null,
requestSize: 0,
responseHeaders: {},
responseBody: null,
responseSize: 0,
status: 204 as const,
});
assert.equal(events.length, 1, "should only have the initial snapshot");
});