Files
OmniRoute/tests/unit/10347-embed-402-cooldown.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

106 lines
3.7 KiB
TypeScript

/**
* TDD regression (#10347): the embed path reads a connection's cooldown at
* selection time but NEVER writes one on a terminal upstream failure. A Mistral
* (or any) connection returning HTTP 402 "payment required — Check your
* subscription" on embeds is re-selected and re-hit upstream on every request —
* the repeated EMBED/ERROR/ProxyEgress storm on 3.8.49. Chat wires the cooldown
* write (`markAccountUnavailable`) on hard failures; embed never does.
*
* Repro: create a real mistral apikey connection, mock `globalThis.fetch` to
* return HTTP 402 with a payment-required JSON body, call `handleEmbedding`
* with that connectionId, then assert the connection's `rate_limited_until`
* becomes a future timestamp. Today it stays `undefined` (RED); with the fix
* `markAccountUnavailable` persists a 1h QUOTA_EXHAUSTED cooldown (GREEN).
*/
import { test } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-embed-402-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const { handleEmbedding } = await import("../../open-sse/handlers/embeddings.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
function readConnectionRow(connId: string) {
const db = core.getDbInstance() as unknown as {
prepare: (sql: string) => {
get: (id: string) =>
| {
test_status: unknown;
rate_limited_until: unknown;
last_error_type: unknown;
}
| undefined;
};
};
return db
.prepare(
"SELECT test_status, rate_limited_until, last_error_type FROM provider_connections WHERE id = ?"
)
.get(connId);
}
test("embed 402 marks the connection terminal credits_exhausted (stops re-selection)", async () => {
const conn = await providersDb.createProviderConnection({
provider: "mistral",
authType: "apikey",
name: "embed 402 cooldown",
});
const connId = (conn as { id: string }).id;
const originalFetch = globalThis.fetch;
globalThis.fetch = async () =>
new Response(
JSON.stringify({
code: "subscription_inactive",
message: "Check your subscription",
}),
{
status: 402,
headers: { "content-type": "application/json" },
}
);
try {
const result = await handleEmbedding({
body: { model: "mistral/mistral-embed", input: "ping" },
credentials: { apiKey: "mistral-key" },
connectionId: connId,
log: null,
});
// The upstream was hit and surfaced a 402 — the bug scope.
assert.equal(result.success, false);
assert.equal(result.status, 402);
const row = readConnectionRow(connId);
// markAccountUnavailable classifies a payment-required 402 as the TERMINAL state
// credits_exhausted (last_error_type quota_exhausted) with no transient numeric
// cooldown — the terminal marker is what excludes the account from the embed
// selection path on the next request, stopping the repeat re-hit storm.
assert.equal(
row?.test_status,
"credits_exhausted",
`expected the 402 to mark the connection terminal (test_status=credits_exhausted) on ${connId}, got ${String(
row?.test_status
)}`
);
assert.equal(
row?.last_error_type,
"quota_exhausted",
`expected last_error_type=quota_exhausted on ${connId}, got ${String(row?.last_error_type)}`
);
} finally {
globalThis.fetch = originalFetch;
}
});