mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
155 lines
5.7 KiB
TypeScript
155 lines
5.7 KiB
TypeScript
/**
|
|
* #7993 — "OpenCode Free" is served by TWO distinct provider identities that
|
|
* are never unified: the no-auth "opencode" provider (NOAUTH_PROVIDERS —
|
|
* the id the NoAuthAccountCard UI writes fingerprints + accountProxies onto
|
|
* via a `provider_connections` row) and the "opencode-zen" APIKEY_PROVIDERS
|
|
* gateway (anonymousFallback: true, resolved from the canonical
|
|
* "opencode/<model>" prefix via the #2901 alias override in
|
|
* open-sse/services/model.ts).
|
|
*
|
|
* Before the fix, `getProviderCredentials("opencode-zen")` fell through to
|
|
* `maybeSyntheticNoAuthFallback("opencode-zen", ...)`, which hydrated
|
|
* `providerSpecificData` by querying `provider_connections` filtered by
|
|
* `provider === "opencode-zen"` — a DIFFERENT id than the one the user's
|
|
* connection row is saved under ("opencode") — so the assigned proxy was
|
|
* silently dropped and the request egressed direct.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import net from "node:net";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-7993-noauth-proxy-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const { getProviderCredentials } = await import("../../src/sse/services/auth.ts");
|
|
const { createProviderConnection } = await import("../../src/lib/db/providers.ts");
|
|
const { createProxy } = await import("../../src/lib/db/proxies.ts");
|
|
const { OpencodeExecutor } = await import("../../open-sse/executors/opencode.ts");
|
|
const { resolveProxyForRequest } = await import("../../open-sse/utils/proxyFetch.ts");
|
|
|
|
const log = { debug() {}, info() {}, warn() {}, error() {} };
|
|
const FINGERPRINT = "cccccccccccccccccccccccccccccccc";
|
|
|
|
let proxyServer: net.Server;
|
|
let proxyPort = 0;
|
|
|
|
function listen(server: net.Server): Promise<number> {
|
|
return new Promise((resolve) => {
|
|
server.listen(0, "127.0.0.1", () => {
|
|
resolve((server.address() as net.AddressInfo).port);
|
|
});
|
|
});
|
|
}
|
|
|
|
test.before(async () => {
|
|
proxyServer = net.createServer((s) => s.destroy());
|
|
proxyPort = await listen(proxyServer);
|
|
const proxy = await createProxy({
|
|
name: "opencode-noauth-test-proxy",
|
|
type: "http",
|
|
host: "127.0.0.1",
|
|
port: proxyPort,
|
|
});
|
|
assert.ok(proxy?.id, "test proxy must be persisted in the registry");
|
|
|
|
// Mirror exactly what the NoAuthAccountCard UI writes: a `provider_connections`
|
|
// row filed under the no-auth id "opencode" (NOT "opencode-zen"), carrying the
|
|
// configured account proxy as a Proxy Pool reference.
|
|
await createProviderConnection({
|
|
provider: "opencode",
|
|
authType: "no-auth",
|
|
name: "opencode-noauth-account",
|
|
isActive: true,
|
|
providerSpecificData: {
|
|
fingerprints: [FINGERPRINT],
|
|
accountProxies: [
|
|
{
|
|
fingerprint: FINGERPRINT,
|
|
proxyId: proxy.id,
|
|
},
|
|
],
|
|
},
|
|
});
|
|
});
|
|
|
|
test.after(() => {
|
|
proxyServer?.close();
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("#7993 getProviderCredentials('opencode-zen') hydrates the proxy saved under the sibling 'opencode' connection", async () => {
|
|
const creds = (await getProviderCredentials("opencode-zen")) as {
|
|
connectionId?: string;
|
|
providerSpecificData?: { fingerprints?: unknown; accountProxies?: unknown };
|
|
} | null;
|
|
|
|
assert.ok(creds, "opencode-zen must resolve to credentials");
|
|
assert.ok(
|
|
creds!.connectionId === "noauth" ||
|
|
(typeof creds!.connectionId === "string" && creds!.connectionId.length > 0),
|
|
`expected synthetic noauth or the sibling opencode connection id, got ${creds!.connectionId}`
|
|
);
|
|
const psd = creds!.providerSpecificData || {};
|
|
assert.ok(
|
|
Array.isArray(psd.fingerprints) && psd.fingerprints.length === 1,
|
|
`expected the sibling opencode connection's fingerprints to be hydrated, got ${JSON.stringify(psd)}`
|
|
);
|
|
assert.ok(
|
|
Array.isArray(psd.accountProxies) && psd.accountProxies.length === 1,
|
|
`expected the sibling opencode connection's accountProxies to be hydrated, got ${JSON.stringify(psd)}`
|
|
);
|
|
const accountProxy = (psd.accountProxies as Array<Record<string, unknown>>)[0];
|
|
assert.equal(
|
|
accountProxy.proxyId,
|
|
undefined,
|
|
"request credentials must not retain a raw proxyId"
|
|
);
|
|
assert.deepEqual(accountProxy.proxy, {
|
|
type: "http",
|
|
host: "127.0.0.1",
|
|
port: proxyPort,
|
|
});
|
|
});
|
|
|
|
test("#7993 a canonical 'opencode/<model>' resolved combo/catalog target egresses through the assigned proxy, not direct", async () => {
|
|
const creds = await getProviderCredentials("opencode-zen");
|
|
|
|
const exec = new OpencodeExecutor("opencode-zen");
|
|
let observedSource: string | null = null;
|
|
const originalFetch = globalThis.fetch;
|
|
globalThis.fetch = (async (input: unknown) => {
|
|
const url =
|
|
typeof input === "string" ? input : (input as { url?: string })?.url || String(input);
|
|
observedSource = resolveProxyForRequest(url).source;
|
|
return new Response(JSON.stringify({ ok: true }), {
|
|
status: 200,
|
|
headers: { "Content-Type": "application/json" },
|
|
});
|
|
}) as typeof globalThis.fetch;
|
|
|
|
try {
|
|
const result = await exec.execute({
|
|
model: "deepseek-v4-flash-free",
|
|
body: { messages: [{ role: "user", content: "hi" }], stream: false },
|
|
stream: false,
|
|
signal: null,
|
|
credentials: creds as never,
|
|
log,
|
|
});
|
|
assert.strictEqual((result as { response: Response }).response.status, 200);
|
|
} finally {
|
|
globalThis.fetch = originalFetch;
|
|
}
|
|
|
|
assert.strictEqual(
|
|
observedSource,
|
|
"context",
|
|
`combo/catalog-path ('opencode-zen') must ALSO egress through the assigned proxy — got source=${observedSource}, expected 'context'`
|
|
);
|
|
});
|