mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-19 13:23:50 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
85 lines
2.9 KiB
TypeScript
85 lines
2.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// Permanent regression guard for #8200: a single recoverable 401 on a
|
|
// cookie-auth provider (perplexity-web) must NOT terminal-expire the only
|
|
// connection. Before the fix, resolveTerminalConnectionStatus() mapped ANY
|
|
// non-OAuth 401 to the TERMINAL testStatus "expired" (cooldownMs 0, no
|
|
// self-heal), which then made getProviderCredentials() filter the
|
|
// connection out on the very next request -> "No active credentials".
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-8200-perplexity-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const auth = await import("../../src/sse/services/auth.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("BUG #8200: single perplexity-web 401 (cookie expiry) does not terminal-expire the only connection", async () => {
|
|
await resetStorage();
|
|
|
|
const conn = await providersDb.createProviderConnection({
|
|
provider: "perplexity-web",
|
|
authType: "apikey",
|
|
apiKey: "__Secure-next-auth.session-token=stale-cookie",
|
|
isActive: true,
|
|
testStatus: "active",
|
|
});
|
|
const connId = String(conn.id);
|
|
|
|
await auth.markAccountUnavailable(
|
|
connId,
|
|
401,
|
|
"Perplexity auth failed — session cookie may be expired. Re-paste your __Secure-next-auth.session-token.",
|
|
"perplexity-web",
|
|
"pplx-auto"
|
|
);
|
|
|
|
const after = await providersDb.getProviderConnectionById(connId);
|
|
assert.equal(after.isActive, true, "connection row should stay active");
|
|
assert.notEqual(
|
|
after.testStatus,
|
|
"expired",
|
|
"a recoverable perplexity-web 401 must not be classified terminal 'expired'"
|
|
);
|
|
|
|
const credentials = await auth.getProviderCredentials("perplexity-web");
|
|
assert.notEqual(
|
|
credentials,
|
|
null,
|
|
"getProviderCredentials must still return the connection after exactly one 401"
|
|
);
|
|
});
|
|
|
|
test("markAccountUnavailable keeps the existing 401->expired terminal mapping for plain apikey providers", async () => {
|
|
await resetStorage();
|
|
|
|
const conn = await providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "apikey",
|
|
apiKey: "sk-expired",
|
|
isActive: true,
|
|
testStatus: "active",
|
|
});
|
|
const connId = String(conn.id);
|
|
|
|
await auth.markAccountUnavailable(connId, 401, "unauthorized", "openai", "gpt-4.1");
|
|
|
|
const after = await providersDb.getProviderConnectionById(connId);
|
|
assert.equal(after.testStatus, "expired");
|
|
});
|