mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
118 lines
3.5 KiB
TypeScript
118 lines
3.5 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-8385-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = "test-secret";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const proxiesDb = await import("../../src/lib/db/proxies.ts");
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
|
|
|
|
interface ConnectionRef {
|
|
id: string;
|
|
}
|
|
|
|
interface ProxyResolution {
|
|
level: string | null;
|
|
proxy: unknown;
|
|
}
|
|
|
|
async function resetStorage() {
|
|
delete process.env.INITIAL_PASSWORD;
|
|
core.resetDbInstance();
|
|
apiKeysDb.resetApiKeyState();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("issue #8385: global perKeyProxyEnabled=false must override a connection's per_key_proxy_enabled=1", async () => {
|
|
await resetStorage();
|
|
|
|
core
|
|
.getDbInstance()
|
|
.prepare(
|
|
"INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES ('settings', 'perKeyProxyEnabled', 'false')"
|
|
)
|
|
.run();
|
|
|
|
const conn = (await providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "apikey",
|
|
name: "conn-8385",
|
|
apiKey: "sk-8385",
|
|
})) as unknown as ConnectionRef;
|
|
await providersDb.updateProviderConnection(conn.id, { perKeyProxyEnabled: true });
|
|
|
|
const proxy = await proxiesDb.createProxy({
|
|
name: "Per-Key Proxy 8385",
|
|
type: "http",
|
|
host: "perkey.8385.local",
|
|
port: 8080,
|
|
});
|
|
|
|
const key = await apiKeysDb.createApiKey("probe-8385-key", "machine-8385");
|
|
await apiKeysDb.updateApiKeyPermissions(key.id, { proxyId: proxy.id });
|
|
|
|
const resolved = (await settingsDb.resolveProxyForConnection(
|
|
conn.id,
|
|
key.id
|
|
)) as unknown as ProxyResolution;
|
|
|
|
assert.notEqual(
|
|
resolved?.level,
|
|
"apiKey",
|
|
`expected global-off to override per-key assignment, but got level=${resolved?.level} proxy=${JSON.stringify(resolved?.proxy)}`
|
|
);
|
|
});
|
|
|
|
test("issue #8385: global perKeyProxyEnabled=true still allows the per-key assignment to apply", async () => {
|
|
await resetStorage();
|
|
|
|
core
|
|
.getDbInstance()
|
|
.prepare(
|
|
"INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES ('settings', 'perKeyProxyEnabled', 'true')"
|
|
)
|
|
.run();
|
|
|
|
const conn = (await providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "apikey",
|
|
name: "conn-8385-on",
|
|
apiKey: "sk-8385-on",
|
|
})) as unknown as ConnectionRef;
|
|
await providersDb.updateProviderConnection(conn.id, { perKeyProxyEnabled: true });
|
|
|
|
const proxy = await proxiesDb.createProxy({
|
|
name: "Per-Key Proxy 8385 On",
|
|
type: "http",
|
|
host: "perkey-on.8385.local",
|
|
port: 8081,
|
|
});
|
|
|
|
const key = await apiKeysDb.createApiKey("probe-8385-key-on", "machine-8385-on");
|
|
await apiKeysDb.updateApiKeyPermissions(key.id, { proxyId: proxy.id });
|
|
|
|
const resolved = (await settingsDb.resolveProxyForConnection(
|
|
conn.id,
|
|
key.id
|
|
)) as unknown as ProxyResolution;
|
|
|
|
assert.equal(
|
|
resolved?.level,
|
|
"apiKey",
|
|
`expected global-on to allow the per-key assignment, but got level=${resolved?.level}`
|
|
);
|
|
});
|