mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-17 12:22:34 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
117 lines
4.0 KiB
TypeScript
117 lines
4.0 KiB
TypeScript
import { after, beforeEach, describe, it } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-account-cap-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const { updateProviderConnectionSchema } = await import("../../src/shared/validation/schemas.ts");
|
|
|
|
type Connection = Awaited<ReturnType<typeof providersDb.createProviderConnection>>;
|
|
type StoredConnection = Awaited<ReturnType<typeof providersDb.getProviderConnectionById>>;
|
|
|
|
function assertConnection(connection: Connection): asserts connection is NonNullable<Connection> {
|
|
assert.ok(connection);
|
|
}
|
|
|
|
function assertStoredConnection(
|
|
connection: StoredConnection
|
|
): asserts connection is NonNullable<StoredConnection> {
|
|
assert.ok(connection);
|
|
}
|
|
|
|
function getConnectionId(connection: NonNullable<Connection>): string {
|
|
assert.equal(typeof connection.id, "string");
|
|
return connection.id as string;
|
|
}
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
async function createConnection(maxConcurrent: number | null): Promise<Connection> {
|
|
return providersDb.createProviderConnection({
|
|
provider: "openai",
|
|
authType: "apikey",
|
|
name: `openai-${String(maxConcurrent)}-${Math.random().toString(16).slice(2, 8)}`,
|
|
apiKey: "sk-test",
|
|
maxConcurrent,
|
|
});
|
|
}
|
|
|
|
beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
describe("maxConcurrent DB round-trip", () => {
|
|
it("stores and retrieves maxConcurrent=3", async () => {
|
|
const created = await createConnection(3);
|
|
assertConnection(created);
|
|
const connectionId = getConnectionId(created);
|
|
|
|
const stored = await providersDb.getProviderConnectionById(connectionId);
|
|
assertStoredConnection(stored);
|
|
assert.equal(stored.maxConcurrent, 3);
|
|
});
|
|
|
|
it("stores and retrieves maxConcurrent=null", async () => {
|
|
const created = await createConnection(null);
|
|
assertConnection(created);
|
|
const connectionId = getConnectionId(created);
|
|
|
|
const stored = await providersDb.getProviderConnectionById(connectionId);
|
|
assertStoredConnection(stored);
|
|
assert.equal(stored.maxConcurrent, null);
|
|
});
|
|
|
|
it("stores and retrieves maxConcurrent=0", async () => {
|
|
const created = await createConnection(3);
|
|
assertConnection(created);
|
|
const connectionId = getConnectionId(created);
|
|
|
|
const updated = await providersDb.updateProviderConnection(connectionId, { maxConcurrent: 0 });
|
|
assertConnection(updated);
|
|
assert.equal(updated.maxConcurrent, 0);
|
|
|
|
const stored = await providersDb.getProviderConnectionById(connectionId);
|
|
assertStoredConnection(stored);
|
|
assert.equal(stored.maxConcurrent, 0);
|
|
});
|
|
});
|
|
|
|
describe("maxConcurrent validation", () => {
|
|
it("rejects negative values", () => {
|
|
const result = updateProviderConnectionSchema.safeParse({ maxConcurrent: -1 });
|
|
|
|
assert.equal(result.success, false);
|
|
});
|
|
|
|
it("accepts positive integers", () => {
|
|
const result = updateProviderConnectionSchema.safeParse({ maxConcurrent: 3 });
|
|
|
|
assert.equal(result.success, true);
|
|
assert.equal(result.data.maxConcurrent, 3);
|
|
});
|
|
|
|
it("accepts null/undefined as unlimited", () => {
|
|
const nullResult = updateProviderConnectionSchema.safeParse({ maxConcurrent: null });
|
|
const undefinedResult = updateProviderConnectionSchema.safeParse({ name: "unchanged" });
|
|
|
|
assert.equal(nullResult.success, true);
|
|
assert.equal(nullResult.data.maxConcurrent, null);
|
|
assert.equal(undefinedResult.success, true);
|
|
assert.equal(undefinedResult.data.maxConcurrent, undefined);
|
|
});
|
|
});
|