Files
OmniRoute/tests/unit/agent-bridge-config-portability.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

101 lines
3.3 KiB
TypeScript

/**
* Gap 4: portable JSON import/export of AgentBridge config (bypass patterns +
* custom hosts + per-agent model mappings) so users can replicate a setup
* across machines. Schema validation is pure; export/import roundtrip uses the
* DATA_DIR-tmp + resetDbInstance pattern (CLAUDE.md PII learning #3).
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-agentbridge-config-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const portability = await import("../../src/lib/inspector/configPortability.ts");
async function resetStorage() {
core.resetDbInstance();
for (let attempt = 0; attempt < 10; attempt++) {
try {
if (fs.existsSync(TEST_DATA_DIR))
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
break;
} catch (error: unknown) {
const code = (error as { code?: string } | null)?.code;
if ((code === "EBUSY" || code === "EPERM") && attempt < 9) {
await new Promise((r) => setTimeout(r, 50 * (attempt + 1)));
} else throw error;
}
}
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("AgentBridgeConfigSchema accepts a well-formed config", () => {
const parsed = portability.AgentBridgeConfigSchema.safeParse({
version: 1,
bypassPatterns: ["*.bank.test"],
customHosts: [{ host: "api.internal.test", kind: "custom", label: "Internal" }],
agentMappings: { cursor: [{ source: "gpt-4o", target: "claude-sonnet-4-5" }] },
});
assert.equal(parsed.success, true);
});
test("AgentBridgeConfigSchema rejects a wrong version", () => {
const parsed = portability.AgentBridgeConfigSchema.safeParse({
version: 2,
bypassPatterns: [],
customHosts: [],
agentMappings: {},
});
assert.equal(parsed.success, false);
});
test("AgentBridgeConfigSchema rejects a non-string bypass pattern", () => {
const parsed = portability.AgentBridgeConfigSchema.safeParse({
version: 1,
bypassPatterns: [123],
customHosts: [],
agentMappings: {},
});
assert.equal(parsed.success, false);
});
test("import then export roundtrips bypass + custom hosts + mappings", () => {
const config = {
version: 1 as const,
bypassPatterns: ["*.bank.test", "literal.example.com"],
customHosts: [{ host: "api.internal.test", kind: "custom" as const, label: "Internal LLM" }],
agentMappings: {
cursor: [{ source: "gpt-4o", target: "claude-sonnet-4-5" }],
},
};
portability.importConfig(config);
const exported = portability.exportConfig();
assert.deepEqual(
[...exported.bypassPatterns].sort(),
[...config.bypassPatterns].sort(),
"bypass patterns must roundtrip"
);
assert.ok(
exported.customHosts.some((h) => h.host === "api.internal.test"),
"custom host must roundtrip"
);
assert.deepEqual(
exported.agentMappings.cursor,
config.agentMappings.cursor,
"agent mappings must roundtrip"
);
});