Files
OmniRoute/tests/unit/agent-bridge-server-route-dynamic-import.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

142 lines
5.8 KiB
TypeScript

/**
* Unit tests: agent-bridge/server route — dynamic import behavior
*
* Verifies that start/stop/restart actions resolve MITM manager functions
* from @/mitm/manager.runtime (bypassing the Turbopack alias to stub.ts)
* and that restart re-caches the password after stopMitm clears it.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-ab-dynimp-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
const core = await import("../../src/lib/db/core.ts");
const serverRoute = await import("../../src/app/api/tools/agent-bridge/server/route.ts");
function resetDb() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(() => resetDb());
test.after(() => {
try {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
} catch {
/* noop */
}
});
function makeRequest(action: string, body: Record<string, unknown> = {}) {
return new Request("http://localhost/api/tools/agent-bridge/server", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({ action, ...body }),
});
}
// ── start action ────────────────────────────────────────────────────────────
test("start: dynamically imports startMitm (not stub)", async () => {
// startMitm will fail because there is no real MITM server to spawn,
// but it should throw a runtime error from the real module, NOT the stub error.
const res = await serverRoute.POST(makeRequest("start", { sudoPassword: "test" }));
const body = (await res.json()) as Record<string, unknown>;
// The real startMitm will fail (no MITM binary), but the error should NOT
// contain the stub error message.
const errMsg =
typeof body.error === "object" && body.error !== null
? ((body.error as Record<string, unknown>).message as string)
: "";
assert.ok(
!errMsg.includes("MITM manager stub reached at runtime"),
`Expected real MITM error, got stub error: ${errMsg}`
);
});
// ── stop action ─────────────────────────────────────────────────────────────
test("stop: dynamically imports stopMitm (not stub)", async () => {
const res = await serverRoute.POST(makeRequest("stop", { sudoPassword: "test" }));
const body = (await res.json()) as Record<string, unknown>;
// stopMitm on a non-running server should succeed (no-op cleanup) or fail
// with a real error — never the stub error.
if (res.status !== 200) {
const errMsg =
typeof body.error === "object" && body.error !== null
? ((body.error as Record<string, unknown>).message as string)
: "";
assert.ok(
!errMsg.includes("MITM manager stub reached at runtime"),
`Expected real error, got stub error: ${errMsg}`
);
}
});
// ── restart action ──────────────────────────────────────────────────────────
test("restart: dynamically imports getMitmStatus (not stub)", async () => {
// The real getMitmStatus returns running:false since no server is started.
// The stub also returns running:false, but we verify the path works end-to-end.
const res = await serverRoute.POST(makeRequest("restart", { sudoPassword: "test" }));
const body = (await res.json()) as Record<string, unknown>;
// Should not contain the stub error
const errMsg =
typeof body.error === "object" && body.error !== null
? ((body.error as Record<string, unknown>).message as string)
: "";
assert.ok(
!errMsg.includes("MITM manager stub reached at runtime"),
`Expected real error, got stub error: ${errMsg}`
);
});
test("restart: re-caches password after stopMitm clears it", async () => {
// This test verifies the fix for the cached-password loss bug.
// We can't easily observe the internal cache, but we can verify
// the restart action completes without a "password required" error
// when sudoPassword is provided.
const res = await serverRoute.POST(makeRequest("restart", { sudoPassword: "my-secret-pwd" }));
// Should not fail with an auth-related error — the password should survive the stop phase
assert.ok(res.status === 200 || res.status === 500, `Unexpected status: ${res.status}`);
if (res.status === 500) {
const body = (await res.json()) as Record<string, unknown>;
const errMsg =
typeof body.error === "object" && body.error !== null
? ((body.error as Record<string, unknown>).message as string)
: "";
// Should NOT be a stub error or password-missing error
assert.ok(
!errMsg.includes("MITM manager stub reached at runtime"),
`Got stub error instead of runtime error: ${errMsg}`
);
}
});
// ── existing validation tests (unchanged behavior) ─────────────────────────
test("invalid action returns 400", async () => {
const res = await serverRoute.POST(makeRequest("bogus"));
assert.equal(res.status, 400);
});
test("malformed JSON returns 400", async () => {
const res = await serverRoute.POST(
new Request("http://localhost/api/tools/agent-bridge/server", {
method: "POST",
headers: { "content-type": "application/json" },
body: "not-json",
})
);
assert.equal(res.status, 400);
});