mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-19 21:32:20 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
77 lines
2.8 KiB
TypeScript
77 lines
2.8 KiB
TypeScript
/**
|
|
* #9057 — API key `allowedConnections` MUST gate no-auth synthetic credentials
|
|
*
|
|
* TDD regression test: an API key pinned via `allowedConnections` to a specific
|
|
* connection must NOT receive synthetic no-auth credentials for free providers
|
|
* (e.g. OpenCode Free).
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-9057-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "9057-test-secret";
|
|
|
|
const coreDb = await import("../../src/lib/db/core.ts");
|
|
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
|
|
const { getProviderCredentials } = await import("../../src/sse/services/auth.ts");
|
|
const { isModelAllowedForKey } = await import("../../src/lib/db/apiKeys.ts");
|
|
|
|
const RESTRICTED_CONNECTION_UUID = "00000000-0000-4000-8000-000000000001";
|
|
|
|
test.after(() => {
|
|
coreDb.resetDbInstance();
|
|
try {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {}
|
|
});
|
|
|
|
test("#9057 LAYER1: restricted key gets NO synthetic credentials for OpenCode Free", async () => {
|
|
// LAYER1: getProviderCredentials() with explicit allowedConnections
|
|
// must NOT return synthetic noauth credentials because the synthetic
|
|
// "noauth" connection is never in an explicit allowed-connections list.
|
|
const creds = await getProviderCredentials(
|
|
"opencode",
|
|
null,
|
|
[RESTRICTED_CONNECTION_UUID], // allowedConnections restricts to a real UUID
|
|
"big-pickle"
|
|
);
|
|
assert.equal(
|
|
creds,
|
|
null,
|
|
"OpenCode Free must not leak synthetic credentials for a connection-restricted key"
|
|
);
|
|
});
|
|
|
|
test("#9057 LAYER1: unrestricted key still gets synthetic credentials for OpenCode Free", async () => {
|
|
const creds = await getProviderCredentials(
|
|
"opencode",
|
|
null,
|
|
null, // allowedConnections=null means unrestricted
|
|
"big-pickle"
|
|
);
|
|
assert(creds, "unrestricted key must receive synthetic credentials for OpenCode Free");
|
|
assert.equal(
|
|
(creds as Record<string, unknown>)?.connectionId,
|
|
"noauth",
|
|
"synthetic noauth connection"
|
|
);
|
|
});
|
|
|
|
test("#9057 LAYER2: isModelAllowedForKey rejects keyless model for disableNonPublicModels key", async () => {
|
|
// Create a key with disableNonPublicModels=true
|
|
const created = await apiKeysDb.createApiKey("dnp-9057", "machine-dnp");
|
|
assert(created, "key must be created");
|
|
const key = created.key;
|
|
await apiKeysDb.updateApiKeyPermissions(created.id, {
|
|
disableNonPublicModels: true,
|
|
});
|
|
|
|
const allowed = await isModelAllowedForKey(key, "big-pickle");
|
|
assert.equal(allowed, false, "disableNonPublicModels key must reject keyless models");
|
|
});
|