Files
OmniRoute/tests/unit/api/free-proxies-route.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

108 lines
3.9 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { makeManagementSessionRequest } from "../../helpers/managementSession.ts";
// DATA_DIR must be set before the DB core module evaluates its singleton.
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-free-api-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
const core = await import("../../../src/lib/db/core.ts");
const freeProxiesDb = await import("../../../src/lib/db/freeProxies.ts");
const settingsDb = await import("../../../src/lib/db/settings.ts");
const listRoute = await import("../../../src/app/api/settings/free-proxies/route.ts");
const ORIGINAL_INITIAL_PASSWORD = process.env.INITIAL_PASSWORD;
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
if (ORIGINAL_INITIAL_PASSWORD === undefined) delete process.env.INITIAL_PASSWORD;
else process.env.INITIAL_PASSWORD = ORIGINAL_INITIAL_PASSWORD;
});
function seed(host: string, quality: number, latency: number) {
return freeProxiesDb.upsertFreeProxy({
source: "1proxy",
host,
port: 8080,
type: "http",
countryCode: "US",
qualityScore: quality,
latencyMs: latency,
anonymity: "elite",
lastValidated: "2026-01-01T00:00:00.000Z",
});
}
test("GET returns the full { proxies, total, hasMore, stats, syncErrors } shape", async () => {
await seed("alpha.example", 90, 100);
await seed("bravo.example", 40, 300);
const res = await listRoute.GET(
await makeManagementSessionRequest("http://localhost/api/settings/free-proxies")
);
assert.equal(res.status, 200);
const body = (await res.json()) as {
success: boolean;
data: {
proxies: unknown[];
total: number;
hasMore: boolean;
stats: { total: number; inPool: number; bySource: Array<{ source: string; count: number }> };
syncErrors: Record<string, string[]>;
};
};
assert.equal(body.success, true);
assert.equal(body.data.total, 2);
assert.equal(body.data.proxies.length, 2);
assert.equal(body.data.hasMore, false);
assert.equal(body.data.stats.total, 2);
assert.deepEqual(body.data.syncErrors, {});
});
test("GET search + limit via query params is reflected in the response", async () => {
await seed("alpha.example", 90, 100);
await seed("bravo.example", 40, 300);
const res = await listRoute.GET(
await makeManagementSessionRequest(
"http://localhost/api/settings/free-proxies?search=alph&limit=1"
)
);
assert.equal(res.status, 200);
const body = (await res.json()) as {
data: { proxies: unknown[]; total: number; hasMore: boolean };
};
assert.equal(body.data.total, 1);
assert.equal(body.data.proxies.length, 1);
assert.equal((body.data.proxies[0] as { host: string }).host, "alpha.example");
assert.equal(body.data.hasMore, false);
});
test("GET rejects an unauthenticated request with 401", async () => {
// A fresh DB has no configured password, so a loopback/unauthenticated
// request is treated as the pre-setup bootstrap path and allowed through
// (see `isAuthRequired` in src/shared/utils/apiAuth.ts). Configure a
// password + requireLogin so this test actually exercises the auth gate,
// matching the pattern used by tests/unit/api/settings-audit.test.ts.
process.env.INITIAL_PASSWORD = "free-proxies-route-test-password";
await settingsDb.updateSettings({ requireLogin: true });
const res = await listRoute.GET(new Request("http://localhost/api/settings/free-proxies"));
assert.equal(res.status, 401);
});