mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
96 lines
3.2 KiB
TypeScript
96 lines
3.2 KiB
TypeScript
/**
|
|
* Tests for POST /api/services/cliproxy/provider-expose
|
|
*/
|
|
|
|
import { beforeEach, describe, it } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-cliproxy-provider-expose-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.NODE_ENV = "test";
|
|
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
|
|
|
|
// Initialise DB first.
|
|
const core = await import("../../../../src/lib/db/core.ts");
|
|
const { upsertVersionManagerTool, getVersionManagerTool } =
|
|
await import("../../../../src/lib/db/versionManager.ts");
|
|
|
|
const { POST } = await import("../../../../src/app/api/services/cliproxy/provider-expose/route.ts");
|
|
|
|
function resetDb() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
function makeRequest(body: unknown): Request {
|
|
return new Request("http://localhost/api/services/cliproxy/provider-expose", {
|
|
method: "POST",
|
|
headers: { "Content-Type": "application/json" },
|
|
body: JSON.stringify(body),
|
|
});
|
|
}
|
|
|
|
beforeEach(() => {
|
|
resetDb();
|
|
});
|
|
|
|
describe("POST /api/services/cliproxy/provider-expose", () => {
|
|
it("returns 400 for invalid JSON body", async () => {
|
|
const req = new Request("http://localhost/api/services/cliproxy/provider-expose", {
|
|
method: "POST",
|
|
body: "not-json",
|
|
headers: { "Content-Type": "application/json" },
|
|
});
|
|
const res = await POST(req);
|
|
assert.equal(res.status, 400);
|
|
});
|
|
|
|
it("returns 400 when enabled is missing", async () => {
|
|
const req = makeRequest({});
|
|
const res = await POST(req);
|
|
assert.equal(res.status, 400);
|
|
const body = await res.json();
|
|
assert.ok(body?.error?.message ?? body?.message, "should have an error message");
|
|
});
|
|
|
|
it("returns 400 when enabled is not a boolean", async () => {
|
|
const req = makeRequest({ enabled: "yes" });
|
|
const res = await POST(req);
|
|
assert.equal(res.status, 400);
|
|
});
|
|
|
|
it("sets providerExpose to true and returns 204", async () => {
|
|
await upsertVersionManagerTool({ tool: "cliproxy", status: "stopped" });
|
|
|
|
const req = makeRequest({ enabled: true });
|
|
const res = await POST(req);
|
|
assert.equal(res.status, 204);
|
|
|
|
const row = await getVersionManagerTool("cliproxy");
|
|
assert.equal(row?.providerExpose, true, "providerExpose should be true in DB");
|
|
});
|
|
|
|
it("sets providerExpose to false and returns 204", async () => {
|
|
await upsertVersionManagerTool({ tool: "cliproxy", status: "stopped" });
|
|
|
|
await POST(makeRequest({ enabled: true }));
|
|
const res = await POST(makeRequest({ enabled: false }));
|
|
assert.equal(res.status, 204);
|
|
|
|
const row = await getVersionManagerTool("cliproxy");
|
|
assert.equal(row?.providerExpose, false, "providerExpose should be false in DB");
|
|
});
|
|
|
|
it("error response does not leak stack traces", async () => {
|
|
const req = makeRequest({});
|
|
const res = await POST(req);
|
|
assert.equal(res.status, 400);
|
|
const text = await res.text();
|
|
assert.ok(!text.includes("at /"), "error body must not expose stack trace");
|
|
});
|
|
});
|