mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
57 lines
2.0 KiB
TypeScript
57 lines
2.0 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { findRunnerMismatches } from "../../../scripts/check/check-test-runner-api.mjs";
|
|
|
|
function tmpRepo() {
|
|
const root = fs.mkdtempSync(path.join(os.tmpdir(), "runner-api-"));
|
|
fs.mkdirSync(path.join(root, "tests/unit/autoCombo"), { recursive: true });
|
|
return root;
|
|
}
|
|
|
|
test("flags a vitest-only-dir test that imports node:test", () => {
|
|
const root = tmpRepo();
|
|
fs.writeFileSync(
|
|
path.join(root, "tests/unit/autoCombo/bad.test.ts"),
|
|
`import { describe, it } from "node:test";\ndescribe("x", () => it("y", () => {}));\n`
|
|
);
|
|
const bad = findRunnerMismatches(root);
|
|
assert.equal(bad.length, 1);
|
|
assert.match(bad[0].file.replace(/\\/g, "/"), /autoCombo\/bad\.test\.ts$/);
|
|
assert.match(bad[0].reason, /vitest-only/);
|
|
fs.rmSync(root, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("accepts a vitest-only-dir test that imports vitest", () => {
|
|
const root = tmpRepo();
|
|
fs.writeFileSync(
|
|
path.join(root, "tests/unit/autoCombo/good.test.ts"),
|
|
`import { describe, it } from "vitest";\ndescribe("x", () => it("y", () => {}));\n`
|
|
);
|
|
assert.equal(findRunnerMismatches(root).length, 0);
|
|
fs.rmSync(root, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("flags node:test imports in the Vitest-only config roots", () => {
|
|
const root = tmpRepo();
|
|
const dirs = [
|
|
"open-sse/services/__tests__",
|
|
"open-sse/translator/helpers/__tests__",
|
|
"src/lib/memory/__tests__",
|
|
"src/lib/skills/__tests__",
|
|
];
|
|
|
|
for (const dir of dirs) {
|
|
fs.mkdirSync(path.join(root, dir), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(root, dir, "bad.test.ts"),
|
|
`import { describe, it } from "node:test";\ndescribe("x", () => it("y", () => {}));\n`
|
|
);
|
|
}
|
|
|
|
assert.equal(findRunnerMismatches(root).length, dirs.length);
|
|
fs.rmSync(root, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|