mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
61 lines
2.2 KiB
TypeScript
61 lines
2.2 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { execFileSync } from "node:child_process";
|
|
import { mkdtempSync, readFileSync, rmSync } from "node:fs";
|
|
import { join } from "node:path";
|
|
import { pathToFileURL } from "node:url";
|
|
|
|
// Regression guard for the Node 24 MCP startup crash caused by an ESM init cycle.
|
|
// The published bundle is produced by this exact esbuild invocation in
|
|
// scripts/build/prepublish.ts. Importing the generated file in a fresh Node process
|
|
// catches syntax/link failures that `node --check` does not report for this bundle.
|
|
|
|
const repoRoot = process.cwd();
|
|
|
|
test("MCP server bundle imports successfully on Node 24", () => {
|
|
// Keep the generated bundle below the repository so Node's ESM resolver can
|
|
// find the repository's external production dependencies (for example zod).
|
|
const outDir = mkdtempSync(join(repoRoot, ".mcp-bundle-startup-"));
|
|
const outFile = join(outDir, "server.js");
|
|
|
|
try {
|
|
execFileSync(
|
|
"npx",
|
|
[
|
|
"esbuild",
|
|
"open-sse/mcp-server/server.ts",
|
|
"--bundle",
|
|
"--platform=node",
|
|
"--packages=external",
|
|
"--format=esm",
|
|
`--outfile=${outFile}`,
|
|
],
|
|
{ cwd: repoRoot, stdio: "pipe" }
|
|
);
|
|
|
|
const bundled = readFileSync(outFile, "utf8");
|
|
assert.doesNotMatch(
|
|
bundled,
|
|
/init_googApiKeyAuth[\s\S]{0,300}await init_auth\(\)/,
|
|
"MCP bundle must not contain the auth ↔ googApiKeyAuth circular initializer"
|
|
);
|
|
|
|
const importScript = `await import(${JSON.stringify(pathToFileURL(outFile).href)});`;
|
|
assert.doesNotThrow(() => {
|
|
execFileSync(process.execPath, ["--input-type=module", "-e", importScript], {
|
|
cwd: repoRoot,
|
|
env: {
|
|
...process.env,
|
|
DATA_DIR: join(outDir, "data"),
|
|
DISABLE_SQLITE_AUTO_BACKUP: "true",
|
|
JWT_SECRET: "mcp-bundle-startup-test-jwt-secret-000",
|
|
API_KEY_SECRET: "mcp-bundle-startup-test-api-key-secret",
|
|
},
|
|
stdio: "pipe",
|
|
});
|
|
}, "the generated MCP bundle must be importable by the supported Node runtime");
|
|
} finally {
|
|
rmSync(outDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|