mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
75 lines
3.4 KiB
TypeScript
75 lines
3.4 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { syncStandaloneExtraModules } from "../../../scripts/build/assembleStandalone.mjs";
|
|
|
|
const repoRoot = path.resolve(new URL(".", import.meta.url).pathname, "../../..");
|
|
|
|
/**
|
|
* Regression guard for #9451: the MITM `server.cjs` runs as a separate `node`
|
|
* child process in the Docker standalone bundle, so neither Next.js's
|
|
* file tracer nor the main server's import graph covers its dependencies.
|
|
* `EXTRA_MODULE_ENTRIES` must therefore ship every relative `require()` target
|
|
* of `server.cjs` AND every bare-specifier dynamic `import()` its `_internal/*.cjs`
|
|
* shims perform, or the MITM proxy crashes at boot with MODULE_NOT_FOUND.
|
|
*/
|
|
|
|
test("EXTRA_MODULE_ENTRIES ships every relative require() of MITM server.cjs (#9451)", async () => {
|
|
const serverSrc = fs.readFileSync(path.join(repoRoot, "src/mitm/server.cjs"), "utf8");
|
|
const relRequires = [...serverSrc.matchAll(/require\("\.\/([^"]+)"\)/g)].map((m) => m[1]);
|
|
assert.ok(relRequires.length > 0, "server.cjs has relative require() calls to check (sanity)");
|
|
|
|
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "mitm-bundle-"));
|
|
try {
|
|
await syncStandaloneExtraModules(repoRoot, fs.promises, { log() {} }, tmp);
|
|
for (const rel of relRequires) {
|
|
assert.ok(
|
|
fs.existsSync(path.join(tmp, "src/mitm", rel)),
|
|
`server.cjs requires ./src/mitm/${rel} but EXTRA_MODULE_ENTRIES does not ship it — MITM child crashes with MODULE_NOT_FOUND`
|
|
);
|
|
}
|
|
} finally {
|
|
fs.rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("EXTRA_MODULE_ENTRIES ships every dynamic import() of MITM _internal shims (#9451)", async () => {
|
|
const internalDir = path.join(repoRoot, "src/mitm/_internal");
|
|
const shimFiles = fs.readdirSync(internalDir).filter((f) => f.endsWith(".cjs"));
|
|
assert.ok(shimFiles.length > 0, "src/mitm/_internal has shim files to check (sanity)");
|
|
|
|
// Collect bare-specifier (non-relative, non-node:) dynamic imports across all shims.
|
|
const bareImports = new Set<string>();
|
|
for (const f of shimFiles) {
|
|
const src = fs.readFileSync(path.join(internalDir, f), "utf8");
|
|
for (const m of src.matchAll(/import\("([^"]+)"\)/g)) {
|
|
const spec = m[1];
|
|
if (spec.startsWith("node:") || spec.startsWith(".") || spec.startsWith("/")) continue;
|
|
bareImports.add(spec);
|
|
}
|
|
}
|
|
assert.ok(
|
|
bareImports.size > 0,
|
|
"MITM _internal shims have bare-specifier dynamic import() calls to check (sanity)"
|
|
);
|
|
|
|
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "mitm-bundle-imports-"));
|
|
try {
|
|
await syncStandaloneExtraModules(repoRoot, fs.promises, { log() {} }, tmp);
|
|
for (const spec of bareImports) {
|
|
// Bare specifiers resolve into node_modules/<name>; scoped packages live
|
|
// under node_modules/@scope/. For selfsigned (no nested subpath used at
|
|
// link time) it suffices to check the package directory is shipped.
|
|
const pkgDir = path.join(tmp, "node_modules", ...spec.split("/"));
|
|
assert.ok(
|
|
fs.existsSync(pkgDir),
|
|
`MITM _internal shim dynamic-imports "${spec}" but EXTRA_MODULE_ENTRIES does not ship it — MITM child crashes with MODULE_NOT_FOUND`
|
|
);
|
|
}
|
|
} finally {
|
|
fs.rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|