mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-15 11:22:15 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
67 lines
2.9 KiB
TypeScript
67 lines
2.9 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
import { assembleStandalone } from "../../../scripts/build/assembleStandalone.mjs";
|
|
|
|
// #7346: on macOS (and Linux AppImage) Electron builds, Turbopack's standalone tracer can leave
|
|
// a hollow (directory exists, contains zero files) externalized-package directory behind. #9913
|
|
// added `repairEmptyExternalPackageDirs` to overlay the real source package on top of a hollow
|
|
// bundle dir — but it only scans the TOP-LEVEL `<outDir>/node_modules`. This project builds with
|
|
// a custom, non-default `distDir` (".build/next", see next.config.mjs), and Next's standalone
|
|
// tracer also emits a SECOND, nested `node_modules` under `<outDir>/<relDistDir>/node_modules`
|
|
// (the same location `materializeBundledSymlinks` already treats as a distinct target — see
|
|
// assembleStandalone() step 7). A hollow externalized package dir landing in that nested
|
|
// location is never repaired, which reproduces the exact ERR_MODULE_NOT_FOUND class reported on
|
|
// #7346 even after #6794/#7353/#9913 all landed.
|
|
test("assembleStandalone repairs a hollow externalized package dir in the nested <distDir> node_modules, not just the top-level one", () => {
|
|
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "repair-nested-empty-pkg-"));
|
|
const projectRoot = path.join(tmp, "project");
|
|
const relDistDir = ".build/next";
|
|
const distDir = path.join(projectRoot, relDistDir);
|
|
const outDir = path.join(tmp, "dist");
|
|
|
|
// Real source package the repair should copy from.
|
|
const sourcePkgDir = path.join(projectRoot, "node_modules", "some-nested-pkg");
|
|
fs.mkdirSync(sourcePkgDir, { recursive: true });
|
|
fs.writeFileSync(path.join(sourcePkgDir, "package.json"), '{"name":"some-nested-pkg"}');
|
|
fs.writeFileSync(path.join(sourcePkgDir, "index.js"), "module.exports = {};");
|
|
|
|
// Fake standalone tree with a hollow externalized package dir under the NESTED
|
|
// <relDistDir>/node_modules (directory exists but contains zero files — the exact
|
|
// "hollow" shape repairEmptyExternalPackageDirs already repairs at the top level).
|
|
const standaloneDir = path.join(distDir, "standalone");
|
|
fs.mkdirSync(standaloneDir, { recursive: true });
|
|
fs.writeFileSync(path.join(standaloneDir, "server.js"), "// server");
|
|
const hollowNestedPkgDir = path.join(
|
|
standaloneDir,
|
|
relDistDir,
|
|
"node_modules",
|
|
"some-nested-pkg"
|
|
);
|
|
fs.mkdirSync(hollowNestedPkgDir, { recursive: true });
|
|
|
|
assembleStandalone({
|
|
distDir,
|
|
outDir,
|
|
projectRoot,
|
|
copyNatives: true,
|
|
});
|
|
|
|
const repairedIndexPath = path.join(
|
|
outDir,
|
|
relDistDir,
|
|
"node_modules",
|
|
"some-nested-pkg",
|
|
"index.js"
|
|
);
|
|
assert.ok(
|
|
fs.existsSync(repairedIndexPath),
|
|
"hollow nested externalized package dir must be repaired with the real source package (index.js present)"
|
|
);
|
|
|
|
fs.rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|