mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 10:52:17 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
84 lines
3.1 KiB
TypeScript
84 lines
3.1 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// Regression guard for #8219: the cache-config route imported
|
|
// `updateSettings`/`getDatabaseSettings`/`updateDatabaseSettings` from a
|
|
// non-existent module (`@/lib/localDb/databaseSettings`) and called an
|
|
// undefined `updateSettings` in PUT. Any request crashed the route with a
|
|
// ReferenceError before this fix. This test proves:
|
|
// 1. The route module resolves without throwing on import.
|
|
// 2. GET/PUT resolve without crashing.
|
|
// 3. `modelCatalogCacheTtlMs` round-trips through PUT then GET.
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-cache-config-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
|
|
function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
function makeJsonRequest(method: string, body?: unknown): Request {
|
|
return new Request("http://localhost/api/settings/cache-config", {
|
|
method,
|
|
headers: { "Content-Type": "application/json" },
|
|
body: body === undefined ? undefined : JSON.stringify(body),
|
|
});
|
|
}
|
|
|
|
test.beforeEach(() => {
|
|
resetStorage();
|
|
});
|
|
|
|
test.after(() => {
|
|
resetStorage();
|
|
});
|
|
|
|
test("cache-config route resolves and modelCatalogCacheTtlMs round-trips", async (t) => {
|
|
// Importing the route module must not throw (RED before the fix: the
|
|
// module-level import of a nonexistent path crashed at import time).
|
|
const cacheConfigRoute = await import("../../src/app/api/settings/cache-config/route.ts");
|
|
|
|
await t.test("GET resolves without crashing and returns defaults", async () => {
|
|
const response = await cacheConfigRoute.GET(makeJsonRequest("GET") as never);
|
|
const body = await response.json();
|
|
|
|
assert.equal(response.status, 200);
|
|
assert.equal(typeof body.modelCatalogCacheTtlMs, "number");
|
|
});
|
|
|
|
await t.test("PUT resolves without crashing and persists the new TTL", async () => {
|
|
const putResponse = await cacheConfigRoute.PUT(
|
|
makeJsonRequest("PUT", { modelCatalogCacheTtlMs: 4242 }) as never
|
|
);
|
|
const putBody = await putResponse.json();
|
|
|
|
assert.equal(putResponse.status, 200);
|
|
assert.equal(putBody.ok, true);
|
|
|
|
const getResponse = await cacheConfigRoute.GET(makeJsonRequest("GET") as never);
|
|
const getBody = await getResponse.json();
|
|
|
|
assert.equal(getResponse.status, 200);
|
|
assert.equal(getBody.modelCatalogCacheTtlMs, 4242, "modelCatalogCacheTtlMs must round-trip");
|
|
});
|
|
|
|
await t.test("PUT persists idempotencyWindowMs via the flat settings module", async () => {
|
|
const putResponse = await cacheConfigRoute.PUT(
|
|
makeJsonRequest("PUT", { idempotencyWindowMs: 9000 }) as never
|
|
);
|
|
assert.equal(putResponse.status, 200);
|
|
|
|
const getResponse = await cacheConfigRoute.GET(makeJsonRequest("GET") as never);
|
|
const getBody = await getResponse.json();
|
|
assert.equal(getBody.idempotencyWindowMs, 9000);
|
|
});
|
|
});
|