Files
OmniRoute/tests/unit/call-log-provider-display.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

118 lines
3.7 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(
path.join(os.tmpdir(), "omniroute-call-log-provider-display-")
);
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const callLogs = await import("../../src/lib/usage/callLogs.ts");
const callLogsRoute = await import("../../src/app/api/usage/call-logs/route.ts");
function resetTables() {
const db = core.getDbInstance();
db.prepare("DELETE FROM call_logs").run();
db.prepare("DELETE FROM provider_nodes").run();
db.prepare("DELETE FROM provider_connections").run();
}
function seedProviderNode(id: string, name: string, prefix: string) {
const db = core.getDbInstance();
const now = new Date().toISOString();
db.prepare(
`INSERT OR REPLACE INTO provider_nodes (id, type, name, prefix, api_type, base_url, created_at, updated_at)
VALUES (?, ?, ?, ?, ?, ?, ?, ?)`
).run(id, "provider", name, prefix, "chat", "https://example.com/v1", now, now);
}
test.beforeEach(() => {
resetTables();
});
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("getCallLogs and getCallLogById expose providerDisplay from provider node name", async () => {
const providerId = "openai-compatible-chat-bc66d849-c440-4087-96f7-056bc000b2b9";
seedProviderNode(providerId, "Bynara", "bynara");
const db = core.getDbInstance();
const now = new Date().toISOString();
db.prepare(
`INSERT INTO call_logs (id, timestamp, method, path, status, model, requested_model, provider, account, connection_id, duration, tokens_in, tokens_out)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`
).run(
"log-provider-display-1",
now,
"POST",
"/v1/chat/completions",
200,
"gpt-4.1",
`${providerId}/gpt-4.1`,
providerId,
"acc1",
null,
123,
10,
20
);
const rows = await callLogs.getCallLogs({ limit: 10 });
assert.equal(rows.length, 1);
assert.equal(rows[0].provider, providerId);
assert.equal(rows[0].providerDisplay, "Bynara");
assert.equal(rows[0].requestedModel, "bynara/gpt-4.1");
const detail = await callLogs.getCallLogById("log-provider-display-1");
assert.ok(detail);
assert.equal(detail?.providerDisplay, "Bynara");
assert.equal(detail?.requestedModel, "bynara/gpt-4.1");
});
test("buildCallLogListRows adds providerDisplay to active and completed in-memory rows", () => {
const providerId = "openai-compatible-chat-bc66d849-c440-4087-96f7-056bc000b2b9";
const rows = callLogsRoute.buildCallLogListRows({
logs: [],
connections: [],
providerDisplayNames: new Map([[providerId, "Bynara"]]),
pendingDetails: [
{
id: "pending-1",
startedAt: Date.now() - 1000,
clientEndpoint: "/v1/chat/completions",
model: "gpt-4.1",
provider: providerId,
connectionId: null,
correlationId: "cid-pending",
},
],
completedDetails: [
{
id: "completed-1",
startedAt: Date.now() - 2000,
completedAt: Date.now() - 500,
durationMs: 1500,
clientEndpoint: "/v1/chat/completions",
model: "gpt-4.1",
provider: providerId,
connectionId: null,
correlationId: "cid-completed",
status: 200,
error: null,
},
],
});
const pending = rows.find((row) => row.id === "pending-1");
const completed = rows.find((row) => row.id === "completed-1");
assert.equal(pending?.providerDisplay, "Bynara");
assert.equal(completed?.providerDisplay, "Bynara");
});