mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 10:52:17 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
67 lines
1.9 KiB
TypeScript
67 lines
1.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-call-log-startup-"));
|
|
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
|
|
async function removeTestDataDir() {
|
|
let lastError;
|
|
for (let attempt = 0; attempt < 5; attempt += 1) {
|
|
try {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
return;
|
|
} catch (error: any) {
|
|
lastError = error;
|
|
await new Promise((resolve) => setTimeout(resolve, 25));
|
|
}
|
|
}
|
|
|
|
if (lastError) {
|
|
throw lastError;
|
|
}
|
|
}
|
|
|
|
test.after(async () => {
|
|
if (ORIGINAL_DATA_DIR === undefined) {
|
|
delete process.env.DATA_DIR;
|
|
} else {
|
|
process.env.DATA_DIR = ORIGINAL_DATA_DIR;
|
|
}
|
|
|
|
await removeTestDataDir();
|
|
});
|
|
|
|
test("callLogs startup cleanup swallows unexpected rotateCallLogs bootstrap failures", async () => {
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
const expectedCallLogsDir = path.resolve(TEST_DATA_DIR, "call_logs");
|
|
|
|
const originalExistsSync = fs.existsSync;
|
|
const originalConsoleError = console.error;
|
|
const consoleCalls = [];
|
|
|
|
fs.existsSync = (targetPath, ...args) => {
|
|
if (path.resolve(String(targetPath)) === expectedCallLogsDir) {
|
|
throw new Error("simulated startup exists failure");
|
|
}
|
|
return originalExistsSync.call(fs, targetPath, ...args);
|
|
};
|
|
console.error = (...args) => {
|
|
consoleCalls.push(args.join(" "));
|
|
};
|
|
|
|
try {
|
|
const moduleUrl = new URL("../../src/lib/usage/callLogs.ts?startup-catch", import.meta.url);
|
|
await assert.doesNotReject(() => import(moduleUrl.href));
|
|
} finally {
|
|
fs.existsSync = originalExistsSync;
|
|
console.error = originalConsoleError;
|
|
}
|
|
|
|
assert.ok(consoleCalls.every((line) => typeof line === "string"));
|
|
});
|