Files
OmniRoute/tests/unit/call-logs-exclude-tests-allowlist.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

133 lines
4.0 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
/**
* Home "Recent Requests" feed passes `excludeTests` to getCallLogs so the panel shows
* ONLY real provider inference — never backend/management log rows. The filter is an
* ALLOWLIST of the public gateway namespaces (`/v1/%` and `/api/v1/%`), applied before
* LIMIT, rather than a blacklist of individual known noise types. This guards against
* the reported regression where model-sync rows (request_type 'model-sync', path
* `/api/providers/*`) leaked into the feed because the old blacklist only dropped
* connection-test rows.
*/
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-calllogs-allowlist-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.CALL_LOG_RETENTION_DAYS = "3650";
const core = await import("../../src/lib/db/core.ts");
const callLogs = await import("../../src/lib/usage/callLogs.ts");
type SeedRow = {
id: string;
timestamp: string;
path: string;
model: string;
provider: string;
source_format?: string;
request_type?: string | null;
};
function insertCallLog(row: SeedRow) {
const db = core.getDbInstance();
db.prepare(
`
INSERT INTO call_logs (
id, timestamp, method, path, status, model, provider, source_format, request_type, detail_state
)
VALUES (
@id, @timestamp, 'POST', @path, 200, @model, @provider, @source_format, @request_type, 'none'
)
`
).run({
source_format: row.source_format ?? null,
request_type: row.request_type ?? null,
...row,
});
}
test.beforeEach(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
});
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("excludeTests keeps only /v1 and /api/v1 inference rows, drops all backend/management rows", async () => {
const base = Date.parse("2026-01-01T00:00:00.000Z");
const iso = (i: number) => new Date(base + i * 1000).toISOString();
// Two REAL provider inference rows — the only rows the feed should keep.
insertCallLog({
id: "real-v1",
timestamp: iso(4),
path: "/v1/chat/completions",
model: "openai/gpt-4.1",
provider: "openai",
});
insertCallLog({
id: "real-api-v1",
timestamp: iso(3),
path: "/api/v1/chat/completions",
model: "anthropic/claude-opus-4-8",
provider: "anthropic",
});
// Backend/management NOISE — must never appear in the feed.
insertCallLog({
id: "noise-model-sync",
timestamp: iso(2),
path: "/api/providers/openai/models",
model: "model-sync",
provider: "openai",
source_format: "-",
request_type: "model-sync",
});
insertCallLog({
id: "noise-connection-test",
timestamp: iso(1),
path: "/api/providers/test",
model: "connection-test",
provider: "openai",
source_format: "test",
});
const rows = await callLogs.getCallLogs({ excludeTests: true, limit: 50 });
const ids = rows.map((row) => row.id).sort();
assert.deepEqual(
ids,
["real-api-v1", "real-v1"],
"only the /v1 and /api/v1 inference rows survive the allowlist"
);
});
test("without excludeTests every row is returned (allowlist is opt-in)", async () => {
const base = Date.parse("2026-02-01T00:00:00.000Z");
insertCallLog({
id: "real",
timestamp: new Date(base).toISOString(),
path: "/v1/chat/completions",
model: "openai/gpt-4.1",
provider: "openai",
});
insertCallLog({
id: "sync",
timestamp: new Date(base + 1000).toISOString(),
path: "/api/providers/openai/models",
model: "model-sync",
provider: "openai",
request_type: "model-sync",
});
const rows = await callLogs.getCallLogs({ limit: 50 });
assert.equal(rows.length, 2, "no allowlist → backend rows are not filtered out");
});