mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 10:52:17 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
127 lines
4.4 KiB
TypeScript
127 lines
4.4 KiB
TypeScript
/**
|
|
* Unit tests for src/lib/chaos/chaosConfig.ts
|
|
*
|
|
* Regression coverage for #6679: the original PR queried `SELECT/INSERT/DELETE
|
|
* ... FROM settings ...` against a table that was never created in this schema
|
|
* (only `key_value` exists) — every read silently fell back to
|
|
* DEFAULT_CHAOS_CONFIG and every write/reset threw at runtime. This module now
|
|
* routes persistence through src/lib/db/settings.ts::getSettings/updateSettings
|
|
* (the `key_value` table, namespace 'settings'), matching the repo convention
|
|
* (CLAUDE.md → Database: never write raw SQL outside src/lib/db/).
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-chaos-config-"));
|
|
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const chaosConfig = await import("../../src/lib/chaos/chaosConfig.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
if (ORIGINAL_DATA_DIR === undefined) {
|
|
delete process.env.DATA_DIR;
|
|
} else {
|
|
process.env.DATA_DIR = ORIGINAL_DATA_DIR;
|
|
}
|
|
});
|
|
|
|
test("getChaosConfig returns DEFAULT_CHAOS_CONFIG when nothing is persisted yet", async () => {
|
|
const config = await chaosConfig.getChaosConfig();
|
|
assert.deepEqual(config, chaosConfig.DEFAULT_CHAOS_CONFIG);
|
|
});
|
|
|
|
test("setChaosConfig persists via the settings store and getChaosConfig reads it back", async () => {
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
|
|
const written = await chaosConfig.setChaosConfig({
|
|
enabled: true,
|
|
defaultMode: "collaborative",
|
|
providerOverrides: [{ providerId: "openai", modelId: "gpt-4o", enabled: true }],
|
|
systemPrompt: "Custom prompt",
|
|
timeoutMs: 60_000,
|
|
maxTokens: 8192,
|
|
});
|
|
|
|
assert.equal(written.enabled, true);
|
|
assert.equal(written.defaultMode, "collaborative");
|
|
|
|
const readBack = await chaosConfig.getChaosConfig();
|
|
assert.deepEqual(readBack, written);
|
|
|
|
// Confirms the write actually lands in key_value (namespace 'settings'), not a
|
|
// nonexistent `settings` table (the bug this fix replaces).
|
|
const rawSettings = await settingsDb.getSettings();
|
|
assert.equal((rawSettings as Record<string, unknown>).chaosModeConfig !== undefined, true);
|
|
});
|
|
|
|
test("setChaosConfig rejects invalid config (Zod parse, not raw SQL failure)", async () => {
|
|
const invalidConfig = {
|
|
enabled: true,
|
|
defaultMode: "not-a-real-mode",
|
|
providerOverrides: [],
|
|
timeoutMs: 60_000,
|
|
maxTokens: 4096,
|
|
} as unknown as Awaited<ReturnType<typeof chaosConfig.getChaosConfig>>;
|
|
|
|
await assert.rejects(() => chaosConfig.setChaosConfig(invalidConfig));
|
|
});
|
|
|
|
test("resetChaosConfig clears the stored config back to defaults", async () => {
|
|
await chaosConfig.setChaosConfig({
|
|
enabled: true,
|
|
defaultMode: "parallel",
|
|
providerOverrides: [],
|
|
timeoutMs: 90_000,
|
|
maxTokens: 2048,
|
|
});
|
|
assert.equal((await chaosConfig.getChaosConfig()).enabled, true);
|
|
|
|
const reset = await chaosConfig.resetChaosConfig();
|
|
assert.deepEqual(reset, chaosConfig.DEFAULT_CHAOS_CONFIG);
|
|
assert.deepEqual(await chaosConfig.getChaosConfig(), chaosConfig.DEFAULT_CHAOS_CONFIG);
|
|
});
|
|
|
|
test("getChaosConfig falls back to defaults when the stored payload fails schema validation", async () => {
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
|
|
await settingsDb.updateSettings({
|
|
chaosModeConfig: { enabled: "not-a-boolean", defaultMode: "parallel" },
|
|
});
|
|
|
|
const config = await chaosConfig.getChaosConfig();
|
|
assert.deepEqual(config, chaosConfig.DEFAULT_CHAOS_CONFIG);
|
|
});
|
|
|
|
test("in-memory cache is invalidated on write so config updates are visible immediately", async () => {
|
|
const first = await chaosConfig.getChaosConfig();
|
|
assert.equal(first.enabled, false);
|
|
|
|
await chaosConfig.setChaosConfig({
|
|
enabled: true,
|
|
defaultMode: "parallel",
|
|
providerOverrides: [],
|
|
timeoutMs: 120_000,
|
|
maxTokens: 4096,
|
|
});
|
|
|
|
const second = await chaosConfig.getChaosConfig();
|
|
assert.equal(second.enabled, true);
|
|
});
|