mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
75 lines
2.6 KiB
TypeScript
75 lines
2.6 KiB
TypeScript
// Characterization of writeCavemanOutputAnalytics — the caveman-output-only compression analytics
|
|
// write extracted from handleChatCore's request-setup compression path (chatCore god-file
|
|
// decomposition, #3501). Returns the write promise; uses a real temp DB. Locks: the row written
|
|
// (mode=output-caveman, engine=caveman-output, original==compressed==estimatedTokens, tokens_saved
|
|
// 0, output_mode) and that the returned promise never rejects (best-effort).
|
|
import { test, before, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-caveman-test-"));
|
|
process.env.DATA_DIR = testDataDir;
|
|
|
|
const coreDb = await import("../../src/lib/db/core.ts");
|
|
const { writeCavemanOutputAnalytics } =
|
|
await import("../../open-sse/handlers/chatCore/cavemanOutputAnalytics.ts");
|
|
|
|
function rowFor(requestId: string): Record<string, unknown> | undefined {
|
|
return coreDb
|
|
.getDbInstance()
|
|
.prepare(
|
|
"SELECT mode, engine, original_tokens AS orig, compressed_tokens AS comp, tokens_saved AS saved, output_mode AS om FROM compression_analytics WHERE request_id = ?"
|
|
)
|
|
.get(requestId) as Record<string, unknown> | undefined;
|
|
}
|
|
|
|
before(async () => {
|
|
await coreDb.ensureDbInitialized();
|
|
});
|
|
|
|
after(() => {
|
|
coreDb.resetDbInstance();
|
|
try {
|
|
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {
|
|
// best-effort cleanup
|
|
}
|
|
});
|
|
|
|
test("writes a caveman-output analytics row and the promise resolves", async () => {
|
|
await writeCavemanOutputAnalytics({
|
|
comboName: null,
|
|
provider: "openai",
|
|
compressionComboId: null,
|
|
estimatedTokens: 321,
|
|
skillRequestId: "caveman-req-1",
|
|
cavemanOutputModeIntensity: "heavy",
|
|
});
|
|
const row = rowFor("caveman-req-1");
|
|
assert.ok(row, "expected a compression_analytics row");
|
|
assert.equal(row!.mode, "output-caveman");
|
|
assert.equal(row!.engine, "caveman-output");
|
|
assert.equal(row!.orig, 321);
|
|
assert.equal(row!.comp, 321);
|
|
assert.equal(row!.saved, 0);
|
|
assert.equal(row!.om, "heavy");
|
|
});
|
|
|
|
test("the returned promise never rejects even on a bad write", async () => {
|
|
// resetting the DB instance makes the dynamic insert path fail; the helper must swallow it
|
|
coreDb.resetDbInstance();
|
|
await assert.doesNotReject(
|
|
writeCavemanOutputAnalytics({
|
|
comboName: "combo-x",
|
|
provider: "openai",
|
|
compressionComboId: "cc-1",
|
|
estimatedTokens: 10,
|
|
skillRequestId: "caveman-req-2",
|
|
cavemanOutputModeIntensity: null,
|
|
})
|
|
);
|
|
await coreDb.ensureDbInitialized();
|
|
});
|