Files
OmniRoute/tests/unit/chatcore-compression-settings.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

57 lines
2.1 KiB
TypeScript

// Characterization of resolveCompressionSettings — the compression settings read extracted from
// handleChatCore's Proactive Context Compression setup (chatCore god-file decomposition, #3501).
// Uses a real temp DB (getCompressionSettings reads/seeds the settings row). Locks: the derived
// enabled / contextEditingEnabled flags and the disabled fallback shape.
import { test, before, after } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-comp-settings-test-"));
process.env.DATA_DIR = testDataDir;
const coreDb = await import("../../src/lib/db/core.ts");
const { createDisabledCompressionConfig, resolveCompressionSettings } =
await import("../../open-sse/handlers/chatCore/compressionSettings.ts");
before(async () => {
await coreDb.ensureDbInitialized();
});
after(() => {
coreDb.resetDbInstance();
try {
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
} catch {
// best-effort cleanup
}
});
test("returns the settings object from the DB", async () => {
const result = await resolveCompressionSettings();
assert.ok(result.settings, "expected a settings object from the seeded DB");
});
test("builds a complete disabled compression fallback", () => {
assert.deepEqual(createDisabledCompressionConfig(), {
enabled: false,
defaultMode: "off",
autoTriggerTokens: 0,
cacheMinutes: 5,
preserveSystemPrompt: true,
comboOverrides: {},
engines: {},
activeComboId: null,
});
});
test("derives enabled and contextEditingEnabled from the settings", async () => {
const result = await resolveCompressionSettings();
// `enabled` mirrors settings.enabled exactly
assert.equal(result.enabled, result.settings!.enabled);
// `contextEditingEnabled` is the strict === true derivation of the nested flag
assert.equal(result.contextEditingEnabled, result.settings!.contextEditing?.enabled === true);
assert.equal(typeof result.contextEditingEnabled, "boolean");
});