Files
OmniRoute/tests/unit/chatcore-header-drop-warn-dedupe-10315.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

103 lines
3.3 KiB
TypeScript

// #10315: the header-budget drop warn must not storm — identical dropped-header
// sets recur on every SSE response from the same upstream, so we warn once per
// unique drop fingerprint per process and fall back to debug afterwards.
import { test } from "node:test";
import assert from "node:assert/strict";
const {
buildStreamingResponseHeaders,
fingerprintDroppedHeaders,
resetDroppedHeaderWarnFingerprints,
} = await import("../../open-sse/handlers/chatCore/responseHeaders.ts");
type DropPayload = {
budgetBytes: number;
forwardedBytes: number;
droppedCount: number;
droppedHeaders: Array<{ name: string; bytes: number }>;
};
function makeLogger() {
const warns: DropPayload[] = [];
const debugs: DropPayload[] = [];
return {
logger: {
warn: (_tag: string, _msg: string, data?: DropPayload) => warns.push(data as DropPayload),
debug: (_tag: string, _msg: string, data?: DropPayload) => debugs.push(data as DropPayload),
},
warns,
debugs,
};
}
const meta = {} as Parameters<typeof buildStreamingResponseHeaders>[1];
// Small header + two ~600-byte headers: the first big one fits the 768-byte
// budget alongside the small one, the second is always dropped.
function oversizedProviderHeaders(): Headers {
return new Headers({
"x-kept-small": "k".repeat(10),
"x-drop-alpha": "a".repeat(600),
"x-drop-beta": "b".repeat(600),
});
}
test("#10315: 100 identical oversized responses emit exactly one warn, the rest at debug", () => {
resetDroppedHeaderWarnFingerprints();
const { logger, warns, debugs } = makeLogger();
for (let i = 0; i < 100; i++) {
buildStreamingResponseHeaders(oversizedProviderHeaders(), meta, logger);
}
assert.equal(warns.length, 1);
assert.equal(debugs.length, 99);
assert.equal(warns[0].droppedCount, 1);
});
test("#10315: a different drop set warns again", () => {
resetDroppedHeaderWarnFingerprints();
const { logger, warns } = makeLogger();
buildStreamingResponseHeaders(oversizedProviderHeaders(), meta, logger);
assert.equal(warns.length, 1);
buildStreamingResponseHeaders(
new Headers({
"x-kept-small": "k".repeat(10),
"x-drop-gamma": "g".repeat(600),
"x-drop-delta": "d".repeat(600),
}),
meta,
logger
);
assert.equal(warns.length, 2);
});
test("#10315: fingerprint is order-insensitive to dropped header names", () => {
assert.equal(
fingerprintDroppedHeaders([
{ name: "X-Drop-Beta", bytes: 600 },
{ name: "x-drop-alpha", bytes: 600 },
]),
fingerprintDroppedHeaders([
{ name: "x-drop-alpha", bytes: 600 },
{ name: "X-Drop-Beta", bytes: 600 },
])
);
});
test("#10315: reset hook forgets fingerprints so the same drop set warns again", () => {
resetDroppedHeaderWarnFingerprints();
const { logger, warns } = makeLogger();
buildStreamingResponseHeaders(oversizedProviderHeaders(), meta, logger);
resetDroppedHeaderWarnFingerprints();
buildStreamingResponseHeaders(oversizedProviderHeaders(), meta, logger);
assert.equal(warns.length, 2);
});
test("#10315: responses within budget never warn", () => {
resetDroppedHeaderWarnFingerprints();
const { logger, warns, debugs } = makeLogger();
const headers = buildStreamingResponseHeaders(new Headers({ "x-fits": "ok" }), meta, logger);
assert.equal(headers["x-fits"], "ok");
assert.equal(warns.length, 0);
assert.equal(debugs.length, 0);
});