Files
OmniRoute/tests/unit/chatcore-model-output-cap-wiring.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

147 lines
5.2 KiB
TypeScript

// Direct output-budget tests cannot prove handleChatCore passes capability caps
// through its non-combo runtime path. This drives that public handler with a
// temporary DB and upstream fetch stub.
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-model-cap-wiring-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const overridesDb = await import("../../src/lib/db/modelCapabilityOverrides.ts");
const featureFlagsDb = await import("../../src/lib/db/featureFlags.ts");
const { handleChatCore } = await import("../../open-sse/handlers/chatCore.ts");
const PROVIDER = "capwire-testprov";
const MODEL = "capwire-testmodel";
const OUTPUT_CAP = 1000;
const INPUT_CAP = 10;
const REQUESTED_MAX_TOKENS = 50_000;
const originalFetch = globalThis.fetch;
let dispatchedBody: Record<string, unknown> | null = null;
let fetchCalls = 0;
const silentLog = { debug() {}, info() {}, warn() {}, error() {} };
function buildRequest(maxTokens: number, content = "hello") {
const body = {
model: MODEL,
messages: [{ role: "user", content }],
max_tokens: maxTokens,
stream: false,
};
return {
body,
modelInfo: { provider: PROVIDER, model: MODEL, extendedContext: false },
credentials: {
apiKey: "sk-test",
providerSpecificData: { baseUrl: "https://capwire.example.test" },
},
clientRawRequest: {
endpoint: "/v1/chat/completions",
body,
headers: new Headers({ accept: "application/json" }),
},
userAgent: "unit-test",
isCombo: false,
log: silentLog,
};
}
test.before(() => {
core.resetDbInstance();
assert.equal(
overridesDb.setModelCapabilityOverride(`${PROVIDER}/${MODEL}`, "max_output_tokens", OUTPUT_CAP),
true
);
assert.equal(
overridesDb.setModelCapabilityOverride(`${PROVIDER}/${MODEL}`, "max_input_tokens", INPUT_CAP),
true
);
globalThis.fetch = async (_input: RequestInfo | URL, init?: RequestInit) => {
fetchCalls += 1;
dispatchedBody = init?.body ? JSON.parse(String(init.body)) : null;
return new Response(
JSON.stringify({
id: "chatcmpl-capwire",
choices: [
{ index: 0, message: { role: "assistant", content: "ok" }, finish_reason: "stop" },
],
usage: { prompt_tokens: 1, completion_tokens: 1, total_tokens: 2 },
}),
{ status: 200, headers: { "content-type": "application/json" } }
);
};
});
test.after(() => {
globalThis.fetch = originalFetch;
featureFlagsDb.removeFeatureFlagOverride("DISABLE_CONTEXT_WINDOW_CHECKS");
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("handleChatCore clamps an over-cap max_tokens to the model's output cap before dispatch", async () => {
dispatchedBody = null;
fetchCalls = 0;
await handleChatCore(buildRequest(REQUESTED_MAX_TOKENS));
assert.equal(fetchCalls, 1);
assert.equal(dispatchedBody?.max_tokens, OUTPUT_CAP);
});
test("handleChatCore leaves a max_tokens below the cap untouched", async () => {
dispatchedBody = null;
fetchCalls = 0;
const underCap = OUTPUT_CAP - 1;
await handleChatCore(buildRequest(underCap));
assert.equal(fetchCalls, 1);
assert.equal(dispatchedBody?.max_tokens, underCap);
});
test("handleChatCore rejects input over the model input cap before upstream dispatch", async () => {
dispatchedBody = null;
fetchCalls = 0;
const result = await handleChatCore(buildRequest(1, "x".repeat(200)));
assert.equal(result.status, 400);
assert.equal(fetchCalls, 0, "input-cap rejection must not call the upstream");
assert.match(JSON.stringify(result), /maximum input tokens/i);
});
test("handleChatCore dispatches input within the model input cap", async () => {
dispatchedBody = null;
fetchCalls = 0;
await handleChatCore(buildRequest(1, "x"));
assert.equal(fetchCalls, 1);
assert.ok(dispatchedBody, "input below the cap must reach the upstream");
});
test("DISABLE_CONTEXT_WINDOW_CHECKS lets direct-model input exceed the declared input cap", async () => {
dispatchedBody = null;
fetchCalls = 0;
featureFlagsDb.setFeatureFlagOverride("DISABLE_CONTEXT_WINDOW_CHECKS", "true");
try {
const result = await handleChatCore(buildRequest(1, "x".repeat(200)));
assert.equal(result.success, true);
assert.equal(fetchCalls, 1, "disabled context checks must let the upstream decide");
assert.ok(dispatchedBody, "oversized input must reach the upstream when the flag is enabled");
} finally {
featureFlagsDb.removeFeatureFlagOverride("DISABLE_CONTEXT_WINDOW_CHECKS");
}
});
test("DISABLE_CONTEXT_WINDOW_CHECKS keeps the direct model output cap active", async () => {
dispatchedBody = null;
fetchCalls = 0;
featureFlagsDb.setFeatureFlagOverride("DISABLE_CONTEXT_WINDOW_CHECKS", "true");
try {
const result = await handleChatCore(buildRequest(REQUESTED_MAX_TOKENS, "x".repeat(200)));
assert.equal(result.success, true);
assert.equal(fetchCalls, 1);
assert.equal(dispatchedBody?.max_tokens, OUTPUT_CAP);
} finally {
featureFlagsDb.removeFeatureFlagOverride("DISABLE_CONTEXT_WINDOW_CHECKS");
}
});