mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
129 lines
4.6 KiB
TypeScript
129 lines
4.6 KiB
TypeScript
// Characterization of recordNonStreamingUsageStats — the per-request usage-stats persistence
|
|
// extracted from handleChatCore's non-streaming success path (chatCore god-file decomposition,
|
|
// #3501). Uses a real temp DB and polls usage_history (saveRequestUsage is async +
|
|
// fire-and-forget). Locks: the non-object usage guard (no-op), the field mapping
|
|
// (provider/model/connection/api-key/tokens/serviceTier), and the trace-log line format.
|
|
import { test, before, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-nonstream-usage-test-"));
|
|
process.env.DATA_DIR = testDataDir;
|
|
|
|
const coreDb = await import("../../src/lib/db/core.ts");
|
|
const { getUsageHistory } = await import("../../src/lib/usage/usageHistory.ts");
|
|
const { recordNonStreamingUsageStats } =
|
|
await import("../../open-sse/handlers/chatCore/nonStreamingUsageStats.ts");
|
|
|
|
function baseCtx(overrides: Record<string, unknown> = {}) {
|
|
return {
|
|
traceEnabled: false,
|
|
provider: "openai",
|
|
connectionId: "conn-12345678abc",
|
|
model: "gpt-x",
|
|
startTime: Date.now() - 50,
|
|
apiKeyInfo: { id: "key-1", name: "Key One" },
|
|
effectiveServiceTier: "standard",
|
|
isCombo: false,
|
|
comboStrategy: null,
|
|
...overrides,
|
|
} as Parameters<typeof recordNonStreamingUsageStats>[1];
|
|
}
|
|
|
|
async function rowsFor(provider: string): Promise<Array<Record<string, unknown>>> {
|
|
return (await getUsageHistory({ provider })) as Array<Record<string, unknown>>;
|
|
}
|
|
|
|
async function waitForRows(provider: string, min: number, timeoutMs = 3000) {
|
|
const deadline = Date.now() + timeoutMs;
|
|
while (Date.now() < deadline) {
|
|
const rows = await rowsFor(provider);
|
|
if (rows.length >= min) return rows;
|
|
await new Promise((r) => setTimeout(r, 25));
|
|
}
|
|
return rowsFor(provider);
|
|
}
|
|
|
|
before(async () => {
|
|
await coreDb.ensureDbInitialized();
|
|
});
|
|
|
|
after(() => {
|
|
coreDb.resetDbInstance();
|
|
try {
|
|
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {
|
|
// best-effort cleanup
|
|
}
|
|
});
|
|
|
|
test("non-object usage is a no-op (null, undefined, number, string)", async () => {
|
|
const before = (await rowsFor("guard-prov")).length;
|
|
for (const bad of [null, undefined, 42, "usage", true]) {
|
|
recordNonStreamingUsageStats(bad, baseCtx({ provider: "guard-prov" }));
|
|
}
|
|
// give any (erroneous) async write a chance to land, then assert nothing was persisted
|
|
await new Promise((r) => setTimeout(r, 100));
|
|
const after = (await rowsFor("guard-prov")).length;
|
|
assert.equal(after, before);
|
|
});
|
|
|
|
test("valid usage persists a row with the mapped fields", async () => {
|
|
recordNonStreamingUsageStats(
|
|
{ prompt_tokens: 11, completion_tokens: 7 },
|
|
baseCtx({ provider: "map-prov", model: "gpt-map", connectionId: "conn-abc", isCombo: false })
|
|
);
|
|
const rows = await waitForRows("map-prov", 1);
|
|
assert.equal(rows.length, 1);
|
|
const row = rows[0] as {
|
|
provider: string;
|
|
model: string;
|
|
connectionId: string;
|
|
apiKeyId: string;
|
|
apiKeyName: string;
|
|
success: boolean;
|
|
status: string;
|
|
tokens: { input: number; output: number };
|
|
};
|
|
assert.equal(row.provider, "map-prov");
|
|
assert.equal(row.model, "gpt-map");
|
|
assert.equal(row.connectionId, "conn-abc");
|
|
assert.equal(row.apiKeyId, "key-1");
|
|
assert.equal(row.apiKeyName, "Key One");
|
|
assert.equal(row.success, true);
|
|
assert.equal(row.status, "200");
|
|
assert.equal(row.tokens.input, 11);
|
|
assert.equal(row.tokens.output, 7);
|
|
});
|
|
|
|
test("falls back to 'unknown' provider/model when absent", async () => {
|
|
recordNonStreamingUsageStats(
|
|
{ prompt_tokens: 1, completion_tokens: 1 },
|
|
baseCtx({ provider: null, model: null, apiKeyInfo: null })
|
|
);
|
|
const rows = await waitForRows("unknown", 1);
|
|
const mine = rows.find((r) => (r as { model?: string }).model === "unknown");
|
|
assert.ok(mine, "expected a row with provider/model 'unknown'");
|
|
});
|
|
|
|
test("trace log emits a [USAGE] line with the upper-cased provider when traceEnabled", () => {
|
|
const original = console.log;
|
|
const captured: string[] = [];
|
|
console.log = (...args: unknown[]) => {
|
|
captured.push(args.map(String).join(" "));
|
|
};
|
|
try {
|
|
recordNonStreamingUsageStats(
|
|
{ prompt_tokens: 3, completion_tokens: 2 },
|
|
baseCtx({ provider: "trace-prov", traceEnabled: true })
|
|
);
|
|
} finally {
|
|
console.log = original;
|
|
}
|
|
const usageLine = captured.find((l) => l.includes("[USAGE]"));
|
|
assert.ok(usageLine, "expected a [USAGE] trace line");
|
|
assert.match(usageLine as string, /TRACE-PROV/);
|
|
});
|