Files
OmniRoute/tests/unit/chatcore-output-style-telemetry.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

107 lines
3.5 KiB
TypeScript

// Characterization of emitOutputStyleTelemetry — the output-style run-telemetry hook extracted from
// handleChatCore's request-setup compression path (chatCore god-file decomposition, #3501).
// Fire-and-forget; uses a real temp DB and polls compression_run_telemetry. Locks: the null guard
// (no-op), and that an applied output-style result records a run-telemetry row with the resolved
// request id / model / provider / source.
import { test, before, after } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-os-telemetry-test-"));
process.env.DATA_DIR = testDataDir;
const coreDb = await import("../../src/lib/db/core.ts");
const { emitOutputStyleTelemetry } =
await import("../../open-sse/handlers/chatCore/outputStyleTelemetry.ts");
function rowFor(requestId: string): Record<string, unknown> | undefined {
try {
return coreDb
.getDbInstance()
.prepare(
"SELECT request_id, model, provider, source FROM compression_run_telemetry WHERE request_id = ?"
)
.get(requestId) as Record<string, unknown> | undefined;
} catch {
// table is created lazily by the first fire-and-forget insert; treat "no such table" as "no row"
return undefined;
}
}
async function waitForRow(requestId: string, timeoutMs = 3000) {
const deadline = Date.now() + timeoutMs;
while (Date.now() < deadline) {
if (rowFor(requestId)) break;
await new Promise((r) => setTimeout(r, 25));
}
return rowFor(requestId);
}
before(async () => {
await coreDb.ensureDbInitialized();
});
after(() => {
coreDb.resetDbInstance();
try {
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
} catch {
// best-effort cleanup
}
});
test("null outputStyleResult is a no-op (returns synchronously, no throw)", async () => {
assert.doesNotThrow(() =>
emitOutputStyleTelemetry({
outputStyleResult: null,
skillRequestId: "os-noop",
traceId: "t",
effectiveModel: "gpt-x",
provider: "openai",
compressionComboId: null,
estimatedTokens: 100,
})
);
await new Promise((r) => setTimeout(r, 80));
assert.equal(rowFor("os-noop"), undefined);
});
test("applied output-style result records a run-telemetry row (source=active-profile when combo id set)", async () => {
emitOutputStyleTelemetry({
outputStyleResult: {
body: {} as never,
applied: true,
appliedStyles: [],
skippedReason: undefined,
},
skillRequestId: "os-req-1",
traceId: "trace-1",
effectiveModel: "gpt-os",
provider: "openai",
compressionComboId: "combo-9",
estimatedTokens: 250,
});
const row = await waitForRow("os-req-1");
assert.ok(row, "expected a compression_run_telemetry row");
assert.equal(row!.model, "gpt-os");
assert.equal(row!.provider, "openai");
assert.equal(row!.source, "active-profile");
});
test("falls back to traceId for request id and source=default without a combo id", async () => {
emitOutputStyleTelemetry({
outputStyleResult: { body: {} as never, applied: true, appliedStyles: [] },
skillRequestId: null,
traceId: "os-trace-2",
effectiveModel: "gpt-x",
provider: "anthropic",
compressionComboId: null,
estimatedTokens: 10,
});
const row = await waitForRow("os-trace-2");
assert.ok(row, "expected the row keyed by the traceId fallback");
assert.equal(row!.source, "default");
});