Files
OmniRoute/tests/unit/chatcore-streaming-quota-share.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

96 lines
3.1 KiB
TypeScript

// Characterization of scheduleStreamingQuotaShareConsumption — the streaming shared-quota POST-hook
// extracted from handleChatCore's onStreamComplete (chatCore god-file decomposition, #3501). Sync
// fire-and-forget / fail-open. The injected calculateCost is used as the observable. Locks: the
// guard (missing ids OR streamStatus != 200 → no recording) and that a valid 200 stream resolves
// the cost via calculateCost.
import { test, before, after } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-stream-quota-test-"));
process.env.DATA_DIR = testDataDir;
const coreDb = await import("../../src/lib/db/core.ts");
const { scheduleStreamingQuotaShareConsumption } =
await import("../../open-sse/handlers/chatCore/streamingQuotaShare.ts");
function makeCostSpy() {
const calls: Array<{ provider: string; model: string }> = [];
const calculateCost = async (provider: string, model: string) => {
calls.push({ provider, model });
return 0.0042;
};
return { calculateCost, calls };
}
async function waitFor(pred: () => boolean, timeoutMs = 2000): Promise<void> {
const deadline = Date.now() + timeoutMs;
while (Date.now() < deadline && !pred()) {
await new Promise((r) => setTimeout(r, 10));
}
}
before(async () => {
await coreDb.ensureDbInitialized();
});
after(() => {
coreDb.resetDbInstance();
try {
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
} catch {
// best-effort cleanup
}
});
test("streamStatus != 200 records nothing (calculateCost never called)", async () => {
const { calculateCost, calls } = makeCostSpy();
scheduleStreamingQuotaShareConsumption({
apiKeyId: "key-1",
connectionId: "conn-1",
provider: "openai",
model: "gpt-x",
streamUsage: { prompt_tokens: 10, completion_tokens: 5 },
streamStatus: 500,
serviceTier: "standard",
calculateCost,
});
await new Promise((r) => setTimeout(r, 80));
assert.equal(calls.length, 0);
});
test("missing connectionId records nothing", async () => {
const { calculateCost, calls } = makeCostSpy();
scheduleStreamingQuotaShareConsumption({
apiKeyId: "key-1",
connectionId: null,
provider: "openai",
model: "gpt-x",
streamUsage: { prompt_tokens: 10 },
streamStatus: 200,
calculateCost,
});
await new Promise((r) => setTimeout(r, 80));
assert.equal(calls.length, 0);
});
test("valid 200 stream resolves cost via injected calculateCost", async () => {
const { calculateCost, calls } = makeCostSpy();
scheduleStreamingQuotaShareConsumption({
apiKeyId: "key-1",
connectionId: "conn-1",
provider: "deepseek",
model: "deepseek-chat",
streamUsage: { prompt_tokens: 100, completion_tokens: 50 },
streamStatus: 200,
serviceTier: "standard",
calculateCost,
});
await waitFor(() => calls.length > 0);
assert.equal(calls.length, 1);
assert.equal(calls[0].provider, "deepseek");
assert.equal(calls[0].model, "deepseek-chat");
});