mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-21 22:32:22 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
119 lines
4.1 KiB
TypeScript
119 lines
4.1 KiB
TypeScript
// @ts-nocheck
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import test from "node:test";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-directive-midconv-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const { handleChatCore } = await import("../../open-sse/handlers/chatCore.ts");
|
|
|
|
const originalFetch = globalThis.fetch;
|
|
|
|
function noopLog() {
|
|
return {
|
|
debug() {},
|
|
info() {},
|
|
warn() {},
|
|
error() {},
|
|
};
|
|
}
|
|
|
|
async function flushAsyncSideEffects() {
|
|
for (let i = 0; i < 5; i++) await new Promise((resolve) => setImmediate(resolve));
|
|
}
|
|
|
|
test.afterEach(async () => {
|
|
globalThis.fetch = originalFetch;
|
|
await flushAsyncSideEffects();
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
});
|
|
|
|
test.after(() => {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("claude mid-conversation-system passthrough relocates a directive-only messages[0]", async () => {
|
|
let captured = null;
|
|
|
|
globalThis.fetch = async (url, init = {}) => {
|
|
captured = {
|
|
url: String(url),
|
|
method: init.method ?? "GET",
|
|
headers: new Headers(init.headers),
|
|
body: JSON.parse(String(init.body || "{}")),
|
|
};
|
|
return new Response(
|
|
JSON.stringify({
|
|
id: "msg_test",
|
|
type: "message",
|
|
role: "assistant",
|
|
model: "claude-opus-5",
|
|
content: [{ type: "text", text: "OK" }],
|
|
usage: { input_tokens: 4, output_tokens: 1 },
|
|
}),
|
|
{ status: 200, headers: { "Content-Type": "application/json" } }
|
|
);
|
|
};
|
|
|
|
const body = {
|
|
model: "claude-opus-5",
|
|
max_tokens: 64,
|
|
system: [{ type: "text", text: "You are Claude." }],
|
|
tools: [{ name: "Bash", description: "Run a command", input_schema: { type: "object" } }],
|
|
messages: [
|
|
{ role: "system", content: [], output_config: { effort: "medium" } },
|
|
{ role: "user", content: "hello" },
|
|
],
|
|
stream: false,
|
|
};
|
|
|
|
const result = await handleChatCore({
|
|
body: structuredClone(body),
|
|
modelInfo: { provider: "claude", model: "claude-opus-5", extendedContext: false },
|
|
credentials: { apiKey: "test-claude-key", providerSpecificData: {} },
|
|
log: noopLog(),
|
|
clientRawRequest: {
|
|
endpoint: "/v1/messages",
|
|
body: structuredClone(body),
|
|
headers: new Headers({
|
|
accept: "application/json",
|
|
"content-type": "application/json",
|
|
"user-agent": "claude-code/2.1.154",
|
|
}),
|
|
},
|
|
userAgent: "claude-code/2.1.154",
|
|
});
|
|
|
|
assert.ok(captured, "fetch was not called");
|
|
assert.ok(captured.url.startsWith("https://api.anthropic.com/v1/messages"));
|
|
assert.equal(captured.method, "POST");
|
|
assert.ok(captured.headers.get("x-api-key"), "x-api-key header missing");
|
|
assert.ok(captured.headers.get("anthropic-version"), "anthropic-version header missing");
|
|
assert.equal(result.success, true);
|
|
// The directive-only message must not sit at messages[0] when it reaches upstream.
|
|
const upstreamMessages = captured.body.messages;
|
|
assert.equal(upstreamMessages[0].role, "user");
|
|
assert.equal(upstreamMessages[1].role, "system");
|
|
assert.deepEqual(upstreamMessages[1].output_config, { effort: "medium" });
|
|
// The relocation must not disturb anything else the client sent.
|
|
assert.deepEqual(upstreamMessages[1].content, []);
|
|
assert.equal(upstreamMessages[0].content, "hello");
|
|
// The claude identity layer prepends its own blocks; assert the client's
|
|
// block survived rather than an exact count.
|
|
assert.ok(
|
|
captured.body.system.some((block) => block.type === "text" && block.text === "You are Claude.")
|
|
);
|
|
assert.equal(captured.body.tools.length, 1);
|
|
// The directive stays message-level; the top level (if set) is the base
|
|
// executor's own default injection, not the hoisted directive value.
|
|
assert.notDeepEqual(captured.body.output_config, { effort: "medium" });
|
|
});
|