mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-21 06:12:17 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
94 lines
3.3 KiB
TypeScript
94 lines
3.3 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { EventEmitter } from "node:events";
|
|
import { mkdtempSync, rmSync } from "node:fs";
|
|
import { createRequire, syncBuiltinESMExports } from "node:module";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { pathToFileURL } from "node:url";
|
|
|
|
import { buildNodeRuntimeArgs } from "../../scripts/build/runtime-env.mjs";
|
|
|
|
const require = createRequire(import.meta.url);
|
|
const childProcess = require("node:child_process");
|
|
const originalSpawn = childProcess.spawn;
|
|
|
|
test.afterEach(() => {
|
|
childProcess.spawn = originalSpawn;
|
|
syncBuiltinESMExports();
|
|
});
|
|
|
|
test("Node server runtime prefers IPv4 DNS before the server entrypoint", () => {
|
|
assert.deepEqual(buildNodeRuntimeArgs({}, 2048, "/app/server.js"), [
|
|
"--dns-result-order=ipv4first",
|
|
"--max-old-space-size=2048",
|
|
"/app/server.js",
|
|
]);
|
|
});
|
|
|
|
test("Node server runtime preserves an explicit heap setting while preferring IPv4", () => {
|
|
assert.deepEqual(
|
|
buildNodeRuntimeArgs(
|
|
{ NODE_OPTIONS: "--enable-source-maps --max-old-space-size=8192" },
|
|
512,
|
|
"/app/server.js"
|
|
),
|
|
["--dns-result-order=ipv4first", "/app/server.js"]
|
|
);
|
|
});
|
|
|
|
test("ServerSupervisor starts Node with IPv4-first DNS", async () => {
|
|
const spawnCalls: Array<{ command: string; args: string[] }> = [];
|
|
const child = Object.assign(new EventEmitter(), {
|
|
pid: 2699,
|
|
stdout: new EventEmitter(),
|
|
stderr: new EventEmitter(),
|
|
});
|
|
childProcess.spawn = (command: string, args: string[]) => {
|
|
spawnCalls.push({ command, args });
|
|
return child;
|
|
};
|
|
syncBuiltinESMExports();
|
|
|
|
const dataDir = mkdtempSync(join(tmpdir(), "omniroute-ipv4-first-"));
|
|
const previousDataDir = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = dataDir;
|
|
// The supervisor reads process.env (not its own `env`) to decide whether an
|
|
// explicit --max-old-space-size is already pinned via NODE_OPTIONS, in which
|
|
// case it suppresses its own heap flag (envHasExplicitHeapFlag). CI runs with
|
|
// no heap flag in NODE_OPTIONS, but this suite can be launched with an ambient
|
|
// NODE_OPTIONS=--max-old-space-size=... (e.g. the sandbox exports one), which
|
|
// would make the supervisor legitimately drop the flag and fail the assertion
|
|
// below. Neutralize it for the duration of this test so the expectation
|
|
// matches the CI environment.
|
|
const previousNodeOptions = process.env.NODE_OPTIONS;
|
|
delete process.env.NODE_OPTIONS;
|
|
|
|
try {
|
|
const moduleUrl = pathToFileURL(
|
|
join(process.cwd(), "bin/cli/runtime/processSupervisor.mjs")
|
|
).href;
|
|
const { ServerSupervisor } = await import(`${moduleUrl}?ipv4-first=${Date.now()}`);
|
|
const supervisor = new ServerSupervisor({
|
|
serverPath: "/app/server.js",
|
|
env: {},
|
|
memoryLimit: 2048,
|
|
});
|
|
|
|
supervisor.start();
|
|
|
|
assert.deepEqual(spawnCalls, [
|
|
{
|
|
command: process.execPath,
|
|
args: ["--dns-result-order=ipv4first", "--max-old-space-size=2048", "/app/server.js"],
|
|
},
|
|
]);
|
|
} finally {
|
|
if (previousDataDir === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = previousDataDir;
|
|
if (previousNodeOptions === undefined) delete process.env.NODE_OPTIONS;
|
|
else process.env.NODE_OPTIONS = previousNodeOptions;
|
|
rmSync(dataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|